Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1256720 > unrolled thread

[PATCH v2] Staging: android: uapi: fixed comment block coding style error in ion.h

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] Staging: android: uapi: fixed comment block coding style error in ion.h Dzonatans Melgalvis <dz.melgalvis@gmail.com> - 2015-10-27 13:10 +0100
    Re: [PATCH v2] Staging: android: uapi: fixed comment block coding  style error in ion.h Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-28 07:00 +0100

#1256720 — [PATCH v2] Staging: android: uapi: fixed comment block coding style error in ion.h

Fixed checkpatch.pl warning about comment block coding style.

Signed-off-by: Dzonatans Melgalvis <dz.melgalvis@gmail.com
---
 drivers/staging/android/uapi/ion.h | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
index 68a14b4..8573d59 100644
--- a/drivers/staging/android/uapi/ion.h
+++ b/drivers/staging/android/uapi/ion.h
@@ -56,13 +56,23 @@ enum ion_heap_type {
  * allocation flags - the lower 16 bits are used by core ion, the upper 16
  * bits are reserved for use by the heaps themselves.
  */
-#define ION_FLAG_CACHED 1		/* mappings of this buffer should be
-					   cached, ion will do cache
-					   maintenance when the buffer is
-					   mapped for dma */
-#define ION_FLAG_CACHED_NEEDS_SYNC 2	/* mappings of this buffer will created
-					   at mmap time, if this is set
-					   caches must be managed manually */
+
+/*
+ * mappings of this buffer should be
+ * cached, ion will do cache
+ * maintenance when the buffer is
+ * mapped for dma
+ */
+
+#define ION_FLAG_CACHED 1
+
+/*
+ * mappings of this buffer will be created
+ * at mmap time, if this is set
+ * caches must be managed manually
+ */
+
+#define ION_FLAG_CACHED_NEEDS_SYNC 2
 
 /**
  * DOC: Ion Userspace API
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1257686 — Re: [PATCH v2] Staging: android: uapi: fixed comment block coding style error in ion.h

On Tue, Oct 27, 2015 at 02:04:54PM +0200, Dzonatans Melgalvis wrote:
> Fixed checkpatch.pl warning about comment block coding style.
> 
> Signed-off-by: Dzonatans Melgalvis <dz.melgalvis@gmail.com

The email address in Signed-off-by should end with '>'.

This change has already been done by:
7e4161747bc6 ("staging: android: Fix checkpatch block comments warnings")

which tree you are using?

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web