Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1254347 > unrolled thread

[PATCH v3 0/3] Add RT5033 Flash LED driver

Started byIngi Kim <ingi2.kim@samsung.com>
First post2015-10-23 07:50 +0200
Last post2015-10-28 04:50 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v3 0/3] Add RT5033 Flash LED driver Ingi Kim <ingi2.kim@samsung.com> - 2015-10-23 07:50 +0200
    [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033 Ingi Kim <ingi2.kim@samsung.com> - 2015-10-23 07:50 +0200
      Re: [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033 Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-10-26 11:20 +0100
        Re: [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033 Ingi Kim <ingi2.kim@samsung.com> - 2015-10-28 04:50 +0100

#1254347 — [PATCH v3 0/3] Add RT5033 Flash LED driver

FromIngi Kim <ingi2.kim@samsung.com>
Date2015-10-23 07:50 +0200
Subject[PATCH v3 0/3] Add RT5033 Flash LED driver
Message-ID<qmDoK-AJ-15@gated-at.bofh.it>
This patch supports flash led of RT5033 PMIC.

Changes since v3:
 - Use mutex and work queue
 - Split brightness set func (sync / async)
 - Add flash API (flash_brightness_set)
 - Move struct(rt5033_led_config_data) to local area
 - Code clean

Changes since v2:
 - Split MFC code from rt5033 flash led patch
 - Fix typo error
 - Change naming of mfd register back again
 - Fix compile error

Ingi Kim (3):
  leds: rt5033: Add DT binding for RT5033
  mfd: rt5033: Add RT5033 Flash led sub device
  leds: rt5033: Add RT5033 Flash led device driver

 .../devicetree/bindings/leds/leds-rt5033.txt       |  38 +++
 drivers/leds/Kconfig                               |   8 +
 drivers/leds/Makefile                              |   1 +
 drivers/leds/leds-rt5033.c                         | 314 +++++++++++++++++++++
 drivers/mfd/rt5033.c                               |   3 +
 include/linux/mfd/rt5033-private.h                 |  49 ++++
 include/linux/mfd/rt5033.h                         |  13 +
 7 files changed, 426 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt
 create mode 100644 drivers/leds/leds-rt5033.c

-- 
2.0.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1254349 — [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033

FromIngi Kim <ingi2.kim@samsung.com>
Date2015-10-23 07:50 +0200
Subject[PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033
Message-ID<qmDoL-AJ-27@gated-at.bofh.it>
In reply to#1254347
This patch adds the device tree bindings for RT5033 flash LEDs.

Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/leds/leds-rt5033.txt       | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt

diff --git a/Documentation/devicetree/bindings/leds/leds-rt5033.txt b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
new file mode 100644
index 0000000..2ef7bdc
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
@@ -0,0 +1,38 @@
+* Richtek Technology Corporation - RT5033 Flash LED Driver
+
+The RT5033 Flash LED Circuit is designed for one or two LEDs driving
+for torch and strobe applications, it provides an I2C software command
+to trigger the torch and strobe operation.
+
+Required properties:
+- compatible : Must be "richtek,rt5033-led".
+
+A discrete LED element connected to the device must be represented by a child
+node - see Documentation/devicetree/bindings/leds/common.txt.
+
+Required properties of the LED child node:
+  See Documentation/devicetree/bindings/leds/common.txt
+- led-max-microamp : Minimum Threshold for Timer protection
+  is defined internally (Maximum 200mA).
+- flash-max-microamp : Flash LED maximum current
+- flash-max-timeout-us : Flash LED maximum timeout
+
+Optional properties of the LED child node:
+- label : see Documentation/devicetree/bindings/leds/common.txt
+
+Example:
+
+rt5033 {
+	compatible = "richtek,rt5033";
+
+	led {
+		compatible = "richtek,rt5033-led";
+
+		flash-led {
+			label = "rt5033-flash";
+			led-max-microamp = <200000>;
+			flash-max-microamp = <800000>;
+			flash-max-timeout-us = <1216000>;
+		};
+	};
+}
-- 
2.0.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1255795 — Re: [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033

FromJacek Anaszewski <j.anaszewski@samsung.com>
Date2015-10-26 11:20 +0100
SubjectRe: [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033
Message-ID<qnN2G-6Yh-3@gated-at.bofh.it>
In reply to#1254349
Hi Ingi,

On 10/23/2015 07:48 AM, Ingi Kim wrote:
> This patch adds the device tree bindings for RT5033 flash LEDs.
>
> Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
>   .../devicetree/bindings/leds/leds-rt5033.txt       | 38 ++++++++++++++++++++++
>   1 file changed, 38 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-rt5033.txt b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
> new file mode 100644
> index 0000000..2ef7bdc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
> @@ -0,0 +1,38 @@
> +* Richtek Technology Corporation - RT5033 Flash LED Driver
> +
> +The RT5033 Flash LED Circuit is designed for one or two LEDs driving

These bindings don't say how to handle two LEDs case.

> +for torch and strobe applications, it provides an I2C software command
> +to trigger the torch and strobe operation.
> +
> +Required properties:
> +- compatible : Must be "richtek,rt5033-led".
> +
> +A discrete LED element connected to the device must be represented by a child
> +node - see Documentation/devicetree/bindings/leds/common.txt.
> +
> +Required properties of the LED child node:
> +  See Documentation/devicetree/bindings/leds/common.txt
> +- led-max-microamp : Minimum Threshold for Timer protection
> +  is defined internally (Maximum 200mA).
> +- flash-max-microamp : Flash LED maximum current
> +- flash-max-timeout-us : Flash LED maximum timeout
> +
> +Optional properties of the LED child node:
> +- label : see Documentation/devicetree/bindings/leds/common.txt
> +
> +Example:
> +
> +rt5033 {
> +	compatible = "richtek,rt5033";
> +
> +	led {
> +		compatible = "richtek,rt5033-led";
> +
> +		flash-led {
> +			label = "rt5033-flash";
> +			led-max-microamp = <200000>;
> +			flash-max-microamp = <800000>;
> +			flash-max-timeout-us = <1216000>;
> +		};
> +	};
> +}
>


-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257643 — Re: [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033

FromIngi Kim <ingi2.kim@samsung.com>
Date2015-10-28 04:50 +0100
SubjectRe: [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033
Message-ID<qopUm-5KM-5@gated-at.bofh.it>
In reply to#1255795
Hi Jacek,

Oh, I see. I'll add.
Thanks for the review.

On 2015년 10월 26일 19:11, Jacek Anaszewski wrote:
> Hi Ingi,
> 
> On 10/23/2015 07:48 AM, Ingi Kim wrote:
>> This patch adds the device tree bindings for RT5033 flash LEDs.
>>
>> Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
>> Acked-by: Rob Herring <robh@kernel.org>
>> ---
>>   .../devicetree/bindings/leds/leds-rt5033.txt       | 38 ++++++++++++++++++++++
>>   1 file changed, 38 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-rt5033.txt b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
>> new file mode 100644
>> index 0000000..2ef7bdc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-rt5033.txt
>> @@ -0,0 +1,38 @@
>> +* Richtek Technology Corporation - RT5033 Flash LED Driver
>> +
>> +The RT5033 Flash LED Circuit is designed for one or two LEDs driving
> 
> These bindings don't say how to handle two LEDs case.
> 
>> +for torch and strobe applications, it provides an I2C software command
>> +to trigger the torch and strobe operation.
>> +
>> +Required properties:
>> +- compatible : Must be "richtek,rt5033-led".
>> +
>> +A discrete LED element connected to the device must be represented by a child
>> +node - see Documentation/devicetree/bindings/leds/common.txt.
>> +
>> +Required properties of the LED child node:
>> +  See Documentation/devicetree/bindings/leds/common.txt
>> +- led-max-microamp : Minimum Threshold for Timer protection
>> +  is defined internally (Maximum 200mA).
>> +- flash-max-microamp : Flash LED maximum current
>> +- flash-max-timeout-us : Flash LED maximum timeout
>> +
>> +Optional properties of the LED child node:
>> +- label : see Documentation/devicetree/bindings/leds/common.txt
>> +
>> +Example:
>> +
>> +rt5033 {
>> +    compatible = "richtek,rt5033";
>> +
>> +    led {
>> +        compatible = "richtek,rt5033-led";
>> +
>> +        flash-led {
>> +            label = "rt5033-flash";
>> +            led-max-microamp = <200000>;
>> +            flash-max-microamp = <800000>;
>> +            flash-max-timeout-us = <1216000>;
>> +        };
>> +    };
>> +}
>>
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web