Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257525 > unrolled thread

[PATCH 05/10] merge_config.sh: Better handling of CONFIG_FOO=n

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 05/10] merge_config.sh: Better handling of CONFIG_FOO=n Olof Johansson <olof@lixom.net> - 2015-10-28 01:50 +0100
    Re: [PATCH 05/10] merge_config.sh: Better handling of CONFIG_FOO=n Darren Hart <dvhart@infradead.org> - 2015-10-28 07:30 +0100
      Re: [PATCH 05/10] merge_config.sh: Better handling of CONFIG_FOO=n Bruce Ashfield <bruce.ashfield@windriver.com> - 2015-10-28 07:40 +0100

#1257525 — [PATCH 05/10] merge_config.sh: Better handling of CONFIG_FOO=n

Kconfig knows how to handle CONFIG_FOO=n just fine, but it'll always
use "# CONFIG FOO is not set" in the resulting config. Mangle the input
accordingly so we don't report this as a failure when it isn't.

Signed-off-by: Olof Johansson <olof@lixom.net>
---
 scripts/kconfig/merge_config.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
index c244042..933f2d6 100755
--- a/scripts/kconfig/merge_config.sh
+++ b/scripts/kconfig/merge_config.sh
@@ -39,7 +39,7 @@ usage() {
 }
 
 getval() {
-	grep -w -e "$1" "$2"
+	grep -w -e "$1" "$2" | sed 's/^CONFIG_\(.*\)=n$/# CONFIG_\1 is not set/g'
 }
 
 CONF_IS_ERR=false
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1257704

On Wed, Oct 28, 2015 at 09:42:06AM +0900, Olof Johansson wrote:
> Kconfig knows how to handle CONFIG_FOO=n just fine, but it'll always
> use "# CONFIG FOO is not set" in the resulting config. Mangle the input
> accordingly so we don't report this as a failure when it isn't.
> 
> Signed-off-by: Olof Johansson <olof@lixom.net>

Matching Kconfig behavior is the logical approach, no point in complaining if
Kconfig will accpet the result.

Bruce, I think we'll just need to update the linux-yocto tool documentation not
to mark =n as wrong.

Reviewed-by: Darren Hart <dvhart@linux.intel.com>

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257708

On 10/28/2015 02:26 AM, Darren Hart wrote:
> On Wed, Oct 28, 2015 at 09:42:06AM +0900, Olof Johansson wrote:
>> Kconfig knows how to handle CONFIG_FOO=n just fine, but it'll always
>> use "# CONFIG FOO is not set" in the resulting config. Mangle the input
>> accordingly so we don't report this as a failure when it isn't.
>>
>> Signed-off-by: Olof Johansson <olof@lixom.net>
>
> Matching Kconfig behavior is the logical approach, no point in complaining if
> Kconfig will accpet the result.
>
> Bruce, I think we'll just need to update the linux-yocto tool documentation not
> to mark =n as wrong.

purists still think it is wrong :) The tools don't report this as
an error anymore, so there's no change here.

Bruce

>
> Reviewed-by: Darren Hart <dvhart@linux.intel.com>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web