Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1252667 > unrolled thread

[PATCH 03/19] rtc: opal: enable support for the stardard "wakeup-source" property

Started bySudeep Holla <sudeep.holla@arm.com>
First post2015-10-21 12:20 +0200
Last post2015-10-28 00:00 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 03/19] rtc: opal: enable support for the stardard "wakeup-source" property Sudeep Holla <sudeep.holla@arm.com> - 2015-10-21 12:20 +0200
    Re: [PATCH 03/19] rtc: opal: enable support for the stardard  "wakeup-source" property Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-10-28 00:00 +0100

#1252667 — [PATCH 03/19] rtc: opal: enable support for the stardard "wakeup-source" property

FromSudeep Holla <sudeep.holla@arm.com>
Date2015-10-21 12:20 +0200
Subject[PATCH 03/19] rtc: opal: enable support for the stardard "wakeup-source" property
Message-ID<qlYEW-8lO-3@gated-at.bofh.it>
Though the opal rtc driver should and will continue to support the legacy
"has-tpo" property to enable RTC as the wakeup source, we need to add
support for the new standard property "wakeup-source"

This patch adds support for "wakeup-source" property in addition to the
existing "has-tpo" property.

Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: rtc-linux@googlegroups.com
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/rtc/rtc-opal.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-opal.c b/drivers/rtc/rtc-opal.c
index 6fbf9e617151..4087d53ecd73 100644
--- a/drivers/rtc/rtc-opal.c
+++ b/drivers/rtc/rtc-opal.c
@@ -199,8 +199,9 @@ static int opal_rtc_probe(struct platform_device *pdev)
 {
 	struct rtc_device *rtc;
 
-	if (pdev->dev.of_node && of_get_property(pdev->dev.of_node, "has-tpo",
-						 NULL)) {
+	if (pdev->dev.of_node &&
+	    (of_property_read_bool(pdev->dev.of_node, "wakeup-source") ||
+	     of_property_read_bool(pdev->dev.of_node, "has-tpo")/* legacy */)) {
 		device_set_wakeup_capable(&pdev->dev, true);
 		opal_rtc_ops.read_alarm	= opal_get_tpo_time;
 		opal_rtc_ops.set_alarm = opal_set_tpo_time;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1257449 — Re: [PATCH 03/19] rtc: opal: enable support for the stardard "wakeup-source" property

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2015-10-28 00:00 +0100
SubjectRe: [PATCH 03/19] rtc: opal: enable support for the stardard "wakeup-source" property
Message-ID<qolnH-2I6-3@gated-at.bofh.it>
In reply to#1252667
On 21/10/2015 at 11:10:00 +0100, Sudeep Holla wrote :
> Though the opal rtc driver should and will continue to support the legacy
> "has-tpo" property to enable RTC as the wakeup source, we need to add
> support for the new standard property "wakeup-source"
> 
> This patch adds support for "wakeup-source" property in addition to the
> existing "has-tpo" property.
> 
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: rtc-linux@googlegroups.com
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/rtc/rtc-opal.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web