Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257446 > unrolled thread

Re: [Intel-wired-lan] [PATCHv2] ixgbe: Wait for 1ms, not 1us, after RST

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [Intel-wired-lan] [PATCHv2] ixgbe: Wait for 1ms, not 1us, after  RST Peter Hurley <peter@hurleysoftware.com> - 2015-10-27 23:50 +0100
    Re: [Intel-wired-lan] [PATCHv2] ixgbe: Wait for 1ms, not 1us, after  RST "Keller, Jacob E" <jacob.e.keller@intel.com> - 2015-10-28 00:10 +0100

#1257446 — Re: [Intel-wired-lan] [PATCHv2] ixgbe: Wait for 1ms, not 1us, after RST

On 10/27/2015 02:35 PM, ND Linux CI Server wrote:
> Greetings,
> 
> This email is automatically generated by ND's Linux Patch Testing framework
> based on aiaiai. I have performed some automatic testing of a patch (series)
> you submitted to intel-wired-lan@lists.osuosl.org
> 
> The following contains output of any tests which failed to pass, and might be
> the result of developer error. The tests performed include but may not be
> limited to checkpatch.pl, bisection testing, compilation on a default kernel
> config, coccinelle scripts, cppcheck, and smatch.
> 
> If you have received this email in error, or believe that aiaiai has detected a
> false positive, please email Jacob Keller <jacob.e.keller@intel.com>.

False positive.

As long as the delay is at least 1ms (which is guaranteed), slightly longer
delays (relative to the existing reset delay of 100ms) are not harmful.

Use of usleep_range() would be unnecessary overkill for the purpose.

Regards,
Peter Hurley


> ---
> 
> I have tested your changes
> 
> [Intel-wired-lan] [PATCHv2] ixgbe: Wait for 1ms, not 1us, after RST
> 
> Project: net (net-current development queue)
> 
> Configurations: intel_defconfig,x86
> 
> Tested the patch(es) on top of the following commits:
> 505b857 ixgbe: Reset interface after enabling SR-IOV
> ce9d9b8 net: sysctl: fix a kmemleak warning
> 1acea4f ppp: fix pppoe_dev deletion condition in pppoe_release()
> f6b8dec9 af_key: fix two typos
> 
> --------------------------------------------------------------------------------
> 
> Successfully built configuration "intel_defconfig,x86", no issues.
> 
> --------------------------------------------------------------------------------
> 
> checkpatch.pl has some complaints:
> 
> --------------------------------------------------------------------------------
> 
> checkpatch.pl results for patch "[PATCH] ixgbe: Wait for 1ms, not 1us, after RST"
> 
> WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
> #29: FILE: drivers/net/ethernet/intel/ixgbe/ixgbe_x540.c:119:
> +	msleep(1);
> 
> total: 0 errors, 1 warnings, 0 checks, 13 lines checked
> 
> --------------------------------------------------------------------------------


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1257458

T24gVHVlLCAyMDE1LTEwLTI3IGF0IDE4OjQ1IC0wNDAwLCBQZXRlciBIdXJsZXkgd3JvdGU6DQo+
IE9uIDEwLzI3LzIwMTUgMDI6MzUgUE0sIE5EIExpbnV4IENJIFNlcnZlciB3cm90ZToNCj4gPiBH
cmVldGluZ3MsDQo+ID4gDQo+ID4gVGhpcyBlbWFpbCBpcyBhdXRvbWF0aWNhbGx5IGdlbmVyYXRl
ZCBieSBORCdzIExpbnV4IFBhdGNoIFRlc3RpbmcNCj4gPiBmcmFtZXdvcmsNCj4gPiBiYXNlZCBv
biBhaWFpYWkuIEkgaGF2ZSBwZXJmb3JtZWQgc29tZSBhdXRvbWF0aWMgdGVzdGluZyBvZiBhIHBh
dGNoDQo+ID4gKHNlcmllcykNCj4gPiB5b3Ugc3VibWl0dGVkIHRvIGludGVsLXdpcmVkLWxhbkBs
aXN0cy5vc3Vvc2wub3JnDQo+ID4gDQo+ID4gVGhlIGZvbGxvd2luZyBjb250YWlucyBvdXRwdXQg
b2YgYW55IHRlc3RzIHdoaWNoIGZhaWxlZCB0byBwYXNzLA0KPiA+IGFuZCBtaWdodCBiZQ0KPiA+
IHRoZSByZXN1bHQgb2YgZGV2ZWxvcGVyIGVycm9yLiBUaGUgdGVzdHMgcGVyZm9ybWVkIGluY2x1
ZGUgYnV0IG1heQ0KPiA+IG5vdCBiZQ0KPiA+IGxpbWl0ZWQgdG8gY2hlY2twYXRjaC5wbCwgYmlz
ZWN0aW9uIHRlc3RpbmcsIGNvbXBpbGF0aW9uIG9uIGENCj4gPiBkZWZhdWx0IGtlcm5lbA0KPiA+
IGNvbmZpZywgY29jY2luZWxsZSBzY3JpcHRzLCBjcHBjaGVjaywgYW5kIHNtYXRjaC4NCj4gPiAN
Cj4gPiBJZiB5b3UgaGF2ZSByZWNlaXZlZCB0aGlzIGVtYWlsIGluIGVycm9yLCBvciBiZWxpZXZl
IHRoYXQgYWlhaWFpDQo+ID4gaGFzIGRldGVjdGVkIGENCj4gPiBmYWxzZSBwb3NpdGl2ZSwgcGxl
YXNlIGVtYWlsIEphY29iIEtlbGxlciA8amFjb2IuZS5rZWxsZXJAaW50ZWwuY29tDQo+ID4gPi4N
Cj4gDQo+IEZhbHNlIHBvc2l0aXZlLg0KPiANCj4gQXMgbG9uZyBhcyB0aGUgZGVsYXkgaXMgYXQg
bGVhc3QgMW1zICh3aGljaCBpcyBndWFyYW50ZWVkKSwgc2xpZ2h0bHkNCj4gbG9uZ2VyDQo+IGRl
bGF5cyAocmVsYXRpdmUgdG8gdGhlIGV4aXN0aW5nIHJlc2V0IGRlbGF5IG9mIDEwMG1zKSBhcmUg
bm90DQo+IGhhcm1mdWwuDQo+IA0KPiBVc2Ugb2YgdXNsZWVwX3JhbmdlKCkgd291bGQgYmUgdW5u
ZWNlc3Nhcnkgb3ZlcmtpbGwgZm9yIHRoZSBwdXJwb3NlLg0KPiANCj4gUmVnYXJkcywNCj4gUGV0
ZXIgSHVybGV5DQoNCg0KRmVlbCBmcmVlIHRvIGlnbm9yZSB0aGlzIHRoZW4uDQoNClJlZ2FyZHMs
DQpKYWtl
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web