Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257041 > unrolled thread

[PATCH 04/15] serial/fsl_lpuart: Deinline lpuart_transmit_buffer, save 176 bytes

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 04/15] serial/fsl_lpuart: Deinline lpuart_transmit_buffer, save 176 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2015-10-27 18:50 +0100
    Re: [PATCH 04/15] serial/fsl_lpuart: Deinline lpuart_transmit_buffer,  save 176 bytes Peter Hurley <peter@hurleysoftware.com> - 2015-10-27 19:30 +0100

#1257041 — [PATCH 04/15] serial/fsl_lpuart: Deinline lpuart_transmit_buffer, save 176 bytes

This function compiles to 172 bytes of machine code.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Peter Hurley <peter@hurleysoftware.com>
CC: Jiri Slaby <jslaby@suse.com>
CC: linux-serial@vger.kernel.org
---
 drivers/tty/serial/fsl_lpuart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 08ce76f..ac26303 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -527,7 +527,7 @@ static inline void lpuart_prepare_rx(struct lpuart_port *sport)
 	spin_unlock_irqrestore(&sport->port.lock, flags);
 }
 
-static inline void lpuart_transmit_buffer(struct lpuart_port *sport)
+static void lpuart_transmit_buffer(struct lpuart_port *sport)
 {
 	struct circ_buf *xmit = &sport->port.state->xmit;
 
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1257118 — Re: [PATCH 04/15] serial/fsl_lpuart: Deinline lpuart_transmit_buffer, save 176 bytes

On 10/27/2015 01:46 PM, Denys Vlasenko wrote:
> This function compiles to 172 bytes of machine code.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Peter Hurley <peter@hurleysoftware.com>
> CC: Jiri Slaby <jslaby@suse.com>
> CC: linux-serial@vger.kernel.org
> ---
>  drivers/tty/serial/fsl_lpuart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
> index 08ce76f..ac26303 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -527,7 +527,7 @@ static inline void lpuart_prepare_rx(struct lpuart_port *sport)
>  	spin_unlock_irqrestore(&sport->port.lock, flags);
>  }
>  
> -static inline void lpuart_transmit_buffer(struct lpuart_port *sport)
> +static void lpuart_transmit_buffer(struct lpuart_port *sport)
>  {
>  	struct circ_buf *xmit = &sport->port.state->xmit;

You'll want to run your script(s) on Greg's tty-next tree;
this file has copy+paste changes for 4.4 that added
lpuart32_transmit_buffer() as an inline function.

Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web