Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1256113 > unrolled thread

[PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings

Started byYaniv Gardi <ygardi@codeaurora.org>
First post2015-10-26 16:50 +0100
Last post2015-10-27 20:00 +0100
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings Yaniv Gardi <ygardi@codeaurora.org> - 2015-10-26 16:50 +0100
    Re: [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings Stephen Boyd <sboyd@codeaurora.org> - 2015-10-26 23:00 +0100
      Re: [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings ygardi@codeaurora.org - 2015-10-27 11:20 +0100
        Re: [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings Stephen Boyd <sboyd@codeaurora.org> - 2015-10-27 18:30 +0100
          Re: [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings ygardi@codeaurora.org - 2015-10-27 19:30 +0100
            Re: [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings Stephen Boyd <sboyd@codeaurora.org> - 2015-10-27 20:00 +0100

#1256113 — [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings

FromYaniv Gardi <ygardi@codeaurora.org>
Date2015-10-26 16:50 +0100
Subject[PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings
Message-ID<qnSc1-1Ad-3@gated-at.bofh.it>
Tnis patch fixes the following compilation warnings:
...ufs-qcom.c:1201:40:
	warning: incorrect type in argument 1 (different address spaces)
...ufs-qcom.c:1201:40:
	expected void const *ptr
...ufs-qcom.c:1201:40:
	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
...ufs-qcom.c:1207:53:
	warning: incorrect type in argument 1 (different address spaces)
...ufs-qcom.c:1207:53:
	expected void const *ptr
...ufs-qcom.c:1207:53:
	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio

Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>

---
 drivers/scsi/ufs/ufs-qcom.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
index 72b0ef7..b57f88a 100644
--- a/drivers/scsi/ufs/ufs-qcom.c
+++ b/drivers/scsi/ufs/ufs-qcom.c
@@ -1226,11 +1226,12 @@ static int ufs_qcom_init(struct ufs_hba *hba)
 		if (res) {
 			host->dev_ref_clk_ctrl_mmio =
 					devm_ioremap_resource(dev, res);
-			if (IS_ERR(host->dev_ref_clk_ctrl_mmio)) {
-				dev_warn(dev,
-					"%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n",
+			if (IS_ERR((__force void const *)
+				   host->dev_ref_clk_ctrl_mmio)) {
+				dev_warn(dev, "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n",
 					__func__,
-					PTR_ERR(host->dev_ref_clk_ctrl_mmio));
+					PTR_ERR((__force void const *)
+						 host->dev_ref_clk_ctrl_mmio));
 				host->dev_ref_clk_ctrl_mmio = NULL;
 			}
 			host->dev_ref_clk_en_mask = BIT(5);
-- 
1.8.5.2

-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1256312

FromStephen Boyd <sboyd@codeaurora.org>
Date2015-10-26 23:00 +0100
Message-ID<qnXY7-55x-19@gated-at.bofh.it>
In reply to#1256113
On 10/26/2015 08:41 AM, Yaniv Gardi wrote:
> Tnis patch fixes the following compilation warnings:
> ...ufs-qcom.c:1201:40:
> 	warning: incorrect type in argument 1 (different address spaces)
> ...ufs-qcom.c:1201:40:
> 	expected void const *ptr
> ...ufs-qcom.c:1201:40:
> 	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
> ...ufs-qcom.c:1207:53:
> 	warning: incorrect type in argument 1 (different address spaces)
> ...ufs-qcom.c:1207:53:
> 	expected void const *ptr
> ...ufs-qcom.c:1207:53:
> 	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>
> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
>
> ---

What version of sparse do you use? You shouldn't need to do this.

>  drivers/scsi/ufs/ufs-qcom.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index 72b0ef7..b57f88a 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -1226,11 +1226,12 @@ static int ufs_qcom_init(struct ufs_hba *hba)
>  		if (res) {
>  			host->dev_ref_clk_ctrl_mmio =
>  					devm_ioremap_resource(dev, res);
> -			if (IS_ERR(host->dev_ref_clk_ctrl_mmio)) {
> -				dev_warn(dev,
> -					"%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n",
> +			if (IS_ERR((__force void const *)
> +				   host->dev_ref_clk_ctrl_mmio)) {
> +				dev_warn(dev, "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n",
>  					__func__,
> -					PTR_ERR(host->dev_ref_clk_ctrl_mmio));
> +					PTR_ERR((__force void const *)
> +						 host->dev_ref_clk_ctrl_mmio));
>  				host->dev_ref_clk_ctrl_mmio = NULL;
>  			}
>  			host->dev_ref_clk_en_mask = BIT(5);


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1256650

Fromygardi@codeaurora.org
Date2015-10-27 11:20 +0100
Message-ID<qo9wd-3Yv-11@gated-at.bofh.it>
In reply to#1256312
> On 10/26/2015 08:41 AM, Yaniv Gardi wrote:
>> Tnis patch fixes the following compilation warnings:
>> ...ufs-qcom.c:1201:40:
>> 	warning: incorrect type in argument 1 (different address spaces)
>> ...ufs-qcom.c:1201:40:
>> 	expected void const *ptr
>> ...ufs-qcom.c:1201:40:
>> 	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>> ...ufs-qcom.c:1207:53:
>> 	warning: incorrect type in argument 1 (different address spaces)
>> ...ufs-qcom.c:1207:53:
>> 	expected void const *ptr
>> ...ufs-qcom.c:1207:53:
>> 	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>>
>> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
>>
>> ---
>
> What version of sparse do you use? You shouldn't need to do this.
>

i just updated my sparse to the newest -
so i'm using sparse 0.4.4
and the command i use is:
make ARCH=arm C=1  CF="-Wsparse-all"
and i still get all the warnings.
with my patch, the are no warnings.


>>  drivers/scsi/ufs/ufs-qcom.c | 9 +++++----
>>  1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
>> index 72b0ef7..b57f88a 100644
>> --- a/drivers/scsi/ufs/ufs-qcom.c
>> +++ b/drivers/scsi/ufs/ufs-qcom.c
>> @@ -1226,11 +1226,12 @@ static int ufs_qcom_init(struct ufs_hba *hba)
>>  		if (res) {
>>  			host->dev_ref_clk_ctrl_mmio =
>>  					devm_ioremap_resource(dev, res);
>> -			if (IS_ERR(host->dev_ref_clk_ctrl_mmio)) {
>> -				dev_warn(dev,
>> -					"%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n",
>> +			if (IS_ERR((__force void const *)
>> +				   host->dev_ref_clk_ctrl_mmio)) {
>> +				dev_warn(dev, "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n",
>>  					__func__,
>> -					PTR_ERR(host->dev_ref_clk_ctrl_mmio));
>> +					PTR_ERR((__force void const *)
>> +						 host->dev_ref_clk_ctrl_mmio));
>>  				host->dev_ref_clk_ctrl_mmio = NULL;
>>  			}
>>  			host->dev_ref_clk_en_mask = BIT(5);
>
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1256988

FromStephen Boyd <sboyd@codeaurora.org>
Date2015-10-27 18:30 +0100
Message-ID<qogem-80v-13@gated-at.bofh.it>
In reply to#1256650
On 10/27/2015 03:10 AM, ygardi@codeaurora.org wrote:
>> On 10/26/2015 08:41 AM, Yaniv Gardi wrote:
>>> Tnis patch fixes the following compilation warnings:
>>> ...ufs-qcom.c:1201:40:
>>> 	warning: incorrect type in argument 1 (different address spaces)
>>> ...ufs-qcom.c:1201:40:
>>> 	expected void const *ptr
>>> ...ufs-qcom.c:1201:40:
>>> 	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>>> ...ufs-qcom.c:1207:53:
>>> 	warning: incorrect type in argument 1 (different address spaces)
>>> ...ufs-qcom.c:1207:53:
>>> 	expected void const *ptr
>>> ...ufs-qcom.c:1207:53:
>>> 	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>>>
>>> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
>>>
>>> ---
>> What version of sparse do you use? You shouldn't need to do this.
>>
> i just updated my sparse to the newest -
> so i'm using sparse 0.4.4
> and the command i use is:
> make ARCH=arm C=1  CF="-Wsparse-all"
> and i still get all the warnings.
> with my patch, the are no warnings.
>

That is not the latest version of sparse. I'm not sure when sparse was
updated, but I have the git version which shows v0.5.0-51-ga53cea28f0db

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257116

Fromygardi@codeaurora.org
Date2015-10-27 19:30 +0100
Message-ID<qohap-8R-9@gated-at.bofh.it>
In reply to#1256988
> On 10/27/2015 03:10 AM, ygardi@codeaurora.org wrote:
>>> On 10/26/2015 08:41 AM, Yaniv Gardi wrote:
>>>> Tnis patch fixes the following compilation warnings:
>>>> ...ufs-qcom.c:1201:40:
>>>> 	warning: incorrect type in argument 1 (different address spaces)
>>>> ...ufs-qcom.c:1201:40:
>>>> 	expected void const *ptr
>>>> ...ufs-qcom.c:1201:40:
>>>> 	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>>>> ...ufs-qcom.c:1207:53:
>>>> 	warning: incorrect type in argument 1 (different address spaces)
>>>> ...ufs-qcom.c:1207:53:
>>>> 	expected void const *ptr
>>>> ...ufs-qcom.c:1207:53:
>>>> 	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>>>>
>>>> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
>>>>
>>>> ---
>>> What version of sparse do you use? You shouldn't need to do this.
>>>
>> i just updated my sparse to the newest -
>> so i'm using sparse 0.4.4
>> and the command i use is:
>> make ARCH=arm C=1  CF="-Wsparse-all"
>> and i still get all the warnings.
>> with my patch, the are no warnings.
>>
>
> That is not the latest version of sparse. I'm not sure when sparse was
> updated, but I have the git version which shows v0.5.0-51-ga53cea28f0db
>

Stephen, is this something you insist on?
i think the patch can stay as it is.
please let me know, as i wouldn't like this issue to block the entire patch

Yaniv

> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257130

FromStephen Boyd <sboyd@codeaurora.org>
Date2015-10-27 20:00 +0100
Message-ID<qohDs-j5-17@gated-at.bofh.it>
In reply to#1257116
On 10/27/2015 11:22 AM, ygardi@codeaurora.org wrote:
>> On 10/27/2015 03:10 AM, ygardi@codeaurora.org wrote:
>>>> On 10/26/2015 08:41 AM, Yaniv Gardi wrote:
>>>>> Tnis patch fixes the following compilation warnings:
>>>>> ...ufs-qcom.c:1201:40:
>>>>> 	warning: incorrect type in argument 1 (different address spaces)
>>>>> ...ufs-qcom.c:1201:40:
>>>>> 	expected void const *ptr
>>>>> ...ufs-qcom.c:1201:40:
>>>>> 	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>>>>> ...ufs-qcom.c:1207:53:
>>>>> 	warning: incorrect type in argument 1 (different address spaces)
>>>>> ...ufs-qcom.c:1207:53:
>>>>> 	expected void const *ptr
>>>>> ...ufs-qcom.c:1207:53:
>>>>> 	got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>>>>>
>>>>> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
>>>>>
>>>>> ---
>>>> What version of sparse do you use? You shouldn't need to do this.
>>>>
>>> i just updated my sparse to the newest -
>>> so i'm using sparse 0.4.4
>>> and the command i use is:
>>> make ARCH=arm C=1  CF="-Wsparse-all"
>>> and i still get all the warnings.
>>> with my patch, the are no warnings.
>>>
>> That is not the latest version of sparse. I'm not sure when sparse was
>> updated, but I have the git version which shows v0.5.0-51-ga53cea28f0db
>>
> Stephen, is this something you insist on?
> i think the patch can stay as it is.
> please let me know, as i wouldn't like this issue to block the entire patch
>

Yes. Adding __force is wrong. Just drop this patch.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web