Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1254081 > unrolled thread
| Started by | Punit Vara <punitvara@gmail.com> |
|---|---|
| First post | 2015-10-22 20:50 +0200 |
| Last post | 2015-10-27 20:20 +0100 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 Punit Vara <punitvara@gmail.com> - 2015-10-22 20:50 +0200
Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-10-22 21:00 +0200
Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 punit vara <punitvara@gmail.com> - 2015-10-26 21:10 +0100
Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 Kalle Valo <kvalo@codeaurora.org> - 2015-10-27 09:20 +0100
Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 punit vara <punitvara@gmail.com> - 2015-10-27 20:20 +0100
| From | Punit Vara <punitvara@gmail.com> |
|---|---|
| Date | 2015-10-22 20:50 +0200 |
| Subject | [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 |
| Message-ID | <qmt61-2wa-17@gated-at.bofh.it> |
Remove black line suggested by Sergei
This patch is to the ath5k/eeprom.c that fixes up warning caught by
coccicheck:
Unneeded variable: "ret". Return "0" on line 980
Remove unneeded variable ret created to return zero.
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/net/wireless/ath/wcn36xx/main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index 900e72a..94bcc08 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -935,8 +935,6 @@ static const struct ieee80211_ops wcn36xx_ops = {
static int wcn36xx_init_ieee80211(struct wcn36xx *wcn)
{
- int ret = 0;
-
static const u32 cipher_suites[] = {
WLAN_CIPHER_SUITE_WEP40,
WLAN_CIPHER_SUITE_WEP104,
@@ -977,7 +975,7 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn)
wcn->hw->sta_data_size = sizeof(struct wcn36xx_sta);
wcn->hw->vif_data_size = sizeof(struct wcn36xx_vif);
- return ret;
+ return 0;
}
static int wcn36xx_platform_get_resources(struct wcn36xx *wcn,
--
2.5.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2015-10-22 21:00 +0200 |
| Subject | Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 |
| Message-ID | <qmtfJ-2HW-47@gated-at.bofh.it> |
| In reply to | #1254081 |
On 10/22/2015 09:47 PM, Punit Vara wrote:
> Remove black line suggested by Sergei
Such kind of comments should be under the --- tear line.
>
> This patch is to the ath5k/eeprom.c that fixes up warning caught by
> coccicheck:
>
> Unneeded variable: "ret". Return "0" on line 980
>
> Remove unneeded variable ret created to return zero.
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
[...]
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | punit vara <punitvara@gmail.com> |
|---|---|
| Date | 2015-10-26 21:10 +0100 |
| Subject | Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 |
| Message-ID | <qnWfE-4d6-7@gated-at.bofh.it> |
| In reply to | #1254114 |
On Fri, Oct 23, 2015 at 12:26 AM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 10/22/2015 09:47 PM, Punit Vara wrote: > >> Remove black line suggested by Sergei > > > Such kind of comments should be under the --- tear line. > >> >> This patch is to the ath5k/eeprom.c that fixes up warning caught by >> coccicheck: >> >> Unneeded variable: "ret". Return "0" on line 980 >> >> Remove unneeded variable ret created to return zero. >> >> Signed-off-by: Punit Vara <punitvara@gmail.com> > > [...] > > MBR, Sergei > Thanks you Sergei for review. Actually I didnt know You have replied to this mail because this was gone in some other folder of my mail box .. I will send this patch again as you suggested . Will my other patches which are already correct be added to wireless tree ? or I have to resend everything ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Kalle Valo <kvalo@codeaurora.org> |
|---|---|
| Date | 2015-10-27 09:20 +0100 |
| Message-ID | <qo7E7-2QQ-19@gated-at.bofh.it> |
| In reply to | #1256235 |
punit vara <punitvara@gmail.com> writes: > Will my other patches which are already correct be added to wireless > tree ? or I have to resend everything ? Yes, please resend the whole patchset. I don't apply patches individually from a patchset, it's just too time consuming and error prone. Also, as you seem to be new here, I don't recommend sending big patchsets in the beginning. Start slow, send just few a patch or two at a time, and once you gain more experience send bigger patchsets. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | punit vara <punitvara@gmail.com> |
|---|---|
| Date | 2015-10-27 20:20 +0100 |
| Subject | Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 |
| Message-ID | <qohWN-F5-13@gated-at.bofh.it> |
| In reply to | #1256554 |
On Tue, Oct 27, 2015 at 1:42 PM, Kalle Valo <kvalo@codeaurora.org> wrote: > punit vara <punitvara@gmail.com> writes: > >> Will my other patches which are already correct be added to wireless >> tree ? or I have to resend everything ? > > Yes, please resend the whole patchset. I don't apply patches > individually from a patchset, it's just too time consuming and error > prone. > > Also, as you seem to be new here, I don't recommend sending big > patchsets in the beginning. Start slow, send just few a patch or two at > a time, and once you gain more experience send bigger patchsets. > > -- > Kalle Valo Next time I will send 2-3 patches only . This time I have resent you all the patches that I have created before . Thank you for suggestion. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web