Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257050 > unrolled thread

[PATCH 00/15] drivers/tty/: Deinline smaller/less used functions

Started byDenys Vlasenko <dvlasenk@redhat.com>
First post2015-10-27 18:50 +0100
Last post2015-10-27 19:20 +0100
Articles 7 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/15] drivers/tty/: Deinline smaller/less used functions Denys Vlasenko <dvlasenk@redhat.com> - 2015-10-27 18:50 +0100
    [PATCH 01/15] cyclades: Deinline cyz_is_loaded, save 240 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2015-10-27 18:50 +0100
      Re: [PATCH 01/15] cyclades: Deinline cyz_is_loaded, save 240 bytes Peter Hurley <peter@hurleysoftware.com> - 2015-10-27 19:20 +0100
    [PATCH 02/15] isicom: Deinline drop_dtr, save 112 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2015-10-27 18:50 +0100
      Re: [PATCH 02/15] isicom: Deinline drop_dtr, save 112 bytes Peter Hurley <peter@hurleysoftware.com> - 2015-10-27 19:20 +0100
    [PATCH 08/15] serial/omap-serial: Deinline wait_for_xmitr, save 165 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2015-10-27 18:50 +0100
    Re: [PATCH 00/15] drivers/tty/: Deinline smaller/less used functions Peter Hurley <peter@hurleysoftware.com> - 2015-10-27 19:20 +0100

#1257050 — [PATCH 00/15] drivers/tty/: Deinline smaller/less used functions

FromDenys Vlasenko <dvlasenk@redhat.com>
Date2015-10-27 18:50 +0100
Subject[PATCH 00/15] drivers/tty/: Deinline smaller/less used functions
Message-ID<qogxH-87V-15@gated-at.bofh.it>
For Peter's review.
(Pater, I removed a few patches which looked most problematic)

Denys Vlasenko (15):
  cyclades: Deinline cyz_is_loaded, save 240 bytes
  isicom: Deinline drop_dtr, save 112 bytes
  tty: Deinline n_tty_receive_char_inline, save 224 bytes
  serial/fsl_lpuart: Deinline lpuart_transmit_buffer, save 176 bytes
  serial/m32r_sio: Deinline wait_for_xmitr, save 165 bytes
  serial/men_z135_uart: Deinline men_z135_reg_clr, save 176 bytes
  serial/msm_serial: Deinline wait_for_xmitr, save 165 bytes
  serial/omap-serial: Deinline wait_for_xmitr, save 165 bytes
  serial/pxa: Deinline wait_for_xmitr, save 165 bytes
  serial/sprd_serial: Deinline wait_for_xmitr, save 165 bytes
  serial/sunsu: Deinline wait_for_xmitr, save 165 bytes
  serial/vt8500_serial: Deinline wait_for_xmitr, save 165 bytes
  tty: Deinline __ldsem_down_read_nested, save 128 bytes
  tty: Deinline __ldsem_down_write_nested, save 128 bytes
  vt: Deinline save_screen, save 238 bytes

 drivers/tty/cyclades.c             | 2 +-
 drivers/tty/isicom.c               | 2 +-
 drivers/tty/n_tty.c                | 2 +-
 drivers/tty/serial/fsl_lpuart.c    | 2 +-
 drivers/tty/serial/m32r_sio.c      | 2 +-
 drivers/tty/serial/men_z135_uart.c | 2 +-
 drivers/tty/serial/msm_serial.c    | 2 +-
 drivers/tty/serial/omap-serial.c   | 2 +-
 drivers/tty/serial/pxa.c           | 2 +-
 drivers/tty/serial/sprd_serial.c   | 2 +-
 drivers/tty/serial/sunsu.c         | 2 +-
 drivers/tty/serial/vt8500_serial.c | 2 +-
 drivers/tty/tty_ldsem.c            | 4 ++--
 drivers/tty/vt/vt.c                | 2 +-
 14 files changed, 15 insertions(+), 15 deletions(-)

-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1257053 — [PATCH 01/15] cyclades: Deinline cyz_is_loaded, save 240 bytes

FromDenys Vlasenko <dvlasenk@redhat.com>
Date2015-10-27 18:50 +0100
Subject[PATCH 01/15] cyclades: Deinline cyz_is_loaded, save 240 bytes
Message-ID<qogxJ-87V-47@gated-at.bofh.it>
In reply to#1257050
This function compiles to 58 bytes of machine code.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Peter Hurley <peter@hurleysoftware.com>
CC: Jiri Slaby <jslaby@suse.com>
CC: linux-serial@vger.kernel.org
---
 drivers/tty/cyclades.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/cyclades.c b/drivers/tty/cyclades.c
index 87f6578..1492938 100644
--- a/drivers/tty/cyclades.c
+++ b/drivers/tty/cyclades.c
@@ -321,7 +321,7 @@ static inline bool cyz_fpga_loaded(struct cyclades_card *card)
 	return __cyz_fpga_loaded(card->ctl_addr.p9060);
 }
 
-static inline bool cyz_is_loaded(struct cyclades_card *card)
+static bool cyz_is_loaded(struct cyclades_card *card)
 {
 	struct FIRM_ID __iomem *fw_id = card->base_addr + ID_ADDRESS;
 
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257110 — Re: [PATCH 01/15] cyclades: Deinline cyz_is_loaded, save 240 bytes

FromPeter Hurley <peter@hurleysoftware.com>
Date2015-10-27 19:20 +0100
SubjectRe: [PATCH 01/15] cyclades: Deinline cyz_is_loaded, save 240 bytes
Message-ID<qoh0K-5E-17@gated-at.bofh.it>
In reply to#1257053
On 10/27/2015 01:46 PM, Denys Vlasenko wrote:
> This function compiles to 58 bytes of machine code.

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257055 — [PATCH 02/15] isicom: Deinline drop_dtr, save 112 bytes

FromDenys Vlasenko <dvlasenk@redhat.com>
Date2015-10-27 18:50 +0100
Subject[PATCH 02/15] isicom: Deinline drop_dtr, save 112 bytes
Message-ID<qogxI-87V-43@gated-at.bofh.it>
In reply to#1257050
This function compiles to 181 bytes of machine code.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Peter Hurley <peter@hurleysoftware.com>
CC: Jiri Slaby <jslaby@suse.com>
CC: linux-serial@vger.kernel.org
---
 drivers/tty/isicom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/isicom.c b/drivers/tty/isicom.c
index 2054427..029fd0d 100644
--- a/drivers/tty/isicom.c
+++ b/drivers/tty/isicom.c
@@ -280,7 +280,7 @@ static void raise_dtr(struct isi_port *port)
 }
 
 /* card->lock HAS to be held */
-static inline void drop_dtr(struct isi_port *port)
+static void drop_dtr(struct isi_port *port)
 {
 	struct isi_board *card = port->card;
 	unsigned long base = card->base;
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257111 — Re: [PATCH 02/15] isicom: Deinline drop_dtr, save 112 bytes

FromPeter Hurley <peter@hurleysoftware.com>
Date2015-10-27 19:20 +0100
SubjectRe: [PATCH 02/15] isicom: Deinline drop_dtr, save 112 bytes
Message-ID<qoh0K-5E-19@gated-at.bofh.it>
In reply to#1257055
On 10/27/2015 01:46 PM, Denys Vlasenko wrote:
> This function compiles to 181 bytes of machine code.

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257061 — [PATCH 08/15] serial/omap-serial: Deinline wait_for_xmitr, save 165 bytes

FromDenys Vlasenko <dvlasenk@redhat.com>
Date2015-10-27 18:50 +0100
Subject[PATCH 08/15] serial/omap-serial: Deinline wait_for_xmitr, save 165 bytes
Message-ID<qogxJ-87V-57@gated-at.bofh.it>
In reply to#1257050
This function compiles to 141 bytes of machine code.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Peter Hurley <peter@hurleysoftware.com>
CC: Jiri Slaby <jslaby@suse.com>
CC: linux-serial@vger.kernel.org
---
 drivers/tty/serial/omap-serial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 7a2172b..d404698 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -1163,7 +1163,7 @@ serial_omap_type(struct uart_port *port)
 
 #define BOTH_EMPTY (UART_LSR_TEMT | UART_LSR_THRE)
 
-static inline void wait_for_xmitr(struct uart_omap_port *up)
+static void wait_for_xmitr(struct uart_omap_port *up)
 {
 	unsigned int status, tmout = 10000;
 
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257109

FromPeter Hurley <peter@hurleysoftware.com>
Date2015-10-27 19:20 +0100
Message-ID<qoh0K-5E-15@gated-at.bofh.it>
In reply to#1257050
Hi Denys,

On 10/27/2015 01:46 PM, Denys Vlasenko wrote:
> For Peter's review.
> (Pater, I removed a few patches which looked most problematic)

I'd take 'Deinline finish_erasing, save 112 bytes' as well.

Regards,
Peter Hurley

> Denys Vlasenko (15):
>   cyclades: Deinline cyz_is_loaded, save 240 bytes
>   isicom: Deinline drop_dtr, save 112 bytes
>   tty: Deinline n_tty_receive_char_inline, save 224 bytes
>   serial/fsl_lpuart: Deinline lpuart_transmit_buffer, save 176 bytes
>   serial/m32r_sio: Deinline wait_for_xmitr, save 165 bytes
>   serial/men_z135_uart: Deinline men_z135_reg_clr, save 176 bytes
>   serial/msm_serial: Deinline wait_for_xmitr, save 165 bytes
>   serial/omap-serial: Deinline wait_for_xmitr, save 165 bytes
>   serial/pxa: Deinline wait_for_xmitr, save 165 bytes
>   serial/sprd_serial: Deinline wait_for_xmitr, save 165 bytes
>   serial/sunsu: Deinline wait_for_xmitr, save 165 bytes
>   serial/vt8500_serial: Deinline wait_for_xmitr, save 165 bytes
>   tty: Deinline __ldsem_down_read_nested, save 128 bytes
>   tty: Deinline __ldsem_down_write_nested, save 128 bytes
>   vt: Deinline save_screen, save 238 bytes
> 
>  drivers/tty/cyclades.c             | 2 +-
>  drivers/tty/isicom.c               | 2 +-
>  drivers/tty/n_tty.c                | 2 +-
>  drivers/tty/serial/fsl_lpuart.c    | 2 +-
>  drivers/tty/serial/m32r_sio.c      | 2 +-
>  drivers/tty/serial/men_z135_uart.c | 2 +-
>  drivers/tty/serial/msm_serial.c    | 2 +-
>  drivers/tty/serial/omap-serial.c   | 2 +-
>  drivers/tty/serial/pxa.c           | 2 +-
>  drivers/tty/serial/sprd_serial.c   | 2 +-
>  drivers/tty/serial/sunsu.c         | 2 +-
>  drivers/tty/serial/vt8500_serial.c | 2 +-
>  drivers/tty/tty_ldsem.c            | 4 ++--
>  drivers/tty/vt/vt.c                | 2 +-
>  14 files changed, 15 insertions(+), 15 deletions(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web