Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257049 > unrolled thread

[PATCH 06/15] serial/men_z135_uart: Deinline men_z135_reg_clr, save 176 bytes

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 06/15] serial/men_z135_uart: Deinline men_z135_reg_clr, save 176 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2015-10-27 18:50 +0100
    Re: [PATCH 06/15] serial/men_z135_uart: Deinline men_z135_reg_clr,  save 176 bytes Peter Hurley <peter@hurleysoftware.com> - 2015-10-27 20:00 +0100

#1257049 — [PATCH 06/15] serial/men_z135_uart: Deinline men_z135_reg_clr, save 176 bytes

This function compiles to 98 bytes of machine code.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Peter Hurley <peter@hurleysoftware.com>
CC: Jiri Slaby <jslaby@suse.com>
CC: linux-serial@vger.kernel.org
---
 drivers/tty/serial/men_z135_uart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c
index b90e7b3..2b5b66f 100644
--- a/drivers/tty/serial/men_z135_uart.c
+++ b/drivers/tty/serial/men_z135_uart.c
@@ -159,7 +159,7 @@ static inline void men_z135_reg_set(struct men_z135_port *uart,
  * @addr: Register address
  * @val: value to clear
  */
-static inline void men_z135_reg_clr(struct men_z135_port *uart,
+static void men_z135_reg_clr(struct men_z135_port *uart,
 				u32 addr, u32 val)
 {
 	struct uart_port *port = &uart->port;
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1257132 — Re: [PATCH 06/15] serial/men_z135_uart: Deinline men_z135_reg_clr, save 176 bytes

On 10/27/2015 01:46 PM, Denys Vlasenko wrote:
> This function compiles to 98 bytes of machine code.

This looks ok because these function are heavyweight.

You'll want to add men_z135_reg_set() to this patch
as well, and please cc the driver author:

	Johannes Thumshirn <johannes.thumshirn@men.de>

Regards,
Peter Hurley


> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Peter Hurley <peter@hurleysoftware.com>
> CC: Jiri Slaby <jslaby@suse.com>
> CC: linux-serial@vger.kernel.org
> ---
>  drivers/tty/serial/men_z135_uart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c
> index b90e7b3..2b5b66f 100644
> --- a/drivers/tty/serial/men_z135_uart.c
> +++ b/drivers/tty/serial/men_z135_uart.c
> @@ -159,7 +159,7 @@ static inline void men_z135_reg_set(struct men_z135_port *uart,
>   * @addr: Register address
>   * @val: value to clear
>   */
> -static inline void men_z135_reg_clr(struct men_z135_port *uart,
> +static void men_z135_reg_clr(struct men_z135_port *uart,
>  				u32 addr, u32 val)
>  {
>  	struct uart_port *port = &uart->port;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web