Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1257040 > unrolled thread

[PATCH 03/15] tty: Deinline n_tty_receive_char_inline, save 224 bytes

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 03/15] tty: Deinline n_tty_receive_char_inline, save 224 bytes Denys Vlasenko <dvlasenk@redhat.com> - 2015-10-27 18:50 +0100
    Re: [PATCH 03/15] tty: Deinline n_tty_receive_char_inline, save 224  bytes Peter Hurley <peter@hurleysoftware.com> - 2015-10-27 19:10 +0100

#1257040 — [PATCH 03/15] tty: Deinline n_tty_receive_char_inline, save 224 bytes

This function compiles to 198 bytes of machine code.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Peter Hurley <peter@hurleysoftware.com>
CC: Jiri Slaby <jslaby@suse.com>
CC: linux-serial@vger.kernel.org
---
 drivers/tty/n_tty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index b09023b..c38f5d8 100644
--- a/drivers/tty/n_tty.c
+++ b/drivers/tty/n_tty.c
@@ -1407,7 +1407,7 @@ handle_newline:
 	return 0;
 }
 
-static inline void
+static void
 n_tty_receive_char_inline(struct tty_struct *tty, unsigned char c)
 {
 	struct n_tty_data *ldata = tty->disc_data;
-- 
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1257098 — Re: [PATCH 03/15] tty: Deinline n_tty_receive_char_inline, save 224 bytes

On 10/27/2015 01:46 PM, Denys Vlasenko wrote:
> This function compiles to 198 bytes of machine code.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Peter Hurley <peter@hurleysoftware.com>
> CC: Jiri Slaby <jslaby@suse.com>
> CC: linux-serial@vger.kernel.org
> ---
>  drivers/tty/n_tty.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
> index b09023b..c38f5d8 100644
> --- a/drivers/tty/n_tty.c
> +++ b/drivers/tty/n_tty.c
> @@ -1407,7 +1407,7 @@ handle_newline:
>  	return 0;
>  }
>  
> -static inline void
> +static void
>  n_tty_receive_char_inline(struct tty_struct *tty, unsigned char c)
>  {
>  	struct n_tty_data *ldata = tty->disc_data;
> 

This is one of the patches I will rework differently to remove the
inlining (n_tty_receive_char_inline() can be deleted and its call
sites replaced with n_tty_receive_char()).

Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web