Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1256817 > unrolled thread

[PATCH 00/11] parport cleanup

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/11] parport cleanup Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-27 15:50 +0100
    [PATCH 06/11] parport: quoted strings should not be split Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-27 15:50 +0100
    Re: [PATCH 00/11] parport cleanup Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-28 09:40 +0100

#1256817 — [PATCH 00/11] parport cleanup

Hi Greg,
A small series of checkpatch cleanup on parport. This is the first set.
Its only cleanup and no other change is done. All the patches are also
sent along with this pull request for your convenience.


The following changes since commit 32b88194f71d6ae7768a29f87fbba454728273ee:

  Linux 4.3-rc7 (2015-10-25 10:39:47 +0900)

are available in the git repository at:

  https://github.com/sudipm-mukherjee/parport.git tags/parport_cleanup1

for you to fetch changes up to 6bc7ecef3a3b377a4fde1150b874d5bffbbc7790:

  parport: avoid assignment in if (2015-10-27 18:12:06 +0530)

----------------------------------------------------------------
Geliang Tang (1):
  parport: fix a trivial typo

Sudip Mukherjee (10):
  parport: remove trailing white space
  parport: EXPORT_SYMBOL should follow function
  parport: fix coding style
  parport: code indent should use tabs
  parport: quoted strings should not be split
  parport: remove braces
  parport: remove unnecessary out of memory message
  parport: change style of NULL comparison
  parport: remove unneeded space
  parport: avoid assignment in if

 drivers/parport/share.c | 246 +++++++++++++++++++++++++-----------------------
 1 file changed, 126 insertions(+), 120 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1256818 — [PATCH 06/11] parport: quoted strings should not be split

From: Sudip Mukherjee <sudip@vectorindia.org>

user visible strings should not be split as that affects the ability to
grep.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/parport/share.c | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/drivers/parport/share.c b/drivers/parport/share.c
index 388c138..dcad902 100644
--- a/drivers/parport/share.c
+++ b/drivers/parport/share.c
@@ -537,9 +537,8 @@ void parport_announce_port (struct parport *port)
 #endif
 
 	if (!port->dev)
-		printk(KERN_WARNING "%s: fix this legacy "
-				"no-device port driver!\n",
-				port->name);
+		printk(KERN_WARNING "%s: fix this legacy no-device port driver!\n",
+		       port->name);
 
 	parport_proc_register(port);
 	mutex_lock(&registration_lock);
@@ -778,8 +777,8 @@ parport_register_device(struct parport *port, const char *name,
 		if (port->physport->devices) {
 			spin_unlock (&port->physport->pardevice_lock);
 			printk (KERN_DEBUG
-				"%s: cannot grant exclusive access for "
-				"device %s\n", port->name, name);
+				"%s: cannot grant exclusive access for device %s\n",
+				port->name, name);
 			goto out_free_all;
 		}
 		port->flags |= PARPORT_FLAG_EXCL;
@@ -1276,9 +1275,8 @@ int parport_claim_or_block(struct pardevice *dev)
 
 #ifdef PARPORT_DEBUG_SHARING
 		if (dev->port->physport->cad != dev)
-			printk(KERN_DEBUG "%s: exiting parport_claim_or_block "
-			       "but %s owns port!\n", dev->name,
-			       dev->port->physport->cad ?
+			printk(KERN_DEBUG "%s: exiting parport_claim_or_block but %s owns port!\n",
+			       dev->name, dev->port->physport->cad ?
 			       dev->port->physport->cad->name:"nobody");
 #endif
 	}
@@ -1306,8 +1304,8 @@ void parport_release(struct pardevice *dev)
 	write_lock_irqsave(&port->cad_lock, flags);
 	if (port->cad != dev) {
 		write_unlock_irqrestore (&port->cad_lock, flags);
-		printk(KERN_WARNING "%s: %s tried to release parport "
-		       "when not owner\n", port->name, dev->name);
+		printk(KERN_WARNING "%s: %s tried to release parport when not owner\n",
+		       port->name, dev->name);
 		return;
 	}
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257799

On Tue, Oct 27, 2015 at 08:12:26PM +0530, Sudip Mukherjee wrote:
> Hi Greg,
> A small series of checkpatch cleanup on parport. This is the first set.
> Its only cleanup and no other change is done. All the patches are also
> sent along with this pull request for your convenience.

An extra From: line was added in the patches due to a mess in my
.gitconfig file. Please discard this. I am sending v2.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web