Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1256536 > unrolled thread
| Started by | Saurabh Sengar <saurabh.truth@gmail.com> |
|---|---|
| First post | 2015-10-27 08:50 +0100 |
| Last post | 2015-10-28 14:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] tty: serial: sa1100.c: use UPIO_MEM rather than SERIAL_IO_MEM Saurabh Sengar <saurabh.truth@gmail.com> - 2015-10-27 08:50 +0100
Re: [PATCH] tty: serial: sa1100.c: use UPIO_MEM rather than SERIAL_IO_MEM Peter Hurley <peter@hurleysoftware.com> - 2015-10-28 14:50 +0100
| From | Saurabh Sengar <saurabh.truth@gmail.com> |
|---|---|
| Date | 2015-10-27 08:50 +0100 |
| Subject | [PATCH] tty: serial: sa1100.c: use UPIO_MEM rather than SERIAL_IO_MEM |
| Message-ID | <qo7b4-2rZ-3@gated-at.bofh.it> |
use UPIO_MEM rather then SERIAL_IO_MEM. both have the same value Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com> --- drivers/tty/serial/sa1100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/sa1100.c b/drivers/tty/serial/sa1100.c index fd3d132..283c7e0 100644 --- a/drivers/tty/serial/sa1100.c +++ b/drivers/tty/serial/sa1100.c @@ -579,7 +579,7 @@ sa1100_verify_port(struct uart_port *port, struct serial_struct *ser) ret = -EINVAL; if (sport->port.irq != ser->irq) ret = -EINVAL; - if (ser->io_type != SERIAL_IO_MEM) + if (ser->io_type != UPIO_MEM) ret = -EINVAL; if (sport->port.uartclk / 16 != ser->baud_base) ret = -EINVAL; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Peter Hurley <peter@hurleysoftware.com> |
|---|---|
| Date | 2015-10-28 14:50 +0100 |
| Subject | Re: [PATCH] tty: serial: sa1100.c: use UPIO_MEM rather than SERIAL_IO_MEM |
| Message-ID | <qozh0-3gf-35@gated-at.bofh.it> |
| In reply to | #1256536 |
Hi Saurabh, On 10/27/2015 03:46 AM, Saurabh Sengar wrote: > use UPIO_MEM rather then SERIAL_IO_MEM. > both have the same value > > Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com> > --- > drivers/tty/serial/sa1100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/sa1100.c b/drivers/tty/serial/sa1100.c > index fd3d132..283c7e0 100644 > --- a/drivers/tty/serial/sa1100.c > +++ b/drivers/tty/serial/sa1100.c > @@ -579,7 +579,7 @@ sa1100_verify_port(struct uart_port *port, struct serial_struct *ser) > ret = -EINVAL; > if (sport->port.irq != ser->irq) > ret = -EINVAL; > - if (ser->io_type != SERIAL_IO_MEM) > + if (ser->io_type != UPIO_MEM) SERIAL_IO_* io_type defines are the appropriate constants for the struct serial_struct::io_type field. Both are defined in the uapi header, include/uapi/linux/serial.h UPIO_* io_type defines are the appropriate constants for the struct uart_port::io_type field. Both are defined in the kernel header, include/kernel/serial_core.h I defined the UPIO_* io_types in terms of SERIAL_IO_* because userspace breakage was occurring as contributors were changing the UPIO_* constant values. Regards, Peter Hurley > ret = -EINVAL; > if (sport->port.uartclk / 16 != ser->baud_base) > ret = -EINVAL; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web