Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1256209 > unrolled thread
| Started by | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| First post | 2015-10-26 19:30 +0100 |
| Last post | 2015-10-27 09:40 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2015-10-26 19:30 +0100
Re: [PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings Bjorn Andersson <bjorn@kryo.se> - 2015-10-26 19:40 +0100
Re: [PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings Lee Jones <lee.jones@linaro.org> - 2015-10-27 09:40 +0100
| From | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| Date | 2015-10-26 19:30 +0100 |
| Subject | [PATCH] backlight: pm8941-wled: fix ptr_ret.cocci warnings |
| Message-ID | <qnUGS-3bZ-13@gated-at.bofh.it> |
drivers/video/backlight/pm8941-wled.c:404:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
CC: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
pm8941-wled.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/video/backlight/pm8941-wled.c
+++ b/drivers/video/backlight/pm8941-wled.c
@@ -401,10 +401,7 @@ static int pm8941_wled_probe(struct plat
bl = devm_backlight_device_register(&pdev->dev, wled->name,
&pdev->dev, wled,
&pm8941_wled_ops, &props);
- if (IS_ERR(bl))
- return PTR_ERR(bl);
-
- return 0;
+ return PTR_ERR_OR_ZERO(bl);
};
static const struct of_device_id pm8941_wled_match_table[] = {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Bjorn Andersson <bjorn@kryo.se> |
|---|---|
| Date | 2015-10-26 19:40 +0100 |
| Message-ID | <qnUQy-3fj-15@gated-at.bofh.it> |
| In reply to | #1256209 |
On Mon, Oct 26, 2015 at 11:26 AM, kbuild test robot <fengguang.wu@intel.com> wrote: > drivers/video/backlight/pm8941-wled.c:404:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > Cool, I didn't know that. Thanks Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-10-27 09:40 +0100 |
| Message-ID | <qo7Xs-2Xg-15@gated-at.bofh.it> |
| In reply to | #1256209 |
On Tue, 27 Oct 2015, kbuild test robot wrote:
> drivers/video/backlight/pm8941-wled.c:404:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> CC: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>
> pm8941-wled.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Applied, thanks.
> --- a/drivers/video/backlight/pm8941-wled.c
> +++ b/drivers/video/backlight/pm8941-wled.c
> @@ -401,10 +401,7 @@ static int pm8941_wled_probe(struct plat
> bl = devm_backlight_device_register(&pdev->dev, wled->name,
> &pdev->dev, wled,
> &pm8941_wled_ops, &props);
> - if (IS_ERR(bl))
> - return PTR_ERR(bl);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(bl);
> };
>
> static const struct of_device_id pm8941_wled_match_table[] = {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web