Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1255333 > unrolled thread

Re: Build regressions/improvements in v4.3-rc7

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: Build regressions/improvements in v4.3-rc7 Geert Uytterhoeven <geert@linux-m68k.org> - 2015-10-25 11:20 +0100
    Re: Build regressions/improvements in v4.3-rc7 Geert Uytterhoeven <geert@linux-m68k.org> - 2015-10-25 11:40 +0100
      Re: Build regressions/improvements in v4.3-rc7 Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-25 15:10 +0100
        Re: Build regressions/improvements in v4.3-rc7 Geert Uytterhoeven <geert@linux-m68k.org> - 2015-10-25 18:40 +0100
          Re: Build regressions/improvements in v4.3-rc7 Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-25 19:30 +0100
          Re: Build regressions/improvements in v4.3-rc7 Afzal Mohammed <afzal.mohd.ma@gmail.com> - 2015-10-25 20:10 +0100
            Re: Build regressions/improvements in v4.3-rc7 Rabin Vincent <rabin@rab.in> - 2015-10-25 23:10 +0100
      Re: Build regressions/improvements in v4.3-rc7 Rabin Vincent <rabin@rab.in> - 2015-10-25 23:40 +0100
        Re: Build regressions/improvements in v4.3-rc7 Geert Uytterhoeven <geert@linux-m68k.org> - 2015-10-26 09:00 +0100
    Re: Build regressions/improvements in v4.3-rc7 Geert Uytterhoeven <geert@linux-m68k.org> - 2015-10-25 18:40 +0100

#1255333 — Re: Build regressions/improvements in v4.3-rc7

On Sun, Oct 25, 2015 at 11:12 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> JFYI, when comparing v4.3-rc7[1] to v4.3-rc6[3], the summaries are:
>   - build errors: +12/-4

  + /home/kisskb/slave/src/arch/arm/kernel/devtree.c: error: implicit
declaration of function 'early_init_dt_scan_nodes'
[-Werror=implicit-function-declaration]:  => 244:2
  + /home/kisskb/slave/src/arch/arm/kernel/devtree.c: error: implicit
declaration of function 'early_init_dt_verify'
[-Werror=implicit-function-declaration]:  => 215:2
  + /home/kisskb/slave/src/arch/arm/kernel/devtree.c: error: implicit
declaration of function 'of_flat_dt_match_machine'
[-Werror=implicit-function-declaration]:  => 218:2
  + /home/kisskb/slave/src/arch/arm/kernel/devtree.c: error: implicit
declaration of function 'of_get_flat_dt_prop'
[-Werror=implicit-function-declaration]:  => 229:3
  + /home/kisskb/slave/src/arch/arm/kernel/devtree.c: error: implicit
declaration of function 'of_get_flat_dt_root'
[-Werror=implicit-function-declaration]:  => 228:3
  + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error:
'L_PTE_DIRTY' undeclared (first use in this function):  => 39:2
  + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error:
'L_PTE_MT_WRITEBACK' undeclared (first use in this function):  => 39:2
  + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error:
'L_PTE_PRESENT' undeclared (first use in this function):  => 39:2
  + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_XN'
undeclared (first use in this function):  => 39:2
  + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error:
'L_PTE_YOUNG' undeclared (first use in this function):  => 39:2

arm-randconfig (all seen and reported before)

> [1] http://kisskb.ellerman.id.au/kisskb/head/9511/ (256 out of 254 configs)
> [3] http://kisskb.ellerman.id.au/kisskb/head/9487/ (255 out of 254 configs)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1255344

On Sun, Oct 25, 2015 at 11:18 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Sun, Oct 25, 2015 at 11:12 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> JFYI, when comparing v4.3-rc7[1] to v4.3-rc6[3], the summaries are:
>>   - build errors: +12/-4

>   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_DIRTY' undeclared (first use in this function):  => 39:2
>   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_MT_WRITEBACK' undeclared (first use in this function):  => 39:2
>   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_PRESENT' undeclared (first use in this function):  => 39:2
>   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_XN' undeclared (first use in this function):  => 39:2
>   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_YOUNG' undeclared (first use in this function):  => 39:2

Caused by:

commit ab0615e2d6fb074764a3e4d05f1326fa2fdb4627
Author: Rabin Vincent <rabin@rab.in>
Date:   Thu Apr 24 23:28:57 2014 +0200

    arm: use fixmap for text patching when text is RO

Should the call to set_fixmap() in arch/arm/kernel/patch.c
just be protected by #ifdef CONFIG_MMU?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1255401

On Sun, Oct 25, 2015 at 11:39:15AM +0100, Geert Uytterhoeven wrote:
> On Sun, Oct 25, 2015 at 11:18 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > On Sun, Oct 25, 2015 at 11:12 AM, Geert Uytterhoeven
> > <geert@linux-m68k.org> wrote:
> >> JFYI, when comparing v4.3-rc7[1] to v4.3-rc6[3], the summaries are:
> >>   - build errors: +12/-4
> 
> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_DIRTY' undeclared (first use in this function):  => 39:2
> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_MT_WRITEBACK' undeclared (first use in this function):  => 39:2
> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_PRESENT' undeclared (first use in this function):  => 39:2
> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_XN' undeclared (first use in this function):  => 39:2
> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_YOUNG' undeclared (first use in this function):  => 39:2
> 
> Caused by:
> 
> commit ab0615e2d6fb074764a3e4d05f1326fa2fdb4627
> Author: Rabin Vincent <rabin@rab.in>
> Date:   Thu Apr 24 23:28:57 2014 +0200
> 
>     arm: use fixmap for text patching when text is RO
> 
> Should the call to set_fixmap() in arch/arm/kernel/patch.c
> just be protected by #ifdef CONFIG_MMU?

What this shows, time and time again, is that we need better testing for
!MMU platforms - we need !MMU platforms in the mainline kernel which
people actually have.

I have an OKI 67001 board (from Simtec), which is the older generation of
!MMU system, and I have code for it, but arm-soc won't let me put it in
the mainline kernel - even though it would give me a platform which I can
add to the boot farm to build and boot a test kernel for.

Consequently, I've little motivation to catch !MMU regressions before
they hit mainline.

Should we accept old !MMU code into mainline for platforms which kernel
developers have, in order to aid testing, even though it isn't modern
platforms and doesn't conform to the latest way of doing stuff.

Discuss.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1255515

On Sun, Oct 25, 2015 at 3:08 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Sun, Oct 25, 2015 at 11:39:15AM +0100, Geert Uytterhoeven wrote:
>> On Sun, Oct 25, 2015 at 11:18 AM, Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>> > On Sun, Oct 25, 2015 at 11:12 AM, Geert Uytterhoeven
>> > <geert@linux-m68k.org> wrote:
>> >> JFYI, when comparing v4.3-rc7[1] to v4.3-rc6[3], the summaries are:
>> >>   - build errors: +12/-4
>>
>> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_DIRTY' undeclared (first use in this function):  => 39:2
>> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_MT_WRITEBACK' undeclared (first use in this function):  => 39:2
>> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_PRESENT' undeclared (first use in this function):  => 39:2
>> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_XN' undeclared (first use in this function):  => 39:2
>> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_YOUNG' undeclared (first use in this function):  => 39:2
>>
>> Caused by:
>>
>> commit ab0615e2d6fb074764a3e4d05f1326fa2fdb4627
>> Author: Rabin Vincent <rabin@rab.in>
>> Date:   Thu Apr 24 23:28:57 2014 +0200
>>
>>     arm: use fixmap for text patching when text is RO
>>
>> Should the call to set_fixmap() in arch/arm/kernel/patch.c
>> just be protected by #ifdef CONFIG_MMU?
>
> What this shows, time and time again, is that we need better testing for
> !MMU platforms - we need !MMU platforms in the mainline kernel which
> people actually have.
>
> I have an OKI 67001 board (from Simtec), which is the older generation of
> !MMU system, and I have code for it, but arm-soc won't let me put it in
> the mainline kernel - even though it would give me a platform which I can
> add to the boot farm to build and boot a test kernel for.
>
> Consequently, I've little motivation to catch !MMU regressions before
> they hit mainline.
>
> Should we accept old !MMU code into mainline for platforms which kernel
> developers have, in order to aid testing, even though it isn't modern
> platforms and doesn't conform to the latest way of doing stuff.

I think we should have at least one arm-nommu platform in the upstream kernel,
with a suitable defconfig, so 0build will catch regressions.

Alternative, can any of the existing supported arm-mmu platform be used with
a nommu kernel?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1255521

On Sun, Oct 25, 2015 at 06:38:18PM +0100, Geert Uytterhoeven wrote:
> On Sun, Oct 25, 2015 at 3:08 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Sun, Oct 25, 2015 at 11:39:15AM +0100, Geert Uytterhoeven wrote:
> >> On Sun, Oct 25, 2015 at 11:18 AM, Geert Uytterhoeven
> >> <geert@linux-m68k.org> wrote:
> >> > On Sun, Oct 25, 2015 at 11:12 AM, Geert Uytterhoeven
> >> > <geert@linux-m68k.org> wrote:
> >> >> JFYI, when comparing v4.3-rc7[1] to v4.3-rc6[3], the summaries are:
> >> >>   - build errors: +12/-4
> >>
> >> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_DIRTY' undeclared (first use in this function):  => 39:2
> >> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_MT_WRITEBACK' undeclared (first use in this function):  => 39:2
> >> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_PRESENT' undeclared (first use in this function):  => 39:2
> >> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_XN' undeclared (first use in this function):  => 39:2
> >> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_YOUNG' undeclared (first use in this function):  => 39:2
> >>
> >> Caused by:
> >>
> >> commit ab0615e2d6fb074764a3e4d05f1326fa2fdb4627
> >> Author: Rabin Vincent <rabin@rab.in>
> >> Date:   Thu Apr 24 23:28:57 2014 +0200
> >>
> >>     arm: use fixmap for text patching when text is RO
> >>
> >> Should the call to set_fixmap() in arch/arm/kernel/patch.c
> >> just be protected by #ifdef CONFIG_MMU?
> >
> > What this shows, time and time again, is that we need better testing for
> > !MMU platforms - we need !MMU platforms in the mainline kernel which
> > people actually have.
> >
> > I have an OKI 67001 board (from Simtec), which is the older generation of
> > !MMU system, and I have code for it, but arm-soc won't let me put it in
> > the mainline kernel - even though it would give me a platform which I can
> > add to the boot farm to build and boot a test kernel for.
> >
> > Consequently, I've little motivation to catch !MMU regressions before
> > they hit mainline.
> >
> > Should we accept old !MMU code into mainline for platforms which kernel
> > developers have, in order to aid testing, even though it isn't modern
> > platforms and doesn't conform to the latest way of doing stuff.
> 
> I think we should have at least one arm-nommu platform in the upstream kernel,
> with a suitable defconfig, so 0build will catch regressions.

Does it?  Plainly not, because we've had this "noMMU has broken in
mainline" problem many times without it being flagged up before it hits
mainline.

> Alternative, can any of the existing supported arm-mmu platform be used
> with a nommu kernel?

Your choices in my test farm are: OMAP4430 SDP, OMAP3430 LDP, Versatile
Express, and Juno.  I don't think any of these currently have working
noMMU support.

For the OKI, we're talking about this much code in the branch right
now:

 arch/arm/Kconfig                                  |  12 +
 arch/arm/Makefile                                 |   1 +
 arch/arm/boot/bootp/init.S                        |   9 +-
 arch/arm/boot/compressed/misc.c                   |   3 +-
 arch/arm/mach-okiml67x/Kconfig                    |   0
 arch/arm/mach-okiml67x/Makefile                   |   1 +
 arch/arm/mach-okiml67x/Makefile.boot              |   3 +
 arch/arm/mach-okiml67x/core.c                     | 346 ++++++++++++++++++
 arch/arm/mach-okiml67x/core.h                     |   6 +
 arch/arm/mach-okiml67x/include/mach/debug-macro.S |   4 +
 arch/arm/mach-okiml67x/include/mach/entry-macro.S |  21 ++
 arch/arm/mach-okiml67x/include/mach/io.h          |  11 +
 arch/arm/mach-okiml67x/include/mach/irqs.h        |   6 +
 arch/arm/mach-okiml67x/include/mach/memory.h      |   6 +
 arch/arm/mach-okiml67x/include/mach/oki-irq.h     |  21 ++
 arch/arm/mach-okiml67x/include/mach/oki.h         |  56 +++
 arch/arm/mach-okiml67x/include/mach/timex.h       |   6 +
 arch/arm/mach-okiml67x/include/mach/uncompress.h  |   5 +
 drivers/i2c/busses/Kconfig                        |   7 +
 drivers/i2c/busses/Makefile                       |   1 +
 drivers/i2c/busses/i2c-okiml67x.c                 | 268 ++++++++++++++
 drivers/spi/Kconfig                               |   7 +
 drivers/spi/Makefile                              |   1 +
 drivers/spi/spi-okiml67x.c                        | 414 ++++++++++++++++++++++
 24 files changed, 1213 insertions(+), 2 deletions(-)

Drop the I2C and SPI drivers out, and it's under half that - 515 lines.
515 lines to get a noMMU system into my build farm.  Is that really too
expensive if it then provides nightly build coverage and boot testing
for an area of the kernel which keeps getting broken without us
realising before it's hit mainline?

There's a few small fixes that will be required elsewhere (I'm just
building it now) to make buildable with existing mainline - mostly
updates to it's code for recent changes (set_irq_flags conversion,
and fixing a previous commit which removed the #ifndef TASK_SIZE...
#endif around the definition there) and fixing a number of link time
errors around ioport_unmap, ioport_map, and ioport_unmap.

There's an old saying: scratch my back, and I'll scratch your back.
No one's willing to do the little bit which helps to avoid these
build errors happening, so... well, I guess they'll just keep on
happening until people change their minds.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1255531

Hi,

On Sun, Oct 25, 2015 at 06:38:18PM +0100, Geert Uytterhoeven wrote:

> I think we should have at least one arm-nommu platform in the upstream kernel,
> with a suitable defconfig, so 0build will catch regressions.

afaik, there are 4 arm-nommu defconfig's. Has been recently playing
with Vybrid nommu platform, did not notice any build error w/ it's
defconfig (vf610m4) and able to boot too. Just now tried -rc7, it too
was success.

Regards
afzal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1255572

On Mon, Oct 26, 2015 at 12:33:18AM +0530, Afzal Mohammed wrote:
> On Sun, Oct 25, 2015 at 06:38:18PM +0100, Geert Uytterhoeven wrote:
> > I think we should have at least one arm-nommu platform in the upstream kernel,
> > with a suitable defconfig, so 0build will catch regressions.
> 
> afaik, there are 4 arm-nommu defconfig's. Has been recently playing
> with Vybrid nommu platform, did not notice any build error w/ it's
> defconfig (vf610m4) and able to boot too. Just now tried -rc7, it too
> was success.

vf610m4 won't use patch.c since it has CONFIG_XIP_KERNEL=y.  The failing
config is a randconfig[1], but the error can be triggered by, for
example, enabling CONFIG_JUMP_LABEL=y on lpc18xx_defconfig.

[1] http://kisskb.ellerman.id.au/kisskb/buildresult/12531538/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1255576

On Sun, Oct 25, 2015 at 11:39:15AM +0100, Geert Uytterhoeven wrote:
> On Sun, Oct 25, 2015 at 11:18 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > On Sun, Oct 25, 2015 at 11:12 AM, Geert Uytterhoeven
> > <geert@linux-m68k.org> wrote:
> >> JFYI, when comparing v4.3-rc7[1] to v4.3-rc6[3], the summaries are:
> >>   - build errors: +12/-4

From the quoted lines above one I got the impression that this was a
regression from v4.3-rc6 to 4.3-rc7, but that's not the case.  The
failing config also fails with v4.3-rc6.  It is however a regression
from v4.2 to v4.3-rc1, and started failing after the changes in
a5f4c561b3b19a ("ARM: 8415/1: early fixmap support for earlycon").

> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_DIRTY' undeclared (first use in this function):  => 39:2
> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_MT_WRITEBACK' undeclared (first use in this function):  => 39:2
> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_PRESENT' undeclared (first use in this function):  => 39:2
> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_XN' undeclared (first use in this function):  => 39:2
> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_YOUNG' undeclared (first use in this function):  => 39:2
> 
> Caused by:
> 
> commit ab0615e2d6fb074764a3e4d05f1326fa2fdb4627
> Author: Rabin Vincent <rabin@rab.in>
> Date:   Thu Apr 24 23:28:57 2014 +0200
> 
>     arm: use fixmap for text patching when text is RO
> 
> Should the call to set_fixmap() in arch/arm/kernel/patch.c
> just be protected by #ifdef CONFIG_MMU?

Yes, and the call to clear_fixmap() too.  This part of the code will
never actually be called on !MMU because patch_map() will always exit
early with nothing to remap.  Will you send a patch?

(More code can be ifdef'd out to make a cleaner solution but I think that
 really needs a simplification of the locking to be done first, which is
 bit much for a late -rc.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1255718

Hi Rabin,

On Sun, Oct 25, 2015 at 11:32 PM, Rabin Vincent <rabin@rab.in> wrote:
> On Sun, Oct 25, 2015 at 11:39:15AM +0100, Geert Uytterhoeven wrote:
>> On Sun, Oct 25, 2015 at 11:18 AM, Geert Uytterhoeven
>> <geert@linux-m68k.org> wrote:
>> > On Sun, Oct 25, 2015 at 11:12 AM, Geert Uytterhoeven
>> > <geert@linux-m68k.org> wrote:
>> >> JFYI, when comparing v4.3-rc7[1] to v4.3-rc6[3], the summaries are:
>> >>   - build errors: +12/-4
>
> From the quoted lines above one I got the impression that this was a
> regression from v4.3-rc6 to 4.3-rc7, but that's not the case.  The

randconfig regression reports are never accurate, as each run is different.

> failing config also fails with v4.3-rc6.  It is however a regression
> from v4.2 to v4.3-rc1, and started failing after the changes in
> a5f4c561b3b19a ("ARM: 8415/1: early fixmap support for earlycon").
>
>> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_DIRTY' undeclared (first use in this function):  => 39:2
>> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_MT_WRITEBACK' undeclared (first use in this function):  => 39:2
>> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_PRESENT' undeclared (first use in this function):  => 39:2
>> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_XN' undeclared (first use in this function):  => 39:2
>> >   + /home/kisskb/slave/src/arch/arm/kernel/patch.c: error: 'L_PTE_YOUNG' undeclared (first use in this function):  => 39:2
>>
>> Caused by:
>>
>> commit ab0615e2d6fb074764a3e4d05f1326fa2fdb4627
>> Author: Rabin Vincent <rabin@rab.in>
>> Date:   Thu Apr 24 23:28:57 2014 +0200
>>
>>     arm: use fixmap for text patching when text is RO
>>
>> Should the call to set_fixmap() in arch/arm/kernel/patch.c
>> just be protected by #ifdef CONFIG_MMU?
>
> Yes, and the call to clear_fixmap() too.  This part of the code will

OK.

> never actually be called on !MMU because patch_map() will always exit
> early with nothing to remap.  Will you send a patch?

Thanks, sent.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1255513

On Sun, Oct 25, 2015 at 11:18 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Sun, Oct 25, 2015 at 11:12 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> JFYI, when comparing v4.3-rc7[1] to v4.3-rc6[3], the summaries are:
>>   - build errors: +12/-4
>
>   + /home/kisskb/slave/src/arch/arm/kernel/devtree.c: error: implicit declaration of function 'early_init_dt_scan_nodes' [-Werror=implicit-function-declaration]:  => 244:2
>   + /home/kisskb/slave/src/arch/arm/kernel/devtree.c: error: implicit declaration of function 'early_init_dt_verify' [-Werror=implicit-function-declaration]:  => 215:2
>   + /home/kisskb/slave/src/arch/arm/kernel/devtree.c: error: implicit declaration of function 'of_flat_dt_match_machine' [-Werror=implicit-function-declaration]:  => 218:2
>   + /home/kisskb/slave/src/arch/arm/kernel/devtree.c: error: implicit declaration of function 'of_get_flat_dt_prop' [-Werror=implicit-function-declaration]:  => 229:3
>   + /home/kisskb/slave/src/arch/arm/kernel/devtree.c: error: implicit declaration of function 'of_get_flat_dt_root' [-Werror=implicit-function-declaration]:  => 228:3

> arm-randconfig (all seen and reported before)

CONFIG_OF=y with CONFIG_USE_OF=n, which used to be an impossibe
combination on ARM. Patch sent.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web