Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1255499 > unrolled thread

[PATCH] irqchip: tegra: propagate IRQ type setting to parent

Started byLucas Stach <dev@lynxeye.de>
First post2015-10-25 16:50 +0100
Last post2015-10-26 01:30 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] irqchip: tegra: propagate IRQ type setting to parent Lucas Stach <dev@lynxeye.de> - 2015-10-25 16:50 +0100
    [tip:irq/urgent] irqchip/tegra:   Propagate IRQ type setting to parent tip-bot for Lucas Stach <tipbot@zytor.com> - 2015-10-26 01:30 +0100

#1255499 — [PATCH] irqchip: tegra: propagate IRQ type setting to parent

FromLucas Stach <dev@lynxeye.de>
Date2015-10-25 16:50 +0100
Subject[PATCH] irqchip: tegra: propagate IRQ type setting to parent
Message-ID<qnvIt-4LF-3@gated-at.bofh.it>
The LIC doesn't deal with the different types of interrupts itself
but needs to forward calls to set the appropriate type to its parent
IRQ controller.

Without this fix all IRQs routed through the LIC will stay at the
initial EDGE type, while most of them should actually be level triggered.

Cc: <stable@vger.kernel.org> # 4.1
Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 drivers/irqchip/irq-tegra.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-tegra.c b/drivers/irqchip/irq-tegra.c
index 2fd89eb..fd88e68 100644
--- a/drivers/irqchip/irq-tegra.c
+++ b/drivers/irqchip/irq-tegra.c
@@ -214,6 +214,7 @@ static struct irq_chip tegra_ictlr_chip = {
 	.irq_unmask		= tegra_unmask,
 	.irq_retrigger		= tegra_retrigger,
 	.irq_set_wake		= tegra_set_wake,
+	.irq_set_type		= irq_chip_set_type_parent,
 	.flags			= IRQCHIP_MASK_ON_SUSPEND,
 #ifdef CONFIG_SMP
 	.irq_set_affinity	= irq_chip_set_affinity_parent,
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1255595 — [tip:irq/urgent] irqchip/tegra: Propagate IRQ type setting to parent

Fromtip-bot for Lucas Stach <tipbot@zytor.com>
Date2015-10-26 01:30 +0100
Subject[tip:irq/urgent] irqchip/tegra: Propagate IRQ type setting to parent
Message-ID<qnDPH-1kC-3@gated-at.bofh.it>
In reply to#1255499
Commit-ID:  209da39154837ec1b69fb34f438041939911e4b4
Gitweb:     http://git.kernel.org/tip/209da39154837ec1b69fb34f438041939911e4b4
Author:     Lucas Stach <dev@lynxeye.de>
AuthorDate: Sun, 25 Oct 2015 16:39:12 +0100
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 26 Oct 2015 09:20:59 +0900

irqchip/tegra: Propagate IRQ type setting to parent

The LIC doesn't deal with the different types of interrupts itself
but needs to forward calls to set the appropriate type to its parent
IRQ controller.

Without this fix all IRQs routed through the LIC will stay at the
initial EDGE type, while most of them should actually be level triggered.

Fixes: 1eec582158e2 "irqchip: tegra: Add Tegra210 support"
Signed-off-by: Lucas Stach <dev@lynxeye.de>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: <stable@vger.kernel.org> # 4.1
Link: http://lkml.kernel.org/r/1445787552-13062-1-git-send-email-dev@lynxeye.de
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/irqchip/irq-tegra.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irq-tegra.c b/drivers/irqchip/irq-tegra.c
index 2fd89eb..fd88e68 100644
--- a/drivers/irqchip/irq-tegra.c
+++ b/drivers/irqchip/irq-tegra.c
@@ -214,6 +214,7 @@ static struct irq_chip tegra_ictlr_chip = {
 	.irq_unmask		= tegra_unmask,
 	.irq_retrigger		= tegra_retrigger,
 	.irq_set_wake		= tegra_set_wake,
+	.irq_set_type		= irq_chip_set_type_parent,
 	.flags			= IRQCHIP_MASK_ON_SUSPEND,
 #ifdef CONFIG_SMP
 	.irq_set_affinity	= irq_chip_set_affinity_parent,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web