Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1255498 > unrolled thread
| Started by | Lucas Stach <dev@lynxeye.de> |
|---|---|
| First post | 2015-10-25 16:50 +0100 |
| Last post | 2015-10-27 22:00 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] clocksource/drivers/tegra: allow timer irq affinity change Lucas Stach <dev@lynxeye.de> - 2015-10-25 16:50 +0100
Re: [PATCH] clocksource/drivers/tegra: allow timer irq affinity change Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-27 11:20 +0100
Re: [PATCH] clocksource/drivers/tegra: allow timer irq affinity change Lucas Stach <dev@lynxeye.de> - 2015-10-27 21:30 +0100
Re: [PATCH] clocksource/drivers/tegra: allow timer irq affinity change Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-10-27 22:00 +0100
| From | Lucas Stach <dev@lynxeye.de> |
|---|---|
| Date | 2015-10-25 16:50 +0100 |
| Subject | [PATCH] clocksource/drivers/tegra: allow timer irq affinity change |
| Message-ID | <qnvIt-4LF-1@gated-at.bofh.it> |
Allow the timer core to change the smp affinity of the broadcast timer
irq by setting CLOCK_EVT_FEAT_DYNIRQ flag.
This reduces interrupt pressure and wakeups on CPU0 as well as vastly
reducing the number of timer broadcast IPIs.
Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
drivers/clocksource/tegra20_timer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clocksource/tegra20_timer.c b/drivers/clocksource/tegra20_timer.c
index 6ebda11..38333ab 100644
--- a/drivers/clocksource/tegra20_timer.c
+++ b/drivers/clocksource/tegra20_timer.c
@@ -96,7 +96,8 @@ static struct clock_event_device tegra_clockevent = {
.name = "timer0",
.rating = 300,
.features = CLOCK_EVT_FEAT_ONESHOT |
- CLOCK_EVT_FEAT_PERIODIC,
+ CLOCK_EVT_FEAT_PERIODIC |
+ CLOCK_EVT_FEAT_DYNIRQ,
.set_next_event = tegra_timer_set_next_event,
.set_state_shutdown = tegra_timer_shutdown,
.set_state_periodic = tegra_timer_set_periodic,
--
2.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-10-27 11:20 +0100 |
| Subject | Re: [PATCH] clocksource/drivers/tegra: allow timer irq affinity change |
| Message-ID | <qo9wd-3Yv-5@gated-at.bofh.it> |
| In reply to | #1255498 |
On 10/25/2015 04:40 PM, Lucas Stach wrote: > Allow the timer core to change the smp affinity of the broadcast timer > irq by setting CLOCK_EVT_FEAT_DYNIRQ flag. > > This reduces interrupt pressure and wakeups on CPU0 as well as vastly > reducing the number of timer broadcast IPIs. Did you test this patch on a tegra2 ? -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Lucas Stach <dev@lynxeye.de> |
|---|---|
| Date | 2015-10-27 21:30 +0100 |
| Subject | Re: [PATCH] clocksource/drivers/tegra: allow timer irq affinity change |
| Message-ID | <qoj2y-1i5-15@gated-at.bofh.it> |
| In reply to | #1256648 |
Am Dienstag, den 27.10.2015, 11:14 +0100 schrieb Daniel Lezcano: > On 10/25/2015 04:40 PM, Lucas Stach wrote: > > Allow the timer core to change the smp affinity of the broadcast > > timer > > irq by setting CLOCK_EVT_FEAT_DYNIRQ flag. > > > > This reduces interrupt pressure and wakeups on CPU0 as well as > > vastly > > reducing the number of timer broadcast IPIs. > > Did you test this patch on a tegra2 ? > Yes, I haven't spotted anything bad, but don't know if I should look out for specific oddities? Regards, Lucas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Daniel Lezcano <daniel.lezcano@linaro.org> |
|---|---|
| Date | 2015-10-27 22:00 +0100 |
| Subject | Re: [PATCH] clocksource/drivers/tegra: allow timer irq affinity change |
| Message-ID | <qojvC-1tZ-47@gated-at.bofh.it> |
| In reply to | #1257177 |
On 10/27/2015 09:22 PM, Lucas Stach wrote: > Am Dienstag, den 27.10.2015, 11:14 +0100 schrieb Daniel Lezcano: >> On 10/25/2015 04:40 PM, Lucas Stach wrote: >>> Allow the timer core to change the smp affinity of the broadcast >>> timer >>> irq by setting CLOCK_EVT_FEAT_DYNIRQ flag. >>> >>> This reduces interrupt pressure and wakeups on CPU0 as well as >>> vastly >>> reducing the number of timer broadcast IPIs. >> >> Did you test this patch on a tegra2 ? >> > Yes, I haven't spotted anything bad, but don't know if I should look > out for specific oddities? I was wondering if you tested it because the changelog was the same than the similar change you did previously so I wanted to know if you assumed the behavior or if you tested it. So, no problem. Thanks ! -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web