Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1256098 > unrolled thread

Re: [PATCH v9 0/9] Goodix touchscreen enhancements

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v9 0/9] Goodix touchscreen enhancements Bastien Nocera <hadess@hadess.net> - 2015-10-26 16:10 +0100
    Re: [PATCH v9 0/9] Goodix touchscreen enhancements Karsten Merker <merker@debian.org> - 2015-10-26 19:30 +0100
      Re: [PATCH v9 0/9] Goodix touchscreen enhancements Bastien Nocera <hadess@hadess.net> - 2015-10-26 19:50 +0100
      Re: [PATCH v9 0/9] Goodix touchscreen enhancements Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-27 00:40 +0100
        RE: [PATCH v9 0/9] Goodix touchscreen enhancements "Tirdea, Irina" <irina.tirdea@intel.com> - 2015-10-27 10:20 +0100
      RE: [PATCH v9 0/9] Goodix touchscreen enhancements "Tirdea, Irina" <irina.tirdea@intel.com> - 2015-10-27 10:20 +0100

#1256098 — Re: [PATCH v9 0/9] Goodix touchscreen enhancements

Hey,

On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote:
> v9 only adds GPIOLIB dependency in Kconfig for patch 2:
> "Input: goodix - reset device at init". There are no other code
> changes from v8.
> 
> Thanks for testing these changes, Bastien and Aleksei!
> 
> Karsten, there is no need to rebase your series on top of v9.

Are we waiting on anything else before merging this? I'd like it to be
scheduled to be merged so I can start focusing on the subsequent and
dependent patches for that same driver.

Cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1256210

On Mon, Oct 26, 2015 at 04:06:29PM +0100, Bastien Nocera wrote:
> On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote:

> > v9 only adds GPIOLIB dependency in Kconfig for patch 2:
> > "Input: goodix - reset device at init". There are no other code
> > changes from v8.
> > 
> > Thanks for testing these changes, Bastien and Aleksei!
> > 
> > Karsten, there is no need to rebase your series on top of v9.
> 
> Are we waiting on anything else before merging this? I'd like it to be
> scheduled to be merged so I can start focusing on the subsequent and
> dependent patches for that same driver.

Hello,

AFAICS there is one open point (cf. 
http://www.spinics.net/lists/linux-input/msg41567.html) which
Irina wanted to address in a v10 of the patchset (cf. 
http://www.spinics.net/lists/linux-input/msg41642.html).

Irina, how are your plans regarding the v10? It would be really
nice if the patches could go into kernel 4.4, but the merge
window opens on the coming weekend, so there is not much time
left.

Bastien, did you have time to look at v3 of the axis
swapping/inversion set?
(http://www.spinics.net/lists/linux-input/msg41628.html)
You had acked v2, but I had to do some small changes to address
Irina's review comments after you had acked it, so I didn't want
to carry your "acked-by" on to v3 without an ok from you.

Regards,
Karsten
-- 
Gem. Par. 28 Abs. 4 Bundesdatenschutzgesetz widerspreche ich der Nutzung
sowie der Weitergabe meiner personenbezogenen Daten für Zwecke der
Werbung sowie der Markt- oder Meinungsforschung.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1256215

On Mon, 2015-10-26 at 19:21 +0100, Karsten Merker wrote:
> On Mon, Oct 26, 2015 at 04:06:29PM +0100, Bastien Nocera wrote:
> > On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote:
> 
> > > v9 only adds GPIOLIB dependency in Kconfig for patch 2:
> > > "Input: goodix - reset device at init". There are no other code
> > > changes from v8.
> > > 
> > > Thanks for testing these changes, Bastien and Aleksei!
> > > 
> > > Karsten, there is no need to rebase your series on top of v9.
> > 
> > Are we waiting on anything else before merging this? I'd like it to
> > be
> > scheduled to be merged so I can start focusing on the subsequent
> > and
> > dependent patches for that same driver.
> 
> Hello,
> 
> AFAICS there is one open point (cf. 
> http://www.spinics.net/lists/linux-input/msg41567.html) which
> Irina wanted to address in a v10 of the patchset (cf. 
> http://www.spinics.net/lists/linux-input/msg41642.html).
> 
> Irina, how are your plans regarding the v10? It would be really
> nice if the patches could go into kernel 4.4, but the merge
> window opens on the coming weekend, so there is not much time
> left.
> 
> Bastien, did you have time to look at v3 of the axis
> swapping/inversion set?
> (http://www.spinics.net/lists/linux-input/msg41628.html)
> You had acked v2, but I had to do some small changes to address
> Irina's review comments after you had acked it, so I didn't want
> to carry your "acked-by" on to v3 without an ok from you.

I was waiting on at least Irina's patches being merged before testing
your patches again. I have limited time to do testing on this (I have
plenty more hardware that's sitting unloved here), and wanted to
minimise the amount of time I'd spend testing it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1256348

On Mon, Oct 26, 2015 at 07:21:12PM +0100, Karsten Merker wrote:
> On Mon, Oct 26, 2015 at 04:06:29PM +0100, Bastien Nocera wrote:
> > On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote:
> 
> > > v9 only adds GPIOLIB dependency in Kconfig for patch 2:
> > > "Input: goodix - reset device at init". There are no other code
> > > changes from v8.
> > > 
> > > Thanks for testing these changes, Bastien and Aleksei!
> > > 
> > > Karsten, there is no need to rebase your series on top of v9.
> > 
> > Are we waiting on anything else before merging this? I'd like it to be
> > scheduled to be merged so I can start focusing on the subsequent and
> > dependent patches for that same driver.
> 
> Hello,
> 
> AFAICS there is one open point (cf. 
> http://www.spinics.net/lists/linux-input/msg41567.html) which
> Irina wanted to address in a v10 of the patchset (cf. 
> http://www.spinics.net/lists/linux-input/msg41642.html).

There is also the whole thing about insane handling of named gpios in
ACPI layer, which stops me from merging the reset code since these gpios
should be marked as optional and we should stop ignoring errors coming
from gpiolib.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1256605

> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> Sent: 27 October, 2015 1:33
> To: Karsten Merker
> Cc: Bastien Nocera; Tirdea, Irina; Aleksei Mamlin; linux-input@vger.kernel.org; Mark Rutland; Purdila, Octavian; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH v9 0/9] Goodix touchscreen enhancements
> 
> On Mon, Oct 26, 2015 at 07:21:12PM +0100, Karsten Merker wrote:
> > On Mon, Oct 26, 2015 at 04:06:29PM +0100, Bastien Nocera wrote:
> > > On Mon, 2015-10-12 at 18:24 +0300, Irina Tirdea wrote:
> >
> > > > v9 only adds GPIOLIB dependency in Kconfig for patch 2:
> > > > "Input: goodix - reset device at init". There are no other code
> > > > changes from v8.
> > > >
> > > > Thanks for testing these changes, Bastien and Aleksei!
> > > >
> > > > Karsten, there is no need to rebase your series on top of v9.
> > >
> > > Are we waiting on anything else before merging this? I'd like it to be
> > > scheduled to be merged so I can start focusing on the subsequent and
> > > dependent patches for that same driver.
> >
> > Hello,
> >
> > AFAICS there is one open point (cf.
> > http://www.spinics.net/lists/linux-input/msg41567.html) which
> > Irina wanted to address in a v10 of the patchset (cf.
> > http://www.spinics.net/lists/linux-input/msg41642.html).
> 
> There is also the whole thing about insane handling of named gpios in
> ACPI layer, which stops me from merging the reset code since these gpios
> should be marked as optional and we should stop ignoring errors coming
> from gpiolib.

The ACPI layer change is quite complex, since it includes changing the drivers
that use the gpio API before removing the fallback to indexed ACPI.
Not sure that will not also break current drivers that already count on this
fallback. Unfortunately, I do not have the time right now to get involved in
fixing the ACPI core myself.

Dmitry, is there anything I can do in the driver to get these patches merged?
I could go back to using indexed gpios and add an additional property
to specify if irq can be used as output or not (as suggested in one of the
previous reviews).

Thanks,
Irina

> 
> Thanks.
> 
> --
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1256599

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogS2Fyc3RlbiBNZXJrZXIg
W21haWx0bzptZXJrZXJAZGViaWFuLm9yZ10NCj4gU2VudDogMjYgT2N0b2JlciwgMjAxNSAyMDoy
MQ0KPiBUbzogQmFzdGllbiBOb2NlcmE7IFRpcmRlYSwgSXJpbmENCj4gQ2M6IERtaXRyeSBUb3Jv
a2hvdjsgQWxla3NlaSBNYW1saW47IEthcnN0ZW4gTWVya2VyOyBsaW51eC1pbnB1dEB2Z2VyLmtl
cm5lbC5vcmc7IE1hcmsgUnV0bGFuZDsgUHVyZGlsYSwgT2N0YXZpYW47IGxpbnV4LQ0KPiBrZXJu
ZWxAdmdlci5rZXJuZWwub3JnOyBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZw0KPiBTdWJqZWN0
OiBSZTogW1BBVENIIHY5IDAvOV0gR29vZGl4IHRvdWNoc2NyZWVuIGVuaGFuY2VtZW50cw0KPiAN
Cj4gT24gTW9uLCBPY3QgMjYsIDIwMTUgYXQgMDQ6MDY6MjlQTSArMDEwMCwgQmFzdGllbiBOb2Nl
cmEgd3JvdGU6DQo+ID4gT24gTW9uLCAyMDE1LTEwLTEyIGF0IDE4OjI0ICswMzAwLCBJcmluYSBU
aXJkZWEgd3JvdGU6DQo+IA0KPiA+ID4gdjkgb25seSBhZGRzIEdQSU9MSUIgZGVwZW5kZW5jeSBp
biBLY29uZmlnIGZvciBwYXRjaCAyOg0KPiA+ID4gIklucHV0OiBnb29kaXggLSByZXNldCBkZXZp
Y2UgYXQgaW5pdCIuIFRoZXJlIGFyZSBubyBvdGhlciBjb2RlDQo+ID4gPiBjaGFuZ2VzIGZyb20g
djguDQo+ID4gPg0KPiA+ID4gVGhhbmtzIGZvciB0ZXN0aW5nIHRoZXNlIGNoYW5nZXMsIEJhc3Rp
ZW4gYW5kIEFsZWtzZWkhDQo+ID4gPg0KPiA+ID4gS2Fyc3RlbiwgdGhlcmUgaXMgbm8gbmVlZCB0
byByZWJhc2UgeW91ciBzZXJpZXMgb24gdG9wIG9mIHY5Lg0KPiA+DQo+ID4gQXJlIHdlIHdhaXRp
bmcgb24gYW55dGhpbmcgZWxzZSBiZWZvcmUgbWVyZ2luZyB0aGlzPyBJJ2QgbGlrZSBpdCB0byBi
ZQ0KPiA+IHNjaGVkdWxlZCB0byBiZSBtZXJnZWQgc28gSSBjYW4gc3RhcnQgZm9jdXNpbmcgb24g
dGhlIHN1YnNlcXVlbnQgYW5kDQo+ID4gZGVwZW5kZW50IHBhdGNoZXMgZm9yIHRoYXQgc2FtZSBk
cml2ZXIuDQo+IA0KPiBIZWxsbywNCj4gDQo+IEFGQUlDUyB0aGVyZSBpcyBvbmUgb3BlbiBwb2lu
dCAoY2YuDQo+IGh0dHA6Ly93d3cuc3Bpbmljcy5uZXQvbGlzdHMvbGludXgtaW5wdXQvbXNnNDE1
NjcuaHRtbCkgd2hpY2gNCj4gSXJpbmEgd2FudGVkIHRvIGFkZHJlc3MgaW4gYSB2MTAgb2YgdGhl
IHBhdGNoc2V0IChjZi4NCj4gaHR0cDovL3d3dy5zcGluaWNzLm5ldC9saXN0cy9saW51eC1pbnB1
dC9tc2c0MTY0Mi5odG1sKS4NCj4gDQo+IElyaW5hLCBob3cgYXJlIHlvdXIgcGxhbnMgcmVnYXJk
aW5nIHRoZSB2MTA/IEl0IHdvdWxkIGJlIHJlYWxseQ0KPiBuaWNlIGlmIHRoZSBwYXRjaGVzIGNv
dWxkIGdvIGludG8ga2VybmVsIDQuNCwgYnV0IHRoZSBtZXJnZQ0KPiB3aW5kb3cgb3BlbnMgb24g
dGhlIGNvbWluZyB3ZWVrZW5kLCBzbyB0aGVyZSBpcyBub3QgbXVjaCB0aW1lDQo+IGxlZnQuDQoN
CkkgY2FuIHNlbmQgdjEwIHdpdGggdGhlIGNoYW5nZSBtZW50aW9uZWQgYWJvdmUgYnkgdGhlIGVu
ZCBvZiB0aGlzIHdlZWsuDQoNCkhvd2V2ZXIsIGFzIERtaXRyeSBhbHJlYWR5IG1lbnRpb25lZCwg
dGhlcmUgaXMgYW5vdGhlciBpc3N1ZSB3aXRoDQp0aGUgZ3BpbyBBQ1BJIGxheWVyIHRoYXQgaXMg
YmxvY2tpbmcgdGhlIGVudGlyZSBwYXRjaHNldC4NCg0KPiANCj4gQmFzdGllbiwgZGlkIHlvdSBo
YXZlIHRpbWUgdG8gbG9vayBhdCB2MyBvZiB0aGUgYXhpcw0KPiBzd2FwcGluZy9pbnZlcnNpb24g
c2V0Pw0KPiAoaHR0cDovL3d3dy5zcGluaWNzLm5ldC9saXN0cy9saW51eC1pbnB1dC9tc2c0MTYy
OC5odG1sKQ0KPiBZb3UgaGFkIGFja2VkIHYyLCBidXQgSSBoYWQgdG8gZG8gc29tZSBzbWFsbCBj
aGFuZ2VzIHRvIGFkZHJlc3MNCj4gSXJpbmEncyByZXZpZXcgY29tbWVudHMgYWZ0ZXIgeW91IGhh
ZCBhY2tlZCBpdCwgc28gSSBkaWRuJ3Qgd2FudA0KPiB0byBjYXJyeSB5b3VyICJhY2tlZC1ieSIg
b24gdG8gdjMgd2l0aG91dCBhbiBvayBmcm9tIHlvdS4NCj4gDQo+IFJlZ2FyZHMsDQo+IEthcnN0
ZW4NCj4gLS0NCj4gR2VtLiBQYXIuIDI4IEFicy4gNCBCdW5kZXNkYXRlbnNjaHV0emdlc2V0eiB3
aWRlcnNwcmVjaGUgaWNoIGRlciBOdXR6dW5nDQo+IHNvd2llIGRlciBXZWl0ZXJnYWJlIG1laW5l
ciBwZXJzb25lbmJlem9nZW5lbiBEYXRlbiBmw7xyIFp3ZWNrZSBkZXINCj4gV2VyYnVuZyBzb3dp
ZSBkZXIgTWFya3QtIG9kZXIgTWVpbnVuZ3Nmb3JzY2h1bmcuDQo=
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web