Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1250101 > unrolled thread

Re: [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree SF Markus Elfring <elfring@users.sourceforge.net> - 2015-10-18 12:00 +0200
    Re: [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree Michal Marek <mmarek@suse.com> - 2015-10-26 22:40 +0100
      Re: [PATCH 1/2] coccinelle: ifnullfree: improve and extend  ifnullfree Julia Lawall <julia.lawall@lip6.fr> - 2015-10-26 22:40 +0100

#1250101 — Re: [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree

> Remove removal and re-addition of freeing functions.

I find such a wording confusing for a commit message.


> Add position variable on usb_free_urb in the non-patch case.

Is it interesting that this fix corresponds to a bug report from 2014-08-09?
https://lkml.org/lkml/2014/8/9/33
https://systeme.lip6.fr/pipermail/cocci/2014-August/001038.html


>  @r depends on context || report || org @
> @@ -36,8 +32,8 @@ expression E;
>  position p;
>  @@
>  
> -* if (E)
> -*	\(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb\)(E);
> +* if (E != NULL)
> +*	\(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb@p\)(E);

How do you think about to extend the shown function name pattern
also with suffixes like the following (besides "destroy")?
* put
* release
* unref
* unregister

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1256297

Dne 18.10.2015 v 11:55 SF Markus Elfring napsal(a):
>> Remove removal and re-addition of freeing functions.
> 
> I find such a wording confusing for a commit message.

It is also a bit confusing to use the same subject for two patches in a
series. How about

[PATCH 1/2] coccinelle: ifnullfree: Adjust tests to compare against NULL
[PATCH 2/2] coccinelle: ifnullfree: handle various destroy functions

?

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1256299 — Re: [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree

On Mon, 26 Oct 2015, Michal Marek wrote:

> Dne 18.10.2015 v 11:55 SF Markus Elfring napsal(a):
> >> Remove removal and re-addition of freeing functions.
> > 
> > I find such a wording confusing for a commit message.
> 
> It is also a bit confusing to use the same subject for two patches in a
> series. How about
> 
> [PATCH 1/2] coccinelle: ifnullfree: Adjust tests to compare against NULL
> [PATCH 2/2] coccinelle: ifnullfree: handle various destroy functions

Sorry.  I'll send them again.

julia

> 
> ?
> 
> Michal
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web