Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1254129 > unrolled thread

[PATCH] clk: iproc: Make clocks visible options

Started byJon Mason <jonmason@broadcom.com>
First post2015-10-22 21:30 +0200
Last post2015-10-28 01:40 +0100
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] clk: iproc: Make clocks visible options Jon Mason <jonmason@broadcom.com> - 2015-10-22 21:30 +0200
    Re: [PATCH] clk: iproc: Make clocks visible options Scott Branden <sbranden@broadcom.com> - 2015-10-22 21:50 +0200
      Re: [PATCH] clk: iproc: Make clocks visible options Jon Mason <jonmason@broadcom.com> - 2015-10-22 22:20 +0200
        Re: [PATCH] clk: iproc: Make clocks visible options Florian Fainelli <fainelli@broadcom.com> - 2015-10-23 00:00 +0200
        Re: [PATCH] clk: iproc: Make clocks visible options Scott Branden <sbranden@broadcom.com> - 2015-10-23 01:20 +0200
    Re: [PATCH] clk: iproc: Make clocks visible options Stephen Boyd <sboyd@codeaurora.org> - 2015-10-28 01:40 +0100

#1254129 — [PATCH] clk: iproc: Make clocks visible options

FromJon Mason <jonmason@broadcom.com>
Date2015-10-22 21:30 +0200
Subject[PATCH] clk: iproc: Make clocks visible options
Message-ID<qmtIJ-3vR-11@gated-at.bofh.it>
Make the clocks visible options that can be selected by anyone.  This
avoids the problems of:
 1) Select is a reverse dependency and is hard for people to understand
    and can sometimes be a pain to track down
 2) Build coverage goes down because configs are hidden
 3) Code bloat

Patch suggested by Stephen Boyd

Signed-off-by: Jon Mason <jonmason@broadcom.com>
---
 arch/arm/mach-bcm/Kconfig |  1 -
 drivers/clk/bcm/Kconfig   | 35 ++++++++++++++++++++++++++++++++++-
 drivers/clk/bcm/Makefile  |  7 +++----
 3 files changed, 37 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index 679798b..cacaaec 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -14,7 +14,6 @@ config ARCH_BCM_IPROC
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD if SMP
 	select ARM_GLOBAL_TIMER
-	select COMMON_CLK_IPROC
 	select CLKSRC_MMIO
 	select ARCH_REQUIRE_GPIOLIB
 	select ARM_AMBA
diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig
index 46ee475..0352ccf 100644
--- a/drivers/clk/bcm/Kconfig
+++ b/drivers/clk/bcm/Kconfig
@@ -9,8 +9,41 @@ config CLK_BCM_KONA
 	  in the BCM281xx and BCM21664 families.
 
 config COMMON_CLK_IPROC
-	bool
+	bool "Broadcom iProc clock support"
+	depends on ARCH_BCM_IPROC
 	depends on COMMON_CLK
+	default ARCH_BCM_IPROC
 	help
 	  Enable common clock framework support for Broadcom SoCs
 	  based on the iProc architecture
+
+if COMMON_CLK_IPROC
+
+comment "Broadcom iProc clocks"
+
+config CLK_BCM_CYGNUS
+	bool "Broadcom Cygnus clock support"
+	depends on COMMON_CLK_IPROC
+	depends on ARCH_BCM_CYGNUS
+	default ARCH_BCM_CYGNUS
+	help
+	  Enable common clock framework support for the Broadcom Cygnus SoC
+
+config CLK_BCM_NSP
+	bool "Broadcom Northstar/Northstar Plus clock support"
+	depends on COMMON_CLK_IPROC
+	depends on ARCH_BCM_5301X || ARCH_BCM_NSP
+	default ARCH_BCM_5301X || ARCH_BCM_NSP
+	help
+	  Enable common clock framework support for the Broadcom Northstar and
+	  Northstar Plus SoCs
+
+config CLK_BCM_NS2
+	bool "Broadcom Northstar 2 clock support"
+	depends on ARM64
+	depends on COMMON_CLK_IPROC
+	default ARCH_BCM_IPROC
+	help
+	  Enable common clock framework support for the Broadcom Northstar 2 SoC
+
+endif
diff --git a/drivers/clk/bcm/Makefile b/drivers/clk/bcm/Makefile
index 2d1cbc5..05d5830 100644
--- a/drivers/clk/bcm/Makefile
+++ b/drivers/clk/bcm/Makefile
@@ -3,7 +3,6 @@ obj-$(CONFIG_CLK_BCM_KONA)	+= clk-kona-setup.o
 obj-$(CONFIG_CLK_BCM_KONA)	+= clk-bcm281xx.o
 obj-$(CONFIG_CLK_BCM_KONA)	+= clk-bcm21664.o
 obj-$(CONFIG_COMMON_CLK_IPROC)	+= clk-iproc-armpll.o clk-iproc-pll.o clk-iproc-asiu.o
-obj-$(CONFIG_COMMON_CLK_IPROC)	+= clk-ns2.o
-obj-$(CONFIG_ARCH_BCM_CYGNUS)	+= clk-cygnus.o
-obj-$(CONFIG_ARCH_BCM_NSP)	+= clk-nsp.o
-obj-$(CONFIG_ARCH_BCM_5301X)	+= clk-nsp.o
+obj-$(CONFIG_CLK_BCM_CYGNUS)	+= clk-cygnus.o
+obj-$(CONFIG_CLK_BCM_NSP)	+= clk-nsp.o
+obj-$(CONFIG_CLK_BCM_NS2)	+= clk-ns2.o
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1254134

FromScott Branden <sbranden@broadcom.com>
Date2015-10-22 21:50 +0200
Message-ID<qmu25-3Sv-5@gated-at.bofh.it>
In reply to#1254129
Hi Jon,

comments inline.

On 15-10-22 12:25 PM, Jon Mason wrote:
> Make the clocks visible options that can be selected by anyone.  This
> avoids the problems of:
>   1) Select is a reverse dependency and is hard for people to understand
>      and can sometimes be a pain to track down
This doesn't make any sense to me - there are many selects in the system 
and this is one of them.
>   2) Build coverage goes down because configs are hidden
>   3) Code bloat
>
> Patch suggested by Stephen Boyd
>
> Signed-off-by: Jon Mason <jonmason@broadcom.com>
> ---
>   arch/arm/mach-bcm/Kconfig |  1 -
>   drivers/clk/bcm/Kconfig   | 35 ++++++++++++++++++++++++++++++++++-
>   drivers/clk/bcm/Makefile  |  7 +++----
>   3 files changed, 37 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
> index 679798b..cacaaec 100644
> --- a/arch/arm/mach-bcm/Kconfig
> +++ b/arch/arm/mach-bcm/Kconfig
> @@ -14,7 +14,6 @@ config ARCH_BCM_IPROC
>   	select HAVE_ARM_SCU if SMP
>   	select HAVE_ARM_TWD if SMP
>   	select ARM_GLOBAL_TIMER
> -	select COMMON_CLK_IPROC
Please leave as is
>   	select CLKSRC_MMIO
>   	select ARCH_REQUIRE_GPIOLIB
>   	select ARM_AMBA
> diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig
> index 46ee475..0352ccf 100644
> --- a/drivers/clk/bcm/Kconfig
> +++ b/drivers/clk/bcm/Kconfig
> @@ -9,8 +9,41 @@ config CLK_BCM_KONA
>   	  in the BCM281xx and BCM21664 families.
>
>   config COMMON_CLK_IPROC
> -	bool
> +	bool "Broadcom iProc clock support"
Please leave as is
> +	depends on ARCH_BCM_IPROC
>   	depends on COMMON_CLK
> +	default ARCH_BCM_IPROC
>   	help
>   	  Enable common clock framework support for Broadcom SoCs
>   	  based on the iProc architecture
> +
> +if COMMON_CLK_IPROC
> +
> +comment "Broadcom iProc clocks"
> +
> +config CLK_BCM_CYGNUS
not needed
> +	bool "Broadcom Cygnus clock support"
> +	depends on COMMON_CLK_IPROC
> +	depends on ARCH_BCM_CYGNUS
> +	default ARCH_BCM_CYGNUS
> +	help
> +	  Enable common clock framework support for the Broadcom Cygnus SoC
> +
> +config CLK_BCM_NSP
not needed
> +	bool "Broadcom Northstar/Northstar Plus clock support"
> +	depends on COMMON_CLK_IPROC
> +	depends on ARCH_BCM_5301X || ARCH_BCM_NSP
> +	default ARCH_BCM_5301X || ARCH_BCM_NSP
> +	help
> +	  Enable common clock framework support for the Broadcom Northstar and
> +	  Northstar Plus SoCs
> +
> +config CLK_BCM_NS2
> +	bool "Broadcom Northstar 2 clock support"
> +	depends on ARM64
|| COMPILE_TEST
> +	depends on COMMON_CLK_IPROC
select COMMON_CLK_IPROC
> +	default ARCH_BCM_IPROC
> +	help
> +	  Enable common clock framework support for the Broadcom Northstar 2 SoC
> +
> +endif
> diff --git a/drivers/clk/bcm/Makefile b/drivers/clk/bcm/Makefile
> index 2d1cbc5..05d5830 100644
> --- a/drivers/clk/bcm/Makefile
> +++ b/drivers/clk/bcm/Makefile
> @@ -3,7 +3,6 @@ obj-$(CONFIG_CLK_BCM_KONA)	+= clk-kona-setup.o
>   obj-$(CONFIG_CLK_BCM_KONA)	+= clk-bcm281xx.o
>   obj-$(CONFIG_CLK_BCM_KONA)	+= clk-bcm21664.o
>   obj-$(CONFIG_COMMON_CLK_IPROC)	+= clk-iproc-armpll.o clk-iproc-pll.o clk-iproc-asiu.o
> -obj-$(CONFIG_COMMON_CLK_IPROC)	+= clk-ns2.o
yes, change this one
> -obj-$(CONFIG_ARCH_BCM_CYGNUS)	+= clk-cygnus.o
you can leave this
> -obj-$(CONFIG_ARCH_BCM_NSP)	+= clk-nsp.o
you can leave this
> -obj-$(CONFIG_ARCH_BCM_5301X)	+= clk-nsp.o
and this
> +obj-$(CONFIG_CLK_BCM_CYGNUS)	+= clk-cygnus.o
no
> +obj-$(CONFIG_CLK_BCM_NSP)	+= clk-nsp.o
no
> +obj-$(CONFIG_CLK_BCM_NS2)	+= clk-ns2.o
yes needed
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1254156

FromJon Mason <jonmason@broadcom.com>
Date2015-10-22 22:20 +0200
Message-ID<qmuv8-4FS-15@gated-at.bofh.it>
In reply to#1254134
On Thu, Oct 22, 2015 at 12:46:46PM -0700, Scott Branden wrote:
> Hi Jon,
> 
> comments inline.
> 
> On 15-10-22 12:25 PM, Jon Mason wrote:
> >Make the clocks visible options that can be selected by anyone.  This
> >avoids the problems of:
> >  1) Select is a reverse dependency and is hard for people to understand
> >     and can sometimes be a pain to track down
> This doesn't make any sense to me - there are many selects in the
> system and this is one of them.

This was specifically requested by Stephen Boyd, and the above are
his words verbatum
https://lkml.org/lkml/2015/10/21/956

Thanks,
Jon

> >  2) Build coverage goes down because configs are hidden
> >  3) Code bloat
> >
> >Patch suggested by Stephen Boyd
> >
> >Signed-off-by: Jon Mason <jonmason@broadcom.com>
> >---
> >  arch/arm/mach-bcm/Kconfig |  1 -
> >  drivers/clk/bcm/Kconfig   | 35 ++++++++++++++++++++++++++++++++++-
> >  drivers/clk/bcm/Makefile  |  7 +++----
> >  3 files changed, 37 insertions(+), 6 deletions(-)
> >
> >diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
> >index 679798b..cacaaec 100644
> >--- a/arch/arm/mach-bcm/Kconfig
> >+++ b/arch/arm/mach-bcm/Kconfig
> >@@ -14,7 +14,6 @@ config ARCH_BCM_IPROC
> >  	select HAVE_ARM_SCU if SMP
> >  	select HAVE_ARM_TWD if SMP
> >  	select ARM_GLOBAL_TIMER
> >-	select COMMON_CLK_IPROC
> Please leave as is
> >  	select CLKSRC_MMIO
> >  	select ARCH_REQUIRE_GPIOLIB
> >  	select ARM_AMBA
> >diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig
> >index 46ee475..0352ccf 100644
> >--- a/drivers/clk/bcm/Kconfig
> >+++ b/drivers/clk/bcm/Kconfig
> >@@ -9,8 +9,41 @@ config CLK_BCM_KONA
> >  	  in the BCM281xx and BCM21664 families.
> >
> >  config COMMON_CLK_IPROC
> >-	bool
> >+	bool "Broadcom iProc clock support"
> Please leave as is
> >+	depends on ARCH_BCM_IPROC
> >  	depends on COMMON_CLK
> >+	default ARCH_BCM_IPROC
> >  	help
> >  	  Enable common clock framework support for Broadcom SoCs
> >  	  based on the iProc architecture
> >+
> >+if COMMON_CLK_IPROC
> >+
> >+comment "Broadcom iProc clocks"
> >+
> >+config CLK_BCM_CYGNUS
> not needed
> >+	bool "Broadcom Cygnus clock support"
> >+	depends on COMMON_CLK_IPROC
> >+	depends on ARCH_BCM_CYGNUS
> >+	default ARCH_BCM_CYGNUS
> >+	help
> >+	  Enable common clock framework support for the Broadcom Cygnus SoC
> >+
> >+config CLK_BCM_NSP
> not needed
> >+	bool "Broadcom Northstar/Northstar Plus clock support"
> >+	depends on COMMON_CLK_IPROC
> >+	depends on ARCH_BCM_5301X || ARCH_BCM_NSP
> >+	default ARCH_BCM_5301X || ARCH_BCM_NSP
> >+	help
> >+	  Enable common clock framework support for the Broadcom Northstar and
> >+	  Northstar Plus SoCs
> >+
> >+config CLK_BCM_NS2
> >+	bool "Broadcom Northstar 2 clock support"
> >+	depends on ARM64
> || COMPILE_TEST
> >+	depends on COMMON_CLK_IPROC
> select COMMON_CLK_IPROC
> >+	default ARCH_BCM_IPROC
> >+	help
> >+	  Enable common clock framework support for the Broadcom Northstar 2 SoC
> >+
> >+endif
> >diff --git a/drivers/clk/bcm/Makefile b/drivers/clk/bcm/Makefile
> >index 2d1cbc5..05d5830 100644
> >--- a/drivers/clk/bcm/Makefile
> >+++ b/drivers/clk/bcm/Makefile
> >@@ -3,7 +3,6 @@ obj-$(CONFIG_CLK_BCM_KONA)	+= clk-kona-setup.o
> >  obj-$(CONFIG_CLK_BCM_KONA)	+= clk-bcm281xx.o
> >  obj-$(CONFIG_CLK_BCM_KONA)	+= clk-bcm21664.o
> >  obj-$(CONFIG_COMMON_CLK_IPROC)	+= clk-iproc-armpll.o clk-iproc-pll.o clk-iproc-asiu.o
> >-obj-$(CONFIG_COMMON_CLK_IPROC)	+= clk-ns2.o
> yes, change this one
> >-obj-$(CONFIG_ARCH_BCM_CYGNUS)	+= clk-cygnus.o
> you can leave this
> >-obj-$(CONFIG_ARCH_BCM_NSP)	+= clk-nsp.o
> you can leave this
> >-obj-$(CONFIG_ARCH_BCM_5301X)	+= clk-nsp.o
> and this
> >+obj-$(CONFIG_CLK_BCM_CYGNUS)	+= clk-cygnus.o
> no
> >+obj-$(CONFIG_CLK_BCM_NSP)	+= clk-nsp.o
> no
> >+obj-$(CONFIG_CLK_BCM_NS2)	+= clk-ns2.o
> yes needed
> >
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1254194

FromFlorian Fainelli <fainelli@broadcom.com>
Date2015-10-23 00:00 +0200
Message-ID<qmw3U-6NJ-19@gated-at.bofh.it>
In reply to#1254156
On 22/10/15 13:14, Jon Mason wrote:
> On Thu, Oct 22, 2015 at 12:46:46PM -0700, Scott Branden wrote:
>> Hi Jon,
>>
>> comments inline.
>>
>> On 15-10-22 12:25 PM, Jon Mason wrote:
>>> Make the clocks visible options that can be selected by anyone.  This
>>> avoids the problems of:
>>>  1) Select is a reverse dependency and is hard for people to understand
>>>     and can sometimes be a pain to track down
>> This doesn't make any sense to me - there are many selects in the
>> system and this is one of them.
> 
> This was specifically requested by Stephen Boyd, and the above are
> his words verbatum
> https://lkml.org/lkml/2015/10/21/956

I am soon going to introduce a new clock driver under drivers/clk/bcm/
which is going to need some Kconfig tweaks as well, it would be good if
we reached consensus on this so Stephen can apply this.

Thanks!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1254221

FromScott Branden <sbranden@broadcom.com>
Date2015-10-23 01:20 +0200
Message-ID<qmxjj-kT-3@gated-at.bofh.it>
In reply to#1254156
Hi Jon,


On 15-10-22 01:14 PM, Jon Mason wrote:
> On Thu, Oct 22, 2015 at 12:46:46PM -0700, Scott Branden wrote:
>> Hi Jon,
>>
>> comments inline.
>>
>> On 15-10-22 12:25 PM, Jon Mason wrote:
>>> Make the clocks visible options that can be selected by anyone.  This
>>> avoids the problems of:
>>>   1) Select is a reverse dependency and is hard for people to understand
>>>      and can sometimes be a pain to track down
>> This doesn't make any sense to me - there are many selects in the
>> system and this is one of them.
>
> This was specifically requested by Stephen Boyd, and the above are
> his words verbatum
> https://lkml.org/lkml/2015/10/21/956
>
Yes, thanks.  Not all of the comments are needed.  If you look closer 
COMMON_CLK_IPROC should be a non-visible option.  It is just an internal 
config option used in the Makefile only.  There's no benefit to exposing 
an option here and adding another layer to the Kconfig hierarchy.

See my proposed (revised) changes below which remove the code bloat and 
allow build coverage to be increased.  Even if you expose it there are 
additional changes you need to make to your patchset dealing with 
COMPILE_TEST

> Thanks,
> Jon
>
>>>   2) Build coverage goes down because configs are hidden
>>>   3) Code bloat
>>>
>>> Patch suggested by Stephen Boyd
>>>
>>> Signed-off-by: Jon Mason <jonmason@broadcom.com>
>>> ---
>>>   arch/arm/mach-bcm/Kconfig |  1 -
>>>   drivers/clk/bcm/Kconfig   | 35 ++++++++++++++++++++++++++++++++++-
>>>   drivers/clk/bcm/Makefile  |  7 +++----
>>>   3 files changed, 37 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
>>> index 679798b..cacaaec 100644
>>> --- a/arch/arm/mach-bcm/Kconfig
>>> +++ b/arch/arm/mach-bcm/Kconfig
>>> @@ -14,7 +14,6 @@ config ARCH_BCM_IPROC
>>>   	select HAVE_ARM_SCU if SMP
>>>   	select HAVE_ARM_TWD if SMP
>>>   	select ARM_GLOBAL_TIMER
>>> -	select COMMON_CLK_IPROC
>>>   	select CLKSRC_MMIO
>>>   	select ARCH_REQUIRE_GPIOLIB
>>>   	select ARM_AMBA
>>> diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig
>>> index 46ee475..0352ccf 100644
>>> --- a/drivers/clk/bcm/Kconfig
>>> +++ b/drivers/clk/bcm/Kconfig
>>> @@ -9,8 +9,41 @@ config CLK_BCM_KONA
 >  	  in the BCM281xx and BCM21664 families.
 >
 >  config COMMON_CLK_IPROC
 > -	bool
 > +	bool "Broadcom iProc clock support"
Please leave as is
 > +	depends on ARCH_BCM_IPROC
 >  	depends on COMMON_CLK
 > +	default ARCH_BCM_IPROC
 >  	help
 >  	  Enable common clock framework support for Broadcom SoCs
 >  	  based on the iProc architecture
 > +
 > +if COMMON_CLK_IPROC
Remove all the changes above from patchset - not needed.

>>> +config CLK_BCM_CYGNUS
>>> +	bool "Broadcom Cygnus clock support"
>>> +	depends on COMMON_CLK_IPROC
not needed - keep hidden and do this instead
select COMMON_CLK_IPROC
>>> +	depends on ARCH_BCM_CYGNUS
|| COMPILE_TEST
>>> +	default ARCH_BCM_CYGNUS
>>> +	help
>>> +	  Enable common clock framework support for the Broadcom Cygnus SoC
>>> +
>>> +config CLK_BCM_NSP
>> not needed
>>> +	bool "Broadcom Northstar/Northstar Plus clock support"
>>> +	depends on COMMON_CLK_IPROC
not needed - keep hidden and do this instead
select COMMON_CLK_IPROC
>>> +	depends on ARCH_BCM_5301X || ARCH_BCM_NSP
|| COMPILE_TEST
>>> +	default ARCH_BCM_5301X || ARCH_BCM_NSP
>>> +	help
>>> +	  Enable common clock framework support for the Broadcom Northstar and
>>> +	  Northstar Plus SoCs
>>> +
>>> +config CLK_BCM_NS2
>>> +	bool "Broadcom Northstar 2 clock support"
>>> +	depends on ARM64
|| COMPILE_TEST
>>> +	depends on COMMON_CLK_IPROC
not needed - keep hidden and do this instead
select COMMON_CLK_IPROC
>>> +	default ARCH_BCM_IPROC
>>> +	help
>>> +	  Enable common clock framework support for the Broadcom Northstar 2 SoC
>>> +
>>> +endif
remove endif
>>> diff --git a/drivers/clk/bcm/Makefile b/drivers/clk/bcm/Makefile
>>> index 2d1cbc5..05d5830 100644
>>> --- a/drivers/clk/bcm/Makefile
>>> +++ b/drivers/clk/bcm/Makefile
>>> @@ -3,7 +3,6 @@ obj-$(CONFIG_CLK_BCM_KONA)	+= clk-kona-setup.o
>>>   obj-$(CONFIG_CLK_BCM_KONA)	+= clk-bcm281xx.o
>>>   obj-$(CONFIG_CLK_BCM_KONA)	+= clk-bcm21664.o
>>>   obj-$(CONFIG_COMMON_CLK_IPROC)	+= clk-iproc-armpll.o clk-iproc-pll.o clk-iproc-asiu.o
>>> -obj-$(CONFIG_COMMON_CLK_IPROC)	+= clk-ns2.o
>> yes, change this one
>>> -obj-$(CONFIG_ARCH_BCM_CYGNUS)	+= clk-cygnus.o
>> you can leave this
>>> -obj-$(CONFIG_ARCH_BCM_NSP)	+= clk-nsp.o
>> you can leave this
>>> -obj-$(CONFIG_ARCH_BCM_5301X)	+= clk-nsp.o
>> and this
>>> +obj-$(CONFIG_CLK_BCM_CYGNUS)	+= clk-cygnus.o
>> no
>>> +obj-$(CONFIG_CLK_BCM_NSP)	+= clk-nsp.o
>> no
>>> +obj-$(CONFIG_CLK_BCM_NS2)	+= clk-ns2.o
>> yes needed
>>>
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1257513

FromStephen Boyd <sboyd@codeaurora.org>
Date2015-10-28 01:40 +0100
Message-ID<qomWu-3K3-25@gated-at.bofh.it>
In reply to#1254129
The thread didn't seem to finish, so here's some review.

On 10/22, Jon Mason wrote:
> diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig
> index 46ee475..0352ccf 100644
> --- a/drivers/clk/bcm/Kconfig
> +++ b/drivers/clk/bcm/Kconfig
> @@ -9,8 +9,41 @@ config CLK_BCM_KONA
>  	  in the BCM281xx and BCM21664 families.
>  
>  config COMMON_CLK_IPROC
> -	bool
> +	bool "Broadcom iProc clock support"
> +	depends on ARCH_BCM_IPROC

Plus || COMPILE_TEST?

>  	depends on COMMON_CLK
> +	default ARCH_BCM_IPROC
>  	help
>  	  Enable common clock framework support for Broadcom SoCs
>  	  based on the iProc architecture

It's nice that we're grouping the different platforms under one
umbrella config for the iProc architecture. That way we don't
have to see it unless we're targeting the platform. We should
probably do something similar for kona too in case anyone cares
about code bloat there.

> +
> +if COMMON_CLK_IPROC
> +
> +comment "Broadcom iProc clocks"

Please remove this comment block and drop the depends on
COMMON_CLK_IPROC in the configs below. The if section will keep
things properly indented and avoid duplicating that depends on
statement. Plus the comment pretty much duplicates what is
already in the help for COMMON_CLK_IPROC.

We can make COMMON_CLK_IPROC into a hidden option and introduce a
new grouping config if we really care about that case where the
base support is built but there aren't any users. I'd rather not
care though to simplify things.

> +
> +config CLK_BCM_CYGNUS
> +	bool "Broadcom Cygnus clock support"
> +	depends on COMMON_CLK_IPROC
> +	depends on ARCH_BCM_CYGNUS

Plus || COMPILE_TEST?

> +	default ARCH_BCM_CYGNUS
> +	help
> +	  Enable common clock framework support for the Broadcom Cygnus SoC
> +
> +config CLK_BCM_NSP
> +	bool "Broadcom Northstar/Northstar Plus clock support"
> +	depends on COMMON_CLK_IPROC
> +	depends on ARCH_BCM_5301X || ARCH_BCM_NSP

Plus || COMPILE_TEST?

> +	default ARCH_BCM_5301X || ARCH_BCM_NSP
> +	help
> +	  Enable common clock framework support for the Broadcom Northstar and
> +	  Northstar Plus SoCs
> +
> +config CLK_BCM_NS2
> +	bool "Broadcom Northstar 2 clock support"
> +	depends on ARM64

Plus || COMPILE_TEST?

> +	depends on COMMON_CLK_IPROC
> +	default ARCH_BCM_IPROC
> +	help
> +	  Enable common clock framework support for the Broadcom Northstar 2 SoC
> +
> +endif

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web