Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1254061 > unrolled thread
| Started by | Punit Vara <punitvara@gmail.com> |
|---|---|
| First post | 2015-10-22 20:30 +0200 |
| Last post | 2015-10-22 21:00 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 Punit Vara <punitvara@gmail.com> - 2015-10-22 20:30 +0200
Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-10-22 20:40 +0200
Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 punit vara <punitvara@gmail.com> - 2015-10-22 21:00 +0200
| From | Punit Vara <punitvara@gmail.com> |
|---|---|
| Date | 2015-10-22 20:30 +0200 |
| Subject | [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 |
| Message-ID | <qmsMH-299-31@gated-at.bofh.it> |
This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Also removed empty line suggested by Sergei Signed-off-by: Punit Vara <punitvara@gmail.com> --- drivers/net/wireless/ath/ath5k/eeprom.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/eeprom.c b/drivers/net/wireless/ath/ath5k/eeprom.c index 94d34ee..0c82ea5 100644 --- a/drivers/net/wireless/ath/ath5k/eeprom.c +++ b/drivers/net/wireless/ath/ath5k/eeprom.c @@ -1707,8 +1707,7 @@ ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah) struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom; u32 offset; u16 val; - int ret = 0, i; - + int i; offset = AR5K_EEPROM_CTL(ee->ee_version) + AR5K_EEPROM_N_CTLS(ee->ee_version); @@ -1730,7 +1729,7 @@ ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah) } } - return ret; + return 0; } -- 2.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2015-10-22 20:40 +0200 |
| Subject | Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 |
| Message-ID | <qmsWn-2kA-29@gated-at.bofh.it> |
| In reply to | #1254061 |
Hello.
On 10/22/2015 09:26 PM, Punit Vara wrote:
> This patch is to the ath5k/eeprom.c that fixes up warning caught by
> coccicheck:
>
> -Unneeded variable: "ret". Return "0" on line 1733
>
> Remove unneccesary variable ret created to return zero.
>
> Also removed empty line suggested by Sergei
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/net/wireless/ath/ath5k/eeprom.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/eeprom.c b/drivers/net/wireless/ath/ath5k/eeprom.c
> index 94d34ee..0c82ea5 100644
> --- a/drivers/net/wireless/ath/ath5k/eeprom.c
> +++ b/drivers/net/wireless/ath/ath5k/eeprom.c
> @@ -1707,8 +1707,7 @@ ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah)
> struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom;
> u32 offset;
> u16 val;
> - int ret = 0, i;
> -
No, this one shouldn't have been removed. There should an empty line
between the declarations and the statements.
> + int i;
> offset = AR5K_EEPROM_CTL(ee->ee_version) +
> AR5K_EEPROM_N_CTLS(ee->ee_version);
>
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | punit vara <punitvara@gmail.com> |
|---|---|
| Date | 2015-10-22 21:00 +0200 |
| Subject | Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0 |
| Message-ID | <qmtfJ-2HW-55@gated-at.bofh.it> |
| In reply to | #1254075 |
On Fri, Oct 23, 2015 at 12:05 AM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Hello. > > On 10/22/2015 09:26 PM, Punit Vara wrote: > >> This patch is to the ath5k/eeprom.c that fixes up warning caught by >> coccicheck: >> >> -Unneeded variable: "ret". Return "0" on line 1733 >> >> Remove unneccesary variable ret created to return zero. >> >> Also removed empty line suggested by Sergei >> >> Signed-off-by: Punit Vara <punitvara@gmail.com> >> --- >> drivers/net/wireless/ath/ath5k/eeprom.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath5k/eeprom.c >> b/drivers/net/wireless/ath/ath5k/eeprom.c >> index 94d34ee..0c82ea5 100644 >> --- a/drivers/net/wireless/ath/ath5k/eeprom.c >> +++ b/drivers/net/wireless/ath/ath5k/eeprom.c >> @@ -1707,8 +1707,7 @@ ath5k_eeprom_read_spur_chans(struct ath5k_hw *ah) >> struct ath5k_eeprom_info *ee = &ah->ah_capabilities.cap_eeprom; >> u32 offset; >> u16 val; >> - int ret = 0, i; >> - > > > No, this one shouldn't have been removed. There should an empty line > between the declarations and the statements. > >> + int i; >> offset = AR5K_EEPROM_CTL(ee->ee_version) + >> AR5K_EEPROM_N_CTLS(ee->ee_version); >> > > MBR, Sergei > I have resent patch with update but I cant see it in my mailbox I dont know Why.. Sorry if You are getting mail more time. I am sending final version v5 as last.Please sorry for inconvenience -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web