Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1253498 > unrolled thread

[RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled Namhyung Kim <namhyung@kernel.org> - 2015-10-22 08:30 +0200
    Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order  only if --children is enabled Ingo Molnar <mingo@kernel.org> - 2015-10-22 09:40 +0200
      Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order  only if --children is enabled Namhyung Kim <namhyung@kernel.org> - 2015-10-22 09:40 +0200
        Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order  only if --children is enabled Brendan Gregg <brendan.d.gregg@gmail.com> - 2015-10-22 11:50 +0200
          Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order  only if --children is enabled Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-22 16:10 +0200
        Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order  only if --children is enabled Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-22 14:30 +0200
    [RFC/PATCH RESEND 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled Namhyung Kim <namhyung@kernel.org> - 2015-10-22 09:50 +0200
      Re: [RFC/PATCH RESEND 3/3] perf tools: Defaults to 'caller'  callchain order only if --children is enabled Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-22 20:40 +0200
      [tip:perf/core] perf tools: Defaults to 'caller'   callchain order only if --children is enabled tip-bot for Namhyung Kim <tipbot@zytor.com> - 2015-10-23 10:40 +0200
    Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order  only if --children is enabled Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-22 14:20 +0200
    Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order  only if --children is enabled Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-22 16:20 +0200
      Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order  only if --children is enabled Namhyung Kim <namhyung@kernel.org> - 2015-10-22 16:30 +0200
        Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order  only if --children is enabled Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-22 16:40 +0200
          Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order  only if --children is enabled Namhyung Kim <namhyung@kernel.org> - 2015-10-22 18:00 +0200
            Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order  only if --children is enabled Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-22 18:30 +0200

#1253498 — [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

The caller callchain order is useful with --children option since it can
show 'overview' style output, but other commands which don't use
 --children feature like 'perf script' or even 'perf report/top' without
 --children are better to keep caller order.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Chandler Carruth <chandlerc@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/builtin-report.c | 2 ++
 tools/perf/builtin-top.c    | 3 +++
 tools/perf/util/callchain.c | 2 ++
 tools/perf/util/callchain.h | 1 +
 tools/perf/util/util.c      | 2 +-
 5 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 18a8c52d921e..545c51cef7f7 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -812,6 +812,8 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
 
 	if (report.inverted_callchain)
 		callchain_param.order = ORDER_CALLER;
+	if (symbol_conf.cumulate_callchain && !callchain_param.order_set)
+		callchain_param.order = ORDER_CALLER;
 
 	if (itrace_synth_opts.callchain &&
 	    (int)itrace_synth_opts.callchain_sz > report.max_stack)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 1de381d3f29f..af849b1d7389 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1304,6 +1304,9 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
 		perf_hpp__cancel_cumulate();
 	}
 
+	if (symbol_conf.cumulate_callchain && !callchain_param.order_set)
+		callchain_param.order = ORDER_CALLER;
+
 	symbol_conf.priv_size = sizeof(struct annotation);
 
 	symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL);
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index 842be32899ee..735ad48e1858 100644
--- a/tools/perf/util/callchain.c
+++ b/tools/perf/util/callchain.c
@@ -51,10 +51,12 @@ static int parse_callchain_order(const char *value)
 {
 	if (!strncmp(value, "caller", strlen(value))) {
 		callchain_param.order = ORDER_CALLER;
+		callchain_param.order_set = true;
 		return 0;
 	}
 	if (!strncmp(value, "callee", strlen(value))) {
 		callchain_param.order = ORDER_CALLEE;
+		callchain_param.order_set = true;
 		return 0;
 	}
 	return -1;
diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
index 836d59a001bc..aaf467c9ef2b 100644
--- a/tools/perf/util/callchain.h
+++ b/tools/perf/util/callchain.h
@@ -75,6 +75,7 @@ struct callchain_param {
 	double			min_percent;
 	sort_chain_func_t	sort;
 	enum chain_order	order;
+	bool			order_set;
 	enum chain_key		key;
 	bool			branch_callstack;
 };
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index c1bf9ff210b0..cd12c25e4ea4 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -19,7 +19,7 @@
 struct callchain_param	callchain_param = {
 	.mode	= CHAIN_GRAPH_ABS,
 	.min_percent = 0.5,
-	.order  = ORDER_CALLER,
+	.order  = ORDER_CALLEE,
 	.key	= CCKEY_FUNCTION
 };
 
-- 
2.6.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1253544 — Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

* Namhyung Kim <namhyung@kernel.org> wrote:

> The caller callchain order is useful with --children option since it can
> show 'overview' style output, but other commands which don't use
>  --children feature like 'perf script' or even 'perf report/top' without
>  --children are better to keep caller order.
> 
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
> Cc: Chandler Carruth <chandlerc@gmail.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Stephane Eranian <eranian@google.com>
> Cc: Wang Nan <wangnan0@huawei.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Very nice fixes, thanks!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253545 — Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

Hi Ingo,

On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Namhyung Kim <namhyung@kernel.org> wrote:
>
>> The caller callchain order is useful with --children option since it can
>> show 'overview' style output, but other commands which don't use
>>  --children feature like 'perf script' or even 'perf report/top' without
>>  --children are better to keep caller order.

Oops, there's a typo:  s/caller order/callee order/ :)


>>
>> Cc: Adrian Hunter <adrian.hunter@intel.com>
>> Cc: Borislav Petkov <bp@suse.de>
>> Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
>> Cc: Chandler Carruth <chandlerc@gmail.com>
>> Cc: Frederic Weisbecker <fweisbec@gmail.com>
>> Cc: Stephane Eranian <eranian@google.com>
>> Cc: Wang Nan <wangnan0@huawei.com>
>> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>
> Very nice fixes, thanks!

Thank you!
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253682 — Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

On Thu, Oct 22, 2015 at 12:38 AM, Namhyung Kim <namhyung@kernel.org> wrote:
> Hi Ingo,
>
> On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar <mingo@kernel.org> wrote:
>>
>> * Namhyung Kim <namhyung@kernel.org> wrote:
>>
>>> The caller callchain order is useful with --children option since it can
>>> show 'overview' style output, but other commands which don't use
>>>  --children feature like 'perf script' or even 'perf report/top' without
>>>  --children are better to keep caller order.
>
> Oops, there's a typo:  s/caller order/callee order/ :)

Thanks, I was wondering about that (and I've made that typo myself).
Thanks for the patch!

Brendan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253845 — Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

Em Thu, Oct 22, 2015 at 02:49:11AM -0700, Brendan Gregg escreveu:
> On Thu, Oct 22, 2015 at 12:38 AM, Namhyung Kim <namhyung@kernel.org> wrote:
> > Hi Ingo,
> >
> > On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >>
> >> * Namhyung Kim <namhyung@kernel.org> wrote:
> >>
> >>> The caller callchain order is useful with --children option since it can
> >>> show 'overview' style output, but other commands which don't use
> >>>  --children feature like 'perf script' or even 'perf report/top' without
> >>>  --children are better to keep caller order.
> >
> > Oops, there's a typo:  s/caller order/callee order/ :)
> 
> Thanks, I was wondering about that (and I've made that typo myself).
> Thanks for the patch!

Brendan, can I take that as an Acked-by?
 
> Brendan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253761 — Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

On Thu, Oct 22, 2015 at 04:38:44PM +0900, Namhyung Kim wrote:
> Hi Ingo,
> 
> On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar <mingo@kernel.org> wrote:
> >
> > * Namhyung Kim <namhyung@kernel.org> wrote:
> >
> >> The caller callchain order is useful with --children option since it can
> >> show 'overview' style output, but other commands which don't use
> >>  --children feature like 'perf script' or even 'perf report/top' without
> >>  --children are better to keep caller order.
> 
> Oops, there's a typo:  s/caller order/callee order/ :)

Oops, didn't see that reply.

Thanks!

Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253547 — [RFC/PATCH RESEND 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

The caller callchain order is useful with --children option since it can
show 'overview' style output, but other commands which don't use
 --children feature like 'perf script' or even 'perf report/top' without
 --children are better to keep callee order.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Chandler Carruth <chandlerc@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
fix typo

 tools/perf/builtin-report.c | 2 ++
 tools/perf/builtin-top.c    | 3 +++
 tools/perf/util/callchain.c | 2 ++
 tools/perf/util/callchain.h | 1 +
 tools/perf/util/util.c      | 2 +-
 5 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 18a8c52d921e..545c51cef7f7 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -812,6 +812,8 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
 
 	if (report.inverted_callchain)
 		callchain_param.order = ORDER_CALLER;
+	if (symbol_conf.cumulate_callchain && !callchain_param.order_set)
+		callchain_param.order = ORDER_CALLER;
 
 	if (itrace_synth_opts.callchain &&
 	    (int)itrace_synth_opts.callchain_sz > report.max_stack)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 1de381d3f29f..af849b1d7389 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1304,6 +1304,9 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
 		perf_hpp__cancel_cumulate();
 	}
 
+	if (symbol_conf.cumulate_callchain && !callchain_param.order_set)
+		callchain_param.order = ORDER_CALLER;
+
 	symbol_conf.priv_size = sizeof(struct annotation);
 
 	symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL);
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index 842be32899ee..735ad48e1858 100644
--- a/tools/perf/util/callchain.c
+++ b/tools/perf/util/callchain.c
@@ -51,10 +51,12 @@ static int parse_callchain_order(const char *value)
 {
 	if (!strncmp(value, "caller", strlen(value))) {
 		callchain_param.order = ORDER_CALLER;
+		callchain_param.order_set = true;
 		return 0;
 	}
 	if (!strncmp(value, "callee", strlen(value))) {
 		callchain_param.order = ORDER_CALLEE;
+		callchain_param.order_set = true;
 		return 0;
 	}
 	return -1;
diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
index 836d59a001bc..aaf467c9ef2b 100644
--- a/tools/perf/util/callchain.h
+++ b/tools/perf/util/callchain.h
@@ -75,6 +75,7 @@ struct callchain_param {
 	double			min_percent;
 	sort_chain_func_t	sort;
 	enum chain_order	order;
+	bool			order_set;
 	enum chain_key		key;
 	bool			branch_callstack;
 };
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index c1bf9ff210b0..cd12c25e4ea4 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -19,7 +19,7 @@
 struct callchain_param	callchain_param = {
 	.mode	= CHAIN_GRAPH_ABS,
 	.min_percent = 0.5,
-	.order  = ORDER_CALLER,
+	.order  = ORDER_CALLEE,
 	.key	= CCKEY_FUNCTION
 };
 
-- 
2.6.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1254068 — Re: [RFC/PATCH RESEND 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

Em Thu, Oct 22, 2015 at 04:45:46PM +0900, Namhyung Kim escreveu:
> The caller callchain order is useful with --children option since it can
> show 'overview' style output, but other commands which don't use
>  --children feature like 'perf script' or even 'perf report/top' without
>  --children are better to keep callee order.

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1254388 — [tip:perf/core] perf tools: Defaults to 'caller' callchain order only if --children is enabled

Commit-ID:  792aeafa8ed08e5e18fb66ab93b470f78e619f75
Gitweb:     http://git.kernel.org/tip/792aeafa8ed08e5e18fb66ab93b470f78e619f75
Author:     Namhyung Kim <namhyung@kernel.org>
AuthorDate: Thu, 22 Oct 2015 16:45:46 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Thu, 22 Oct 2015 15:40:11 -0300

perf tools: Defaults to 'caller' callchain order only if --children is enabled

The caller callchain order is useful with --children option since it can
show 'overview' style output, but other commands which don't use
--children feature like 'perf script' or even 'perf report/top' without
--children are better to keep callee order.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Brendan Gregg <brendan.d.gregg@gmail.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Chandler Carruth <chandlerc@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1445499946-29817-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-report.c | 2 ++
 tools/perf/builtin-top.c    | 3 +++
 tools/perf/util/callchain.c | 2 ++
 tools/perf/util/callchain.h | 1 +
 tools/perf/util/util.c      | 2 +-
 5 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 18a8c52..545c51c 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -812,6 +812,8 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
 
 	if (report.inverted_callchain)
 		callchain_param.order = ORDER_CALLER;
+	if (symbol_conf.cumulate_callchain && !callchain_param.order_set)
+		callchain_param.order = ORDER_CALLER;
 
 	if (itrace_synth_opts.callchain &&
 	    (int)itrace_synth_opts.callchain_sz > report.max_stack)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 1de381d..af849b1 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1304,6 +1304,9 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
 		perf_hpp__cancel_cumulate();
 	}
 
+	if (symbol_conf.cumulate_callchain && !callchain_param.order_set)
+		callchain_param.order = ORDER_CALLER;
+
 	symbol_conf.priv_size = sizeof(struct annotation);
 
 	symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL);
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index 842be32..735ad48 100644
--- a/tools/perf/util/callchain.c
+++ b/tools/perf/util/callchain.c
@@ -51,10 +51,12 @@ static int parse_callchain_order(const char *value)
 {
 	if (!strncmp(value, "caller", strlen(value))) {
 		callchain_param.order = ORDER_CALLER;
+		callchain_param.order_set = true;
 		return 0;
 	}
 	if (!strncmp(value, "callee", strlen(value))) {
 		callchain_param.order = ORDER_CALLEE;
+		callchain_param.order_set = true;
 		return 0;
 	}
 	return -1;
diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
index 836d59a..aaf467c 100644
--- a/tools/perf/util/callchain.h
+++ b/tools/perf/util/callchain.h
@@ -75,6 +75,7 @@ struct callchain_param {
 	double			min_percent;
 	sort_chain_func_t	sort;
 	enum chain_order	order;
+	bool			order_set;
 	enum chain_key		key;
 	bool			branch_callstack;
 };
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index c1bf9ff..cd12c25 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -19,7 +19,7 @@
 struct callchain_param	callchain_param = {
 	.mode	= CHAIN_GRAPH_ABS,
 	.min_percent = 0.5,
-	.order  = ORDER_CALLER,
+	.order  = ORDER_CALLEE,
 	.key	= CCKEY_FUNCTION
 };
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253750 — Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

On Thu, Oct 22, 2015 at 03:28:50PM +0900, Namhyung Kim wrote:
> The caller callchain order is useful with --children option since it can
> show 'overview' style output, but other commands which don't use
>  --children feature like 'perf script' or even 'perf report/top' without
>  --children are better to keep caller order.
                                 ^^^^
                                 callee?

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253855 — Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

Em Thu, Oct 22, 2015 at 03:28:50PM +0900, Namhyung Kim escreveu:
> +++ b/tools/perf/util/util.c
> @@ -19,7 +19,7 @@
>  struct callchain_param	callchain_param = {
>  	.mode	= CHAIN_GRAPH_ABS,
>  	.min_percent = 0.5,
> -	.order  = ORDER_CALLER,
> +	.order  = ORDER_CALLEE,
>  	.key	= CCKEY_FUNCTION
>  };

So, this isn't a revert of the previous default change, i.e. previously
we used CHAIN_GRAPH_REL, should we keep CHAIN_GRAPH_ABS + callee?

Also you forgot to fix the docs to mention this new default, I did it
and the resulting patch, still with GRAPH_ABS follows:

From fd2dcde26d09b34fccc3c164d9fc36e662c21fc4 Mon Sep 17 00:00:00 2001
From: Namhyung Kim <namhyung@kernel.org>
Date: Thu, 22 Oct 2015 16:45:46 +0900
Subject: [PATCH 1/1] perf tools: Defaults to 'caller' callchain order only if
 --children is enabled

The caller callchain order is useful with --children option since it can
show 'overview' style output, but other commands which don't use
--children feature like 'perf script' or even 'perf report/top' without
--children are better to keep callee order.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Acked-by: Brendan Gregg <brendan.d.gregg@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Chandler Carruth <chandlerc@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1445499946-29817-1-git-send-email-namhyung@kernel.org
[ Update 'perf report' man page ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Documentation/perf-report.txt | 2 +-
 tools/perf/builtin-report.c              | 2 ++
 tools/perf/builtin-top.c                 | 3 +++
 tools/perf/util/callchain.c              | 2 ++
 tools/perf/util/callchain.h              | 1 +
 tools/perf/util/util.c                   | 2 +-
 6 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
index e4fdeeb51123..4ae1621f1def 100644
--- a/tools/perf/Documentation/perf-report.txt
+++ b/tools/perf/Documentation/perf-report.txt
@@ -192,7 +192,7 @@ OPTIONS
 	when available. Usually more convenient to use --branch-history
 	for this.
 
-	Default: graph,0.5,caller
+	Default: graph,0.5,callee
 
 --children::
 	Accumulate callchain of children to parent entry so that then can
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 3b23b25d1589..a554906a3e03 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -808,6 +808,8 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
 
 	if (report.inverted_callchain)
 		callchain_param.order = ORDER_CALLER;
+	if (symbol_conf.cumulate_callchain && !callchain_param.order_set)
+		callchain_param.order = ORDER_CALLER;
 
 	if (itrace_synth_opts.callchain &&
 	    (int)itrace_synth_opts.callchain_sz > report.max_stack)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 6f641fd68296..be42e6eb6805 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1288,6 +1288,9 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
 		perf_hpp__cancel_cumulate();
 	}
 
+	if (symbol_conf.cumulate_callchain && !callchain_param.order_set)
+		callchain_param.order = ORDER_CALLER;
+
 	symbol_conf.priv_size = sizeof(struct annotation);
 
 	symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL);
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index 773fe13ce627..a8ed80f77ff3 100644
--- a/tools/perf/util/callchain.c
+++ b/tools/perf/util/callchain.c
@@ -51,10 +51,12 @@ static int parse_callchain_order(const char *value)
 {
 	if (!strncmp(value, "caller", strlen(value))) {
 		callchain_param.order = ORDER_CALLER;
+		callchain_param.order_set = true;
 		return 0;
 	}
 	if (!strncmp(value, "callee", strlen(value))) {
 		callchain_param.order = ORDER_CALLEE;
+		callchain_param.order_set = true;
 		return 0;
 	}
 	return -1;
diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
index acee2b3cd801..0e96496567c5 100644
--- a/tools/perf/util/callchain.h
+++ b/tools/perf/util/callchain.h
@@ -63,6 +63,7 @@ struct callchain_param {
 	double			min_percent;
 	sort_chain_func_t	sort;
 	enum chain_order	order;
+	bool			order_set;
 	enum chain_key		key;
 	bool			branch_callstack;
 };
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index c1bf9ff210b0..cd12c25e4ea4 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -19,7 +19,7 @@
 struct callchain_param	callchain_param = {
 	.mode	= CHAIN_GRAPH_ABS,
 	.min_percent = 0.5,
-	.order  = ORDER_CALLER,
+	.order  = ORDER_CALLEE,
 	.key	= CCKEY_FUNCTION
 };
 
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253861 — Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

Hi Arnaldo,

On Thu, Oct 22, 2015 at 11:13 PM, Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
> Em Thu, Oct 22, 2015 at 03:28:50PM +0900, Namhyung Kim escreveu:
>> +++ b/tools/perf/util/util.c
>> @@ -19,7 +19,7 @@
>>  struct callchain_param       callchain_param = {
>>       .mode   = CHAIN_GRAPH_ABS,
>>       .min_percent = 0.5,
>> -     .order  = ORDER_CALLER,
>> +     .order  = ORDER_CALLEE,
>>       .key    = CCKEY_FUNCTION
>>  };
>
> So, this isn't a revert of the previous default change, i.e. previously
> we used CHAIN_GRAPH_REL, should we keep CHAIN_GRAPH_ABS + callee?

Yes, it's not a revert.  I intentionally didn't change the print type.

>
> Also you forgot to fix the docs to mention this new default, I did it
> and the resulting patch, still with GRAPH_ABS follows:

This is not simple.  As Brendan said, --children is default on, so
users will see 'caller' ordering that's why I didn't change the doc.
But I should mention it'll use 'callee' ordering when --no-chlidren.
I'm about to send doc fix patch Ingo requested, so please leave this
patch as is.

Thanks,
Namhyung

>
> From fd2dcde26d09b34fccc3c164d9fc36e662c21fc4 Mon Sep 17 00:00:00 2001
> From: Namhyung Kim <namhyung@kernel.org>
> Date: Thu, 22 Oct 2015 16:45:46 +0900
> Subject: [PATCH 1/1] perf tools: Defaults to 'caller' callchain order only if
>  --children is enabled
>
> The caller callchain order is useful with --children option since it can
> show 'overview' style output, but other commands which don't use
> --children feature like 'perf script' or even 'perf report/top' without
> --children are better to keep callee order.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
> Acked-by: Brendan Gregg <brendan.d.gregg@gmail.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Chandler Carruth <chandlerc@gmail.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Stephane Eranian <eranian@google.com>
> Cc: Wang Nan <wangnan0@huawei.com>
> Link: http://lkml.kernel.org/r/1445499946-29817-1-git-send-email-namhyung@kernel.org
> [ Update 'perf report' man page ]
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/Documentation/perf-report.txt | 2 +-
>  tools/perf/builtin-report.c              | 2 ++
>  tools/perf/builtin-top.c                 | 3 +++
>  tools/perf/util/callchain.c              | 2 ++
>  tools/perf/util/callchain.h              | 1 +
>  tools/perf/util/util.c                   | 2 +-
>  6 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
> index e4fdeeb51123..4ae1621f1def 100644
> --- a/tools/perf/Documentation/perf-report.txt
> +++ b/tools/perf/Documentation/perf-report.txt
> @@ -192,7 +192,7 @@ OPTIONS
>         when available. Usually more convenient to use --branch-history
>         for this.
>
> -       Default: graph,0.5,caller
> +       Default: graph,0.5,callee
>
>  --children::
>         Accumulate callchain of children to parent entry so that then can
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 3b23b25d1589..a554906a3e03 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -808,6 +808,8 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
>
>         if (report.inverted_callchain)
>                 callchain_param.order = ORDER_CALLER;
> +       if (symbol_conf.cumulate_callchain && !callchain_param.order_set)
> +               callchain_param.order = ORDER_CALLER;
>
>         if (itrace_synth_opts.callchain &&
>             (int)itrace_synth_opts.callchain_sz > report.max_stack)
> diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> index 6f641fd68296..be42e6eb6805 100644
> --- a/tools/perf/builtin-top.c
> +++ b/tools/perf/builtin-top.c
> @@ -1288,6 +1288,9 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
>                 perf_hpp__cancel_cumulate();
>         }
>
> +       if (symbol_conf.cumulate_callchain && !callchain_param.order_set)
> +               callchain_param.order = ORDER_CALLER;
> +
>         symbol_conf.priv_size = sizeof(struct annotation);
>
>         symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL);
> diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
> index 773fe13ce627..a8ed80f77ff3 100644
> --- a/tools/perf/util/callchain.c
> +++ b/tools/perf/util/callchain.c
> @@ -51,10 +51,12 @@ static int parse_callchain_order(const char *value)
>  {
>         if (!strncmp(value, "caller", strlen(value))) {
>                 callchain_param.order = ORDER_CALLER;
> +               callchain_param.order_set = true;
>                 return 0;
>         }
>         if (!strncmp(value, "callee", strlen(value))) {
>                 callchain_param.order = ORDER_CALLEE;
> +               callchain_param.order_set = true;
>                 return 0;
>         }
>         return -1;
> diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
> index acee2b3cd801..0e96496567c5 100644
> --- a/tools/perf/util/callchain.h
> +++ b/tools/perf/util/callchain.h
> @@ -63,6 +63,7 @@ struct callchain_param {
>         double                  min_percent;
>         sort_chain_func_t       sort;
>         enum chain_order        order;
> +       bool                    order_set;
>         enum chain_key          key;
>         bool                    branch_callstack;
>  };
> diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
> index c1bf9ff210b0..cd12c25e4ea4 100644
> --- a/tools/perf/util/util.c
> +++ b/tools/perf/util/util.c
> @@ -19,7 +19,7 @@
>  struct callchain_param callchain_param = {
>         .mode   = CHAIN_GRAPH_ABS,
>         .min_percent = 0.5,
> -       .order  = ORDER_CALLER,
> +       .order  = ORDER_CALLEE,
>         .key    = CCKEY_FUNCTION
>  };
>
> --
> 2.1.0
>



-- 
Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253877 — Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

Em Thu, Oct 22, 2015 at 11:22:40PM +0900, Namhyung Kim escreveu:
> On Thu, Oct 22, 2015 at 11:13 PM, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > Em Thu, Oct 22, 2015 at 03:28:50PM +0900, Namhyung Kim escreveu:
> >> +++ b/tools/perf/util/util.c
> >> @@ -19,7 +19,7 @@
> >>  struct callchain_param       callchain_param = {
> >>       .mode   = CHAIN_GRAPH_ABS,
> >> -     .order  = ORDER_CALLER,
> >> +     .order  = ORDER_CALLEE,

> > So, this isn't a revert of the previous default change, i.e. previously
> > we used CHAIN_GRAPH_REL, should we keep CHAIN_GRAPH_ABS + callee?
 
> Yes, it's not a revert.  I intentionally didn't change the print type.

Ok, its just that I don't recall seeing the part of the discussion about
keeping the change from REL to ABS.
 
> > Also you forgot to fix the docs to mention this new default, I did it
> > and the resulting patch, still with GRAPH_ABS follows:
 
> This is not simple.  As Brendan said, --children is default on, so
> users will see 'caller' ordering that's why I didn't change the doc.

Ok, but the default as it stands after applying this patch is "graph,
calee", so the docs should be changed to reflect that, yes, its not just
that, we need to tell, in the --children doc, that it defaults to
"caller".

Will we also flip the default to --no-children? I would advocate that,
together with showing a info box telling the user about this change and
how to ask for it, including instructions on how to do that via
~/.perfconfig.

> But I should mention it'll use 'callee' ordering when --no-chlidren.
> I'm about to send doc fix patch Ingo requested, so please leave this
> patch as is.

Ok, its just that I thought you was already asleep and was wanting to
make progress on this 8-)

Will wait for your patches and instead try to fix the annotation bug
that leads 'perf report --tui -S some_symbol_name' to exit without
printing anything, that Ingo reported, only happens in --tui, because
--stdio doesn't collects annotation info...

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253938 — Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

On Thu, Oct 22, 2015 at 11:37 PM, Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
> Em Thu, Oct 22, 2015 at 11:22:40PM +0900, Namhyung Kim escreveu:
>> On Thu, Oct 22, 2015 at 11:13 PM, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>> > Em Thu, Oct 22, 2015 at 03:28:50PM +0900, Namhyung Kim escreveu:
>> >> +++ b/tools/perf/util/util.c
>> >> @@ -19,7 +19,7 @@
>> >>  struct callchain_param       callchain_param = {
>> >>       .mode   = CHAIN_GRAPH_ABS,
>> >> -     .order  = ORDER_CALLER,
>> >> +     .order  = ORDER_CALLEE,
>
>> > So, this isn't a revert of the previous default change, i.e. previously
>> > we used CHAIN_GRAPH_REL, should we keep CHAIN_GRAPH_ABS + callee?
>
>> Yes, it's not a revert.  I intentionally didn't change the print type.
>
> Ok, its just that I don't recall seeing the part of the discussion about
> keeping the change from REL to ABS.
>
>> > Also you forgot to fix the docs to mention this new default, I did it
>> > and the resulting patch, still with GRAPH_ABS follows:
>
>> This is not simple.  As Brendan said, --children is default on, so
>> users will see 'caller' ordering that's why I didn't change the doc.
>
> Ok, but the default as it stands after applying this patch is "graph,
> calee", so the docs should be changed to reflect that, yes, its not just
> that, we need to tell, in the --children doc, that it defaults to
> "caller".
>
> Will we also flip the default to --no-children? I would advocate that,
> together with showing a info box telling the user about this change and
> how to ask for it, including instructions on how to do that via
> ~/.perfconfig.

Not sure.  It seems too late to do it. ;-)

>
>> But I should mention it'll use 'callee' ordering when --no-chlidren.
>> I'm about to send doc fix patch Ingo requested, so please leave this
>> patch as is.
>
> Ok, its just that I thought you was already asleep and was wanting to
> make progress on this 8-)

Yeah, it's late.  I'll go to bed soon.. :)

>
> Will wait for your patches and instead try to fix the annotation bug
> that leads 'perf report --tui -S some_symbol_name' to exit without
> printing anything, that Ingo reported, only happens in --tui, because
> --stdio doesn't collects annotation info...

I guess -S option works only for symbols that have self overhead..

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253968 — Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

Em Fri, Oct 23, 2015 at 12:51:01AM +0900, Namhyung Kim escreveu:
> On Thu, Oct 22, 2015 at 11:37 PM, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > Will we also flip the default to --no-children? I would advocate that,
> > together with showing a info box telling the user about this change and
> > how to ask for it, including instructions on how to do that via
> > ~/.perfconfig.
 
> Not sure.  It seems too late to do it. ;-)

Heh, well, at least a info box, to show just once, telling where to read
about --children mode, and how to disable it, I'll probably cook this
up.
 
> >> But I should mention it'll use 'callee' ordering when --no-chlidren.
> >> I'm about to send doc fix patch Ingo requested, so please leave this
> >> patch as is.

> > Ok, its just that I thought you was already asleep and was wanting to
> > make progress on this 8-)
 
> Yeah, it's late.  I'll go to bed soon.. :)

:-)
 
> > Will wait for your patches and instead try to fix the annotation bug
> > that leads 'perf report --tui -S some_symbol_name' to exit without
> > printing anything, that Ingo reported, only happens in --tui, because
> > --stdio doesn't collects annotation info...
 
> I guess -S option works only for symbols that have self overhead..

Sure, say:

  # perf record -a sleep 1
  [ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 0.171 MB perf.data (33 samples) ]
  # perf script | head -3
    perf 15174 [000] 52772.188928:  1 cycles:pp: ffffffff8105f4b8 native_write_msr_safe (/lib/modules/4.2.0/build/vmlinux)
    perf 15174 [000] 52772.188934:  1 cycles:pp: ffffffff8105f4b8 native_write_msr_safe (/lib/modules/4.2.0/build/vmlinux)
   swapper     0 [001] 52772.188971:  1 cycles:pp: ffffffff8105f4b8 native_write_msr_safe (/lib/modules/4.2.0/build/vmlinux)
  # perf report -S native_write_msr_safe
  # time perf report -S native_write_msr_safe

  real	0m0.023s
  user	0m0.019s
  sys	0m0.004s
  #

I.e. 'perf report -S symbol_that_has_self_overhead' doesn't work in --tui mode,
works in --stdio mode:

  # perf report --stdio -S native_write_msr_safe  | grep %
    59.61%  swapper  [kernel.vmlinux]
     0.17%  sleep    [kernel.vmlinux]
     0.00%  perf     [kernel.vmlinux]
  # 

Somehow we're calling symbol__inc_addr_samples() with a sample that is outside
that symbol, it returns ERANGE and we exit early, not emitting any message.

That happens only in --tui mode, --stdio doesn't call any annotation routine,
since it is not integrated with 'perf annotate' because it is not interactive.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web