Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1252310 > unrolled thread

[PATCH 00/19] staging/wilc1000 cleanups

Started byArnd Bergmann <arnd@arndb.de>
First post2015-10-21 00:50 +0200
Last post2015-10-27 08:20 +0100
Articles 5 on this page of 25 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 00/19] staging/wilc1000 cleanups Arnd Bergmann <arnd@arndb.de> - 2015-10-21 00:50 +0200
    [PATCH 17/19] staging/wilc1000: pass hif operations through initialization Arnd Bergmann <arnd@arndb.de> - 2015-10-21 00:50 +0200
    [PATCH 19/19] [RFC] staging/wilc1000: use more regular probing Arnd Bergmann <arnd@arndb.de> - 2015-10-21 00:50 +0200
    [PATCH 08/19] staging/wilc1000: move wilc_wlan_inp_t into struct wilc Arnd Bergmann <arnd@arndb.de> - 2015-10-21 01:00 +0200
    [PATCH 10/19] staging/wilc1000: unify device pointer Arnd Bergmann <arnd@arndb.de> - 2015-10-21 01:00 +0200
    [PATCH 04/19] staging/wilc1000: move extern declarations to headers Arnd Bergmann <arnd@arndb.de> - 2015-10-21 01:00 +0200
    [PATCH 05/19] staging/wilc1000: use NO_SECURITY instead of NO_ENCRYPT Arnd Bergmann <arnd@arndb.de> - 2015-10-21 01:00 +0200
    [PATCH 16/19] staging/wilc1000: remove WILC_SDIO/WILC_SPI macros Arnd Bergmann <arnd@arndb.de> - 2015-10-21 01:00 +0200
    [PATCH 14/19] staging/wilc1000: get rid of WILC_SDIO_IRQ_GPIO Arnd Bergmann <arnd@arndb.de> - 2015-10-21 01:00 +0200
    [PATCH 01/19] staging/wilc1000: remove unused functions Arnd Bergmann <arnd@arndb.de> - 2015-10-21 01:00 +0200
      Re: [PATCH 01/19] staging/wilc1000: remove unused functions Greg KH <gregkh@linuxfoundation.org> - 2015-10-25 09:30 +0100
    [PATCH 06/19] staging/wilc1000: avoid static definitions in header Arnd Bergmann <arnd@arndb.de> - 2015-10-21 01:00 +0200
    [PATCH 09/19] staging/wilc1000: move init/exit functions to driver files Arnd Bergmann <arnd@arndb.de> - 2015-10-21 01:00 +0200
    [PATCH 07/19] staging/wilc1000: remove linux_wlan_{device_power,device_detection} Arnd Bergmann <arnd@arndb.de> - 2015-10-21 01:00 +0200
    [PATCH 13/19] staging/wilc1000: move COMPLEMENT_BOOT code to linux_wlan_sdio.c Arnd Bergmann <arnd@arndb.de> - 2015-10-21 01:00 +0200
    [PATCH 18/19] staging/wilc1000: split out bus specific modules Arnd Bergmann <arnd@arndb.de> - 2015-10-21 01:00 +0200
      [PATCH] fixup! staging/wilc1000: split out bus specific modules Arnd Bergmann <arnd@arndb.de> - 2015-10-21 16:30 +0200
    [PATCH 02/19] staging/wilc1000: make symbols static if possible Arnd Bergmann <arnd@arndb.de> - 2015-10-21 01:00 +0200
    [PATCH 12/19] staging/wilc1000: use device pointer for phy creation Arnd Bergmann <arnd@arndb.de> - 2015-10-21 01:00 +0200
    Re: [PATCH 00/19] staging/wilc1000 cleanups glen lee <glen.lee@atmel.com> - 2015-10-21 12:10 +0200
      Re: [PATCH 00/19] staging/wilc1000 cleanups Arnd Bergmann <arnd@arndb.de> - 2015-10-21 13:00 +0200
      Re: [PATCH 00/19] staging/wilc1000 cleanups Arnd Bergmann <arnd@arndb.de> - 2015-10-22 14:30 +0200
        Re: [PATCH 00/19] staging/wilc1000 cleanups glen lee <glen.lee@atmel.com> - 2015-10-23 03:40 +0200
          Re: [PATCH 00/19] staging/wilc1000 cleanups Tony Cho <tony.cho@atmel.com> - 2015-10-23 10:00 +0200
            Re: [PATCH 00/19] staging/wilc1000 cleanups Tony Cho <tony.cho@atmel.com> - 2015-10-27 08:20 +0100

Page 2 of 2 — ← Prev page 1 [2]

#1252718

FromArnd Bergmann <arnd@arndb.de>
Date2015-10-21 13:00 +0200
Message-ID<qlZhE-FD-15@gated-at.bofh.it>
In reply to#1252659
On Wednesday 21 October 2015 19:06:52 glen lee wrote:
> Hi arnd,
> 
> Thanks for the all the patches. 
> About the patch ( use proper naming for global symbols ),
> We are planning to use this driver not only for wilc1000 but also for
> other atmel wireless driver. I'd appreciate if you could use wl instead of wilc1000.

Hmm, while I see that 'wilc1000' is too specific here, using just 'wl' might be
a little too general. The same namespace is used by drivers/mtd/ubi/wl.c,
drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c, and a number of local
identifiers in other drivers.

Would 'wilc' work as a prefix for all devices you are interested in here?

> And the global variable g_linux_wlan will be placed in netdevice private data
> and finally it will be removed. I already posted some of those patches.

Ok, so we need to coordinate a bit here. My patches also go in that direction
and remove the global variables from linux_wlan_sdio.c and linux_wlan_spi.c,
but did not remove the one from linux_wlan.c, because doing that depends on
the last [RFC] patch in my series, and I felt I had spent enough time on it
at that point ;-)

Would you be ok with taking my patches and rebasing them on top of yours
with the changes you want,  or do you need help from me with that?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253762

FromArnd Bergmann <arnd@arndb.de>
Date2015-10-22 14:30 +0200
Message-ID<qmnaj-2ka-29@gated-at.bofh.it>
In reply to#1252659
On Wednesday 21 October 2015 19:06:52 glen lee wrote:
> Hi arnd,
> 
> Thanks for the all the patches. 
> About the patch ( use proper naming for global symbols ),
> We are planning to use this driver not only for wilc1000 but also for
> other atmel wireless driver. I'd appreciate if you could use wl instead of wilc1000.
> 
> And the global variable g_linux_wlan will be placed in netdevice private data
> and finally it will be removed. I already posted some of those patches.

I couldn't find the patches anywhere, but I've updated my series now
to rename the symbols to wilc_* and to remove most but not all references to
g_linux_wlan (or wilc_dev after my rename). Do you want me to post those
so you can integrate them, or should I have a look at what you sent first
(please send me a copy then).

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1254275

Fromglen lee <glen.lee@atmel.com>
Date2015-10-23 03:40 +0200
Message-ID<qmzuN-3nz-11@gated-at.bofh.it>
In reply to#1253762
On 2015년 10월 22일 21:23, Arnd Bergmann wrote:
> On Wednesday 21 October 2015 19:06:52 glen lee wrote:
>> Hi arnd,
>>
>> Thanks for the all the patches.
>> About the patch ( use proper naming for global symbols ),
>> We are planning to use this driver not only for wilc1000 but also for
>> other atmel wireless driver. I'd appreciate if you could use wl instead of wilc1000.
>>
>> And the global variable g_linux_wlan will be placed in netdevice private data
>> and finally it will be removed. I already posted some of those patches.
> I couldn't find the patches anywhere, but I've updated my series now
> to rename the symbols to wilc_* and to remove most but not all references to
> g_linux_wlan (or wilc_dev after my rename). Do you want me to post those
> so you can integrate them, or should I have a look at what you sent first
> (please send me a copy then).

Hi arnd,

I have tested with all the patches you have posted but it does not works. firmware start timed out
in the function wilc1000_start_firmware.
I also have tested with all the patched without last one, [RFC] one, but it shows
Segmentation fault when insmod driver.
For now, I can't rebase the patches. I'd appreciate if you could help us.

The title of my first patch is,
[PATCH 01/13] staging: wilc1000: add wilc to netdev private data structure
and also refer to [PATCH 00/12] WILC1000 V2 for the g_linux_wlan
( The patches posted by tony.cho@atmel.com )

By the way, deleting feature COMPLEMENT_BOOT patch already posted but not yet accepted.

Thank you.
Glen.

> 	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1254377

FromTony Cho <tony.cho@atmel.com>
Date2015-10-23 10:00 +0200
Message-ID<qmFqy-3rU-5@gated-at.bofh.it>
In reply to#1254275
Hi Arnd,
First of all, I would like to say "thank you" for your efforts and 
contributions.
We are updating the driver because new revision came up and making new 
patches
to make it stable and elegant as Linux driver. In these days, we are 
sending big changes
while testing such patches and also doing updates at once.

As you did, we are scheduled to provide the patches making device tree 
and delete all of platform
dependencies as you removed WILC_SDIO_IRQ_GPIO as well as other things. 
So, I would like to
discuss with you for your series of patch.

In this time, I think it's important to make the driver to be compiled 
even if the link problem
happens as you reported. So, how about deleting all of SPI related files 
from source tree and
even from Kconfig for the time being because new bus driver will come or 
revert
the Kconfig and then can we expect the best patch in the near feature?

I respect your efforts and patches, so your opinion is very important to me.

Thanks,
Tony.

On 2015년 10월 23일 10:37, glen lee wrote:
>
> On 2015년 10월 22일 21:23, Arnd Bergmann wrote:
>> On Wednesday 21 October 2015 19:06:52 glen lee wrote:
>>> Hi arnd,
>>>
>>> Thanks for the all the patches.
>>> About the patch ( use proper naming for global symbols ),
>>> We are planning to use this driver not only for wilc1000 but also for
>>> other atmel wireless driver. I'd appreciate if you could use wl 
>>> instead of wilc1000.
>>>
>>> And the global variable g_linux_wlan will be placed in netdevice 
>>> private data
>>> and finally it will be removed. I already posted some of those patches.
>> I couldn't find the patches anywhere, but I've updated my series now
>> to rename the symbols to wilc_* and to remove most but not all 
>> references to
>> g_linux_wlan (or wilc_dev after my rename). Do you want me to post those
>> so you can integrate them, or should I have a look at what you sent 
>> first
>> (please send me a copy then).
>
> Hi arnd,
>
> I have tested with all the patches you have posted but it does not 
> works. firmware start timed out
> in the function wilc1000_start_firmware.
> I also have tested with all the patched without last one, [RFC] one, 
> but it shows
> Segmentation fault when insmod driver.
> For now, I can't rebase the patches. I'd appreciate if you could help us.
>
> The title of my first patch is,
> [PATCH 01/13] staging: wilc1000: add wilc to netdev private data 
> structure
> and also refer to [PATCH 00/12] WILC1000 V2 for the g_linux_wlan
> ( The patches posted by tony.cho@atmel.com )
>
> By the way, deleting feature COMPLEMENT_BOOT patch already posted but 
> not yet accepted.
>
> Thank you.
> Glen.
>
>>     Arnd
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1256518

FromTony Cho <tony.cho@atmel.com>
Date2015-10-27 08:20 +0100
Message-ID<qo6I2-2i5-5@gated-at.bofh.it>
In reply to#1254377
Hi Arnd,
I expect your opinion but I would like to make the patch to revert
the commit bcc43a4b5ed75285aeacf2cf8d9b96d6379fb429 if you don't mind
because the WILC1000 in staging still has compile errors.
Then, we had better make patch for your concerns.

I always appreciate your review and contribution.

Thanks,
Tony.

On 2015년 10월 23일 16:51, Tony Cho wrote:
> Hi Arnd,
> First of all, I would like to say "thank you" for your efforts and 
> contributions.
> We are updating the driver because new revision came up and making new 
> patches
> to make it stable and elegant as Linux driver. In these days, we are 
> sending big changes
> while testing such patches and also doing updates at once.
>
> As you did, we are scheduled to provide the patches making device tree 
> and delete all of platform
> dependencies as you removed WILC_SDIO_IRQ_GPIO as well as other 
> things. So, I would like to
> discuss with you for your series of patch.
>
> In this time, I think it's important to make the driver to be compiled 
> even if the link problem
> happens as you reported. So, how about deleting all of SPI related 
> files from source tree and
> even from Kconfig for the time being because new bus driver will come 
> or revert
> the Kconfig and then can we expect the best patch in the near feature?
>
> I respect your efforts and patches, so your opinion is very important 
> to me.
>
> Thanks,
> Tony.
>
> On 2015년 10월 23일 10:37, glen lee wrote:
>>
>> On 2015년 10월 22일 21:23, Arnd Bergmann wrote:
>>> On Wednesday 21 October 2015 19:06:52 glen lee wrote:
>>>> Hi arnd,
>>>>
>>>> Thanks for the all the patches.
>>>> About the patch ( use proper naming for global symbols ),
>>>> We are planning to use this driver not only for wilc1000 but also for
>>>> other atmel wireless driver. I'd appreciate if you could use wl 
>>>> instead of wilc1000.
>>>>
>>>> And the global variable g_linux_wlan will be placed in netdevice 
>>>> private data
>>>> and finally it will be removed. I already posted some of those 
>>>> patches.
>>> I couldn't find the patches anywhere, but I've updated my series now
>>> to rename the symbols to wilc_* and to remove most but not all 
>>> references to
>>> g_linux_wlan (or wilc_dev after my rename). Do you want me to post 
>>> those
>>> so you can integrate them, or should I have a look at what you sent 
>>> first
>>> (please send me a copy then).
>>
>> Hi arnd,
>>
>> I have tested with all the patches you have posted but it does not 
>> works. firmware start timed out
>> in the function wilc1000_start_firmware.
>> I also have tested with all the patched without last one, [RFC] one, 
>> but it shows
>> Segmentation fault when insmod driver.
>> For now, I can't rebase the patches. I'd appreciate if you could help 
>> us.
>>
>> The title of my first patch is,
>> [PATCH 01/13] staging: wilc1000: add wilc to netdev private data 
>> structure
>> and also refer to [PATCH 00/12] WILC1000 V2 for the g_linux_wlan
>> ( The patches posted by tony.cho@atmel.com )
>>
>> By the way, deleting feature COMPLEMENT_BOOT patch already posted but 
>> not yet accepted.
>>
>> Thank you.
>> Glen.
>>
>>>     Arnd
>>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web