Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1252130 > unrolled thread

[PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2

Started byFranklin S Cooper Jr <fcooper@ti.com>
First post2015-10-21 00:00 +0200
Last post2015-10-22 15:40 +0200
Articles 5 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2 Franklin S Cooper Jr <fcooper@ti.com> - 2015-10-21 00:00 +0200
    Re: [PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2 santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-10-21 03:30 +0200
    Re: [PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2 Ulf Hansson <ulf.hansson@linaro.org> - 2015-10-22 11:40 +0200
      Re: [PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2 Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-10-22 13:00 +0200
        Re: [PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2 Ulf Hansson <ulf.hansson@linaro.org> - 2015-10-22 15:40 +0200

#1252130 — [PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2

FromFranklin S Cooper Jr <fcooper@ti.com>
Date2015-10-21 00:00 +0200
Subject[PATCH 2/5] mmc: omap_hsmmc: Enable omap_hsmmc for Keystone 2
Message-ID<qlN6Q-825-39@gated-at.bofh.it>
From: Lokesh Vutla <lokeshvutla@ti.com>

Enable omap_hsmmc for Keystone 2 architecture which reuses the HSMMC
IP found on OMAP platforms.

Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
---
 drivers/mmc/host/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 8a1e349..2ccec71 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -366,7 +366,7 @@ config MMC_OMAP
 config MMC_OMAP_HS
 	tristate "TI OMAP High Speed Multimedia Card Interface support"
 	depends on HAS_DMA
-	depends on ARCH_OMAP2PLUS || COMPILE_TEST
+	depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || COMPILE_TEST
 	help
 	  This selects the TI OMAP High Speed Multimedia card Interface.
 	  If you have an omap2plus board with a Multimedia Card slot,
-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1252401

Fromsantosh shilimkar <santosh.shilimkar@oracle.com>
Date2015-10-21 03:30 +0200
Message-ID<qlQo1-4vM-5@gated-at.bofh.it>
In reply to#1252130
On 10/20/2015 2:50 PM, Franklin S Cooper Jr wrote:
> From: Lokesh Vutla <lokeshvutla@ti.com>
>
> Enable omap_hsmmc for Keystone 2 architecture which reuses the HSMMC
> IP found on OMAP platforms.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>   drivers/mmc/host/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 8a1e349..2ccec71 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -366,7 +366,7 @@ config MMC_OMAP
>   config MMC_OMAP_HS
>   	tristate "TI OMAP High Speed Multimedia Card Interface support"
>   	depends on HAS_DMA
> -	depends on ARCH_OMAP2PLUS || COMPILE_TEST
> +	depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || COMPILE_TEST
>   	help
>   	  This selects the TI OMAP High Speed Multimedia card Interface.
>   	  If you have an omap2plus board with a Multimedia Card slot,
>
Please send this to MMC tree.

Regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1253658

FromUlf Hansson <ulf.hansson@linaro.org>
Date2015-10-22 11:40 +0200
Message-ID<qmkvM-6IE-47@gated-at.bofh.it>
In reply to#1252130
On 20 October 2015 at 23:50, Franklin S Cooper Jr <fcooper@ti.com> wrote:
>
> From: Lokesh Vutla <lokeshvutla@ti.com>
>
> Enable omap_hsmmc for Keystone 2 architecture which reuses the HSMMC
> IP found on OMAP platforms.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>  drivers/mmc/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 8a1e349..2ccec71 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -366,7 +366,7 @@ config MMC_OMAP
>  config MMC_OMAP_HS
>         tristate "TI OMAP High Speed Multimedia Card Interface support"
>         depends on HAS_DMA
> -       depends on ARCH_OMAP2PLUS || COMPILE_TEST
> +       depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || COMPILE_TEST

How about:
"depends on ARM || COMPILE_TEST"

>
>         help
>           This selects the TI OMAP High Speed Multimedia card Interface.
>           If you have an omap2plus board with a Multimedia Card slot,
> --
> 2.6.1
>

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1253711

FromRussell King - ARM Linux <linux@arm.linux.org.uk>
Date2015-10-22 13:00 +0200
Message-ID<qmlLc-6U-13@gated-at.bofh.it>
In reply to#1253658
On Thu, Oct 22, 2015 at 11:28:55AM +0200, Ulf Hansson wrote:
> On 20 October 2015 at 23:50, Franklin S Cooper Jr <fcooper@ti.com> wrote:
> >
> > From: Lokesh Vutla <lokeshvutla@ti.com>
> >
> > Enable omap_hsmmc for Keystone 2 architecture which reuses the HSMMC
> > IP found on OMAP platforms.
> >
> > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> > ---
> >  drivers/mmc/host/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 8a1e349..2ccec71 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -366,7 +366,7 @@ config MMC_OMAP
> >  config MMC_OMAP_HS
> >         tristate "TI OMAP High Speed Multimedia Card Interface support"
> >         depends on HAS_DMA
> > -       depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > +       depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || COMPILE_TEST
> 
> How about:
> "depends on ARM || COMPILE_TEST"

I'd much prefer the former actually - it's already hard enough to use
the config tools with the kernel due to the number of silly options
being presented, there's no need to make it worse.

In fact, I'd like to see more of the former (provided done sensibly)
to reduce the number of config options seen for configurations to cut
down on the shere noise of useless options.  For example, if I've
decided I don't want to support TI OMAP platforms, then I shouldn't
be offered the TI OMAP MMC driver.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1253821

FromUlf Hansson <ulf.hansson@linaro.org>
Date2015-10-22 15:40 +0200
Message-ID<qmog4-3Ro-31@gated-at.bofh.it>
In reply to#1253711
On 22 October 2015 at 12:58, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Thu, Oct 22, 2015 at 11:28:55AM +0200, Ulf Hansson wrote:
>> On 20 October 2015 at 23:50, Franklin S Cooper Jr <fcooper@ti.com> wrote:
>> >
>> > From: Lokesh Vutla <lokeshvutla@ti.com>
>> >
>> > Enable omap_hsmmc for Keystone 2 architecture which reuses the HSMMC
>> > IP found on OMAP platforms.
>> >
>> > Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>> > ---
>> >  drivers/mmc/host/Kconfig | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>> > index 8a1e349..2ccec71 100644
>> > --- a/drivers/mmc/host/Kconfig
>> > +++ b/drivers/mmc/host/Kconfig
>> > @@ -366,7 +366,7 @@ config MMC_OMAP
>> >  config MMC_OMAP_HS
>> >         tristate "TI OMAP High Speed Multimedia Card Interface support"
>> >         depends on HAS_DMA
>> > -       depends on ARCH_OMAP2PLUS || COMPILE_TEST
>> > +       depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || COMPILE_TEST
>>
>> How about:
>> "depends on ARM || COMPILE_TEST"
>
> I'd much prefer the former actually - it's already hard enough to use
> the config tools with the kernel due to the number of silly options
> being presented, there's no need to make it worse.
>
> In fact, I'd like to see more of the former (provided done sensibly)
> to reduce the number of config options seen for configurations to cut
> down on the shere noise of useless options.  For example, if I've
> decided I don't want to support TI OMAP platforms, then I shouldn't
> be offered the TI OMAP MMC driver.

Okay, fair enough and I don't have any strong opinions around this.

I queued up the patch for next, thanks!

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web