Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1253337 > unrolled thread

[PATCH] serial: msm_serial: Make config tristate

Started byStephen Boyd <sboyd@codeaurora.org>
First post2015-10-22 01:10 +0200
Last post2015-10-22 16:00 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] serial: msm_serial: Make config tristate Stephen Boyd <sboyd@codeaurora.org> - 2015-10-22 01:10 +0200
    Re: [PATCH] serial: msm_serial: Make config tristate Andy Gross <agross@codeaurora.org> - 2015-10-22 05:00 +0200
    Re: [PATCH] serial: msm_serial: Make config tristate Paul Gortmaker <paul.gortmaker@windriver.com> - 2015-10-22 16:00 +0200

#1253337 — [PATCH] serial: msm_serial: Make config tristate

FromStephen Boyd <sboyd@codeaurora.org>
Date2015-10-22 01:10 +0200
Subject[PATCH] serial: msm_serial: Make config tristate
Message-ID<qmaG5-F3-13@gated-at.bofh.it>
This driver works as a module, so mark it as a tristate config
instead of a bool.

Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---

I tested this with a busybox ramdisk that modprobes msm_serial and
then runs a getty on ttyMSM0. This patch should supersede Paul's earlier
patch that removes the module code from this driver.

 drivers/tty/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 1aec4404062d..e4f35da3de27 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1044,7 +1044,7 @@ config SERIAL_SGI_IOC3
 	  say Y or M.  Otherwise, say N.
 
 config SERIAL_MSM
-	bool "MSM on-chip serial port support"
+	tristate "MSM on-chip serial port support"
 	depends on ARCH_QCOM
 	select SERIAL_CORE
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1253444

FromAndy Gross <agross@codeaurora.org>
Date2015-10-22 05:00 +0200
Message-ID<qmegF-5TG-13@gated-at.bofh.it>
In reply to#1253337
On Wed, Oct 21, 2015 at 04:05:23PM -0700, Stephen Boyd wrote:
> This driver works as a module, so mark it as a tristate config
> instead of a bool.
> 
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> 
> I tested this with a busybox ramdisk that modprobes msm_serial and
> then runs a getty on ttyMSM0. This patch should supersede Paul's earlier
> patch that removes the module code from this driver.
> 
>  drivers/tty/serial/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Andy Gross <agross@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1253839

FromPaul Gortmaker <paul.gortmaker@windriver.com>
Date2015-10-22 16:00 +0200
Message-ID<qmozp-4eU-27@gated-at.bofh.it>
In reply to#1253337
[[PATCH] serial: msm_serial: Make config tristate] On 21/10/2015 (Wed 16:05) Stephen Boyd wrote:

> This driver works as a module, so mark it as a tristate config
> instead of a bool.
> 
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> 
> I tested this with a busybox ramdisk that modprobes msm_serial and
> then runs a getty on ttyMSM0. This patch should supersede Paul's earlier
> patch that removes the module code from this driver.

Thanks, I'll drop my patch for this driver.

Paul.
--

> 
>  drivers/tty/serial/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 1aec4404062d..e4f35da3de27 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1044,7 +1044,7 @@ config SERIAL_SGI_IOC3
>  	  say Y or M.  Otherwise, say N.
>  
>  config SERIAL_MSM
> -	bool "MSM on-chip serial port support"
> +	tristate "MSM on-chip serial port support"
>  	depends on ARCH_QCOM
>  	select SERIAL_CORE
>  
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web