Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1254980 > unrolled thread
| Started by | Punit Vara <punitvara@gmail.com> |
|---|---|
| First post | 2015-10-23 22:10 +0200 |
| Last post | 2015-10-25 10:20 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] Fix warning by coccicheck Punit Vara <punitvara@gmail.com> - 2015-10-23 22:10 +0200
[PATCH 1/2] scsi: lpfc: Use kzalloc instead of kmalloc Punit Vara <punitvara@gmail.com> - 2015-10-23 22:10 +0200
Re: [PATCH 1/2] scsi: lpfc: Use kzalloc instead of kmalloc "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com> - 2015-10-24 01:30 +0200
Re: [PATCH 1/2] scsi: lpfc: Use kzalloc instead of kmalloc punit vara <punitvara@gmail.com> - 2015-10-25 10:20 +0100
| From | Punit Vara <punitvara@gmail.com> |
|---|---|
| Date | 2015-10-23 22:10 +0200 |
| Subject | [PATCH 0/2] Fix warning by coccicheck |
| Message-ID | <qmQOZ-3lW-5@gated-at.bofh.it> |
Punit Vara (2): scsi: lpfc: Use kzalloc instead of kmalloc scsi: remove useless casting value returned by kmalloc to structure drivers/scsi/hpsa.c | 3 +-- drivers/scsi/lpfc/lpfc_els.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) -- 2.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Punit Vara <punitvara@gmail.com> |
|---|---|
| Date | 2015-10-23 22:10 +0200 |
| Subject | [PATCH 1/2] scsi: lpfc: Use kzalloc instead of kmalloc |
| Message-ID | <qmQP0-3lW-37@gated-at.bofh.it> |
| In reply to | #1254980 |
This patch is to the lpfc_els.c which resolves following warning
reported by coccicheck:
WARNING: kzalloc should be used for rdp_context, instead of
kmalloc/memset
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/scsi/lpfc/lpfc_els.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index 36bf58b..422c800 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -4990,7 +4990,7 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
if (RDP_NPORT_ID_SIZE !=
be32_to_cpu(rdp_req->nport_id_desc.length))
goto rjt_logerr;
- rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
+ rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
if (!rdp_context) {
rjt_err = LSRJT_UNABLE_TPC;
goto error;
--
2.5.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com> |
|---|---|
| Date | 2015-10-24 01:30 +0200 |
| Subject | Re: [PATCH 1/2] scsi: lpfc: Use kzalloc instead of kmalloc |
| Message-ID | <qmTWy-7MT-31@gated-at.bofh.it> |
| In reply to | #1254987 |
Hi Punit,
Aren't you missing the removal of the memset() as part of this conversion?
-matt
> On Oct 23, 2015, at 3:03 PM, Punit Vara <punitvara@gmail.com> wrote:
>
> This patch is to the lpfc_els.c which resolves following warning
> reported by coccicheck:
>
> WARNING: kzalloc should be used for rdp_context, instead of
> kmalloc/memset
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_els.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index 36bf58b..422c800 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -4990,7 +4990,7 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
> if (RDP_NPORT_ID_SIZE !=
> be32_to_cpu(rdp_req->nport_id_desc.length))
> goto rjt_logerr;
> - rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> + rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> if (!rdp_context) {
> rjt_err = LSRJT_UNABLE_TPC;
> goto error;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | punit vara <punitvara@gmail.com> |
|---|---|
| Date | 2015-10-25 10:20 +0100 |
| Subject | Re: [PATCH 1/2] scsi: lpfc: Use kzalloc instead of kmalloc |
| Message-ID | <qnpD4-t9-9@gated-at.bofh.it> |
| In reply to | #1255055 |
On Sat, Oct 24, 2015 at 4:56 AM, Matthew R. Ochs
<mrochs@linux.vnet.ibm.com> wrote:
> Hi Punit,
>
> Aren't you missing the removal of the memset() as part of this conversion?
>
>
> -matt
>
>> On Oct 23, 2015, at 3:03 PM, Punit Vara <punitvara@gmail.com> wrote:
>>
>> This patch is to the lpfc_els.c which resolves following warning
>> reported by coccicheck:
>>
>> WARNING: kzalloc should be used for rdp_context, instead of
>> kmalloc/memset
>>
>> Signed-off-by: Punit Vara <punitvara@gmail.com>
>> ---
>> drivers/scsi/lpfc/lpfc_els.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
>> index 36bf58b..422c800 100644
>> --- a/drivers/scsi/lpfc/lpfc_els.c
>> +++ b/drivers/scsi/lpfc/lpfc_els.c
>> @@ -4990,7 +4990,7 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
>> if (RDP_NPORT_ID_SIZE !=
>> be32_to_cpu(rdp_req->nport_id_desc.length))
>> goto rjt_logerr;
>> - rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
>> + rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
>> if (!rdp_context) {
>> rjt_err = LSRJT_UNABLE_TPC;
>> goto error;
>
Thanks for reviewing my patches.
Can I send more patches ? my all previous patches already reviewed by
you . Should I wait to apply this patch to tree or i can send new
patch set ? Please suggest me sir.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web