Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1254601 > unrolled thread

[PATCH 1/2] serial: 8250_ingenic: delete redundant "select SERIAL_EARLYCON"

Started byMasahiro Yamada <yamada.masahiro@socionext.com>
First post2015-10-23 15:40 +0200
Last post2015-10-27 15:20 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] serial: 8250_ingenic: delete redundant "select SERIAL_EARLYCON" Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-10-23 15:40 +0200
    [PATCH 2/2] serial: 8250_ingenic: allow to be independent of SERIAL_8250_CONSOLE Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-10-23 15:40 +0200
      Re: [PATCH 2/2] serial: 8250_ingenic: allow to be independent of  SERIAL_8250_CONSOLE Peter Hurley <peter@hurleysoftware.com> - 2015-10-27 15:30 +0100
    Re: [PATCH 1/2] serial: 8250_ingenic: delete redundant "select  SERIAL_EARLYCON" Peter Hurley <peter@hurleysoftware.com> - 2015-10-27 15:20 +0100

#1254601 — [PATCH 1/2] serial: 8250_ingenic: delete redundant "select SERIAL_EARLYCON"

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2015-10-23 15:40 +0200
Subject[PATCH 1/2] serial: 8250_ingenic: delete redundant "select SERIAL_EARLYCON"
Message-ID<qmKJA-2QB-9@gated-at.bofh.it>
SERIAL_8250_INGENIC depends on SERIAL_8250_CONSOLE, which already
selects SERIAL_EARLYCON.

This line is redundant.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/tty/serial/8250/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index e1de118..960da95 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -362,7 +362,6 @@ config SERIAL_8250_INGENIC
 	bool "Support for Ingenic SoC serial ports"
 	depends on SERIAL_8250_CONSOLE && OF_FLATTREE
 	select LIBFDT
-	select SERIAL_EARLYCON
 	help
 	  If you have a system using an Ingenic SoC and wish to make use of
 	  its UARTs, say Y to this option. If unsure, say N.
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1254602 — [PATCH 2/2] serial: 8250_ingenic: allow to be independent of SERIAL_8250_CONSOLE

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2015-10-23 15:40 +0200
Subject[PATCH 2/2] serial: 8250_ingenic: allow to be independent of SERIAL_8250_CONSOLE
Message-ID<qmKJA-2QB-13@gated-at.bofh.it>
In reply to#1254601
This UART driver should not depend on the console.  They should be
orthogonal.

Surround the earlycon code with CONFIG_SERIAL_EARLYCON conditional
and rip off "depends on SERIAL_8250_CONSOLE".

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

Currently, SERIAL_8250_FSL also depends on SERIAL_8250_CONSOLE,
but I doubt its necessity.


 drivers/tty/serial/8250/8250_ingenic.c | 2 ++
 drivers/tty/serial/8250/Kconfig        | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_ingenic.c b/drivers/tty/serial/8250/8250_ingenic.c
index 7c1e4be..44633ee 100644
--- a/drivers/tty/serial/8250/8250_ingenic.c
+++ b/drivers/tty/serial/8250/8250_ingenic.c
@@ -34,6 +34,7 @@ struct ingenic_uart_data {
 
 #define UART_FCR_UME	BIT(4)
 
+#ifdef CONFIG_SERIAL_EARLYCON
 static struct earlycon_device *early_device;
 
 static uint8_t __init early_in(struct uart_port *port, int offset)
@@ -126,6 +127,7 @@ OF_EARLYCON_DECLARE(jz4775_uart, "ingenic,jz4775-uart",
 EARLYCON_DECLARE(jz4780_uart, ingenic_early_console_setup);
 OF_EARLYCON_DECLARE(jz4780_uart, "ingenic,jz4780-uart",
 		    ingenic_early_console_setup);
+#endif /* CONFIG_SERIAL_EARLYCON */
 
 static void ingenic_uart_serial_out(struct uart_port *p, int offset, int value)
 {
diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index 960da95..6f62934 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -360,7 +360,7 @@ config SERIAL_8250_UNIPHIER
 
 config SERIAL_8250_INGENIC
 	bool "Support for Ingenic SoC serial ports"
-	depends on SERIAL_8250_CONSOLE && OF_FLATTREE
+	depends on OF_FLATTREE
 	select LIBFDT
 	help
 	  If you have a system using an Ingenic SoC and wish to make use of
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1256775 — Re: [PATCH 2/2] serial: 8250_ingenic: allow to be independent of SERIAL_8250_CONSOLE

FromPeter Hurley <peter@hurleysoftware.com>
Date2015-10-27 15:30 +0100
SubjectRe: [PATCH 2/2] serial: 8250_ingenic: allow to be independent of SERIAL_8250_CONSOLE
Message-ID<qodqa-6gG-3@gated-at.bofh.it>
In reply to#1254602
On 10/23/2015 09:31 AM, Masahiro Yamada wrote:
> This UART driver should not depend on the console.  They should be
> orthogonal.
> 
> Surround the earlycon code with CONFIG_SERIAL_EARLYCON conditional
> and rip off "depends on SERIAL_8250_CONSOLE".

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>

PS - While reviewing this patch, I noticed another problem in the
Ingenic earlycon; see below.

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
> Currently, SERIAL_8250_FSL also depends on SERIAL_8250_CONSOLE,
> but I doubt its necessity.
> 
> 
>  drivers/tty/serial/8250/8250_ingenic.c | 2 ++
>  drivers/tty/serial/8250/Kconfig        | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_ingenic.c b/drivers/tty/serial/8250/8250_ingenic.c
> index 7c1e4be..44633ee 100644
> --- a/drivers/tty/serial/8250/8250_ingenic.c
> +++ b/drivers/tty/serial/8250/8250_ingenic.c
> @@ -34,6 +34,7 @@ struct ingenic_uart_data {
>  
>  #define UART_FCR_UME	BIT(4)
>  
> +#ifdef CONFIG_SERIAL_EARLYCON


>  static struct earlycon_device *early_device;

The earlycon setup should not be saving the earlycon_device *;
see early_8250serial_write() for how to deref from console to port.

Regards,
Peter Hurley


>  static uint8_t __init early_in(struct uart_port *port, int offset)
> @@ -126,6 +127,7 @@ OF_EARLYCON_DECLARE(jz4775_uart, "ingenic,jz4775-uart",
>  EARLYCON_DECLARE(jz4780_uart, ingenic_early_console_setup);
>  OF_EARLYCON_DECLARE(jz4780_uart, "ingenic,jz4780-uart",
>  		    ingenic_early_console_setup);
> +#endif /* CONFIG_SERIAL_EARLYCON */
>  
>  static void ingenic_uart_serial_out(struct uart_port *p, int offset, int value)
>  {
> diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
> index 960da95..6f62934 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -360,7 +360,7 @@ config SERIAL_8250_UNIPHIER
>  
>  config SERIAL_8250_INGENIC
>  	bool "Support for Ingenic SoC serial ports"
> -	depends on SERIAL_8250_CONSOLE && OF_FLATTREE
> +	depends on OF_FLATTREE
>  	select LIBFDT
>  	help
>  	  If you have a system using an Ingenic SoC and wish to make use of
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1256771 — Re: [PATCH 1/2] serial: 8250_ingenic: delete redundant "select SERIAL_EARLYCON"

FromPeter Hurley <peter@hurleysoftware.com>
Date2015-10-27 15:20 +0100
SubjectRe: [PATCH 1/2] serial: 8250_ingenic: delete redundant "select SERIAL_EARLYCON"
Message-ID<qodgt-6dy-9@gated-at.bofh.it>
In reply to#1254601
On 10/23/2015 09:31 AM, Masahiro Yamada wrote:
> SERIAL_8250_INGENIC depends on SERIAL_8250_CONSOLE, which already
> selects SERIAL_EARLYCON.
> 
> This line is redundant.

Reviewed-by: Peter Hurley <peter@hurleysoftware.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web