Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1253128 > unrolled thread
| Started by | Punit Vara <punitvara@gmail.com> |
|---|---|
| First post | 2015-10-21 21:10 +0200 |
| Last post | 2015-10-22 09:00 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate Punit Vara <punitvara@gmail.com> - 2015-10-21 21:10 +0200
[PATCH v2 08/15] net: wireless: simplify return flow for usb_control_msg Punit Vara <punitvara@gmail.com> - 2015-10-21 21:10 +0200
Re: [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-10-22 00:10 +0200
Re: [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate Eliad Peller <eliad@wizery.com> - 2015-10-22 09:00 +0200
| From | Punit Vara <punitvara@gmail.com> |
|---|---|
| Date | 2015-10-21 21:10 +0200 |
| Subject | [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate |
| Message-ID | <qm6VP-3Hx-13@gated-at.bofh.it> |
Remove int ret suggested by kbuild test robot
This patch is to the wlcore/acx.c file that fixes up warning
reported by coccicheck:
WARNING: end returns can be simplified if negative or 0 value
Prefer direct return value instead of writing 2-3 more sentence.
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/net/wireless/ti/wlcore/acx.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/acx.c b/drivers/net/wireless/ti/wlcore/acx.c
index f28fa3b..6b566d9 100644
--- a/drivers/net/wireless/ti/wlcore/acx.c
+++ b/drivers/net/wireless/ti/wlcore/acx.c
@@ -158,16 +158,11 @@ out:
int wl1271_acx_mem_map(struct wl1271 *wl, struct acx_header *mem_map,
size_t len)
{
- int ret;
wl1271_debug(DEBUG_ACX, "acx mem map");
- ret = wl1271_cmd_interrogate(wl, ACX_MEM_MAP, mem_map,
+ return wl1271_cmd_interrogate(wl, ACX_MEM_MAP, mem_map,
sizeof(struct acx_header), len);
- if (ret < 0)
- return ret;
-
- return 0;
}
int wl1271_acx_rx_msdu_life_time(struct wl1271 *wl)
--
2.5.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Punit Vara <punitvara@gmail.com> |
|---|---|
| Date | 2015-10-21 21:10 +0200 |
| Subject | [PATCH v2 08/15] net: wireless: simplify return flow for usb_control_msg |
| Message-ID | <qm6VQ-3Hx-29@gated-at.bofh.it> |
| In reply to | #1253128 |
remove int ret suggested by Jiri Slaby
This patch is to the at76c50x-usb.c file that fixes up warning
reported by coccicheck:
WARNING: end returns can be simplified if negative or 0 value
Prefer direct return value instead of writing 2-3 more sentence.
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/net/wireless/at76c50x-usb.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/wireless/at76c50x-usb.c b/drivers/net/wireless/at76c50x-usb.c
index dab2513..b4aa062 100644
--- a/drivers/net/wireless/at76c50x-usb.c
+++ b/drivers/net/wireless/at76c50x-usb.c
@@ -543,14 +543,10 @@ static void at76_ledtrig_tx_activity(void)
static int at76_remap(struct usb_device *udev)
{
- int ret;
- ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
+ return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
USB_TYPE_VENDOR | USB_DIR_OUT |
USB_RECIP_INTERFACE, 0, 0, NULL, 0,
USB_CTRL_GET_TIMEOUT);
- if (ret < 0)
- return ret;
- return 0;
}
static int at76_get_op_mode(struct usb_device *udev)
--
2.5.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2015-10-22 00:10 +0200 |
| Subject | Re: [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate |
| Message-ID | <qm9K3-7MW-11@gated-at.bofh.it> |
| In reply to | #1253128 |
On 10/21/2015 10:07 PM, Punit Vara wrote:
> Remove int ret suggested by kbuild test robot
>
> This patch is to the wlcore/acx.c file that fixes up warning
> reported by coccicheck:
>
> WARNING: end returns can be simplified if negative or 0 value
>
> Prefer direct return value instead of writing 2-3 more sentence.
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/net/wireless/ti/wlcore/acx.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/ti/wlcore/acx.c b/drivers/net/wireless/ti/wlcore/acx.c
> index f28fa3b..6b566d9 100644
> --- a/drivers/net/wireless/ti/wlcore/acx.c
> +++ b/drivers/net/wireless/ti/wlcore/acx.c
> @@ -158,16 +158,11 @@ out:
> int wl1271_acx_mem_map(struct wl1271 *wl, struct acx_header *mem_map,
> size_t len)
> {
> - int ret;
>
You now need to kill this empty line as well.
[...]
MBR, Sergei+
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Eliad Peller <eliad@wizery.com> |
|---|---|
| Date | 2015-10-22 09:00 +0200 |
| Subject | Re: [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate |
| Message-ID | <qmi0V-2WT-1@gated-at.bofh.it> |
| In reply to | #1253128 |
On Wed, Oct 21, 2015 at 10:07 PM, Punit Vara <punitvara@gmail.com> wrote:
> Remove int ret suggested by kbuild test robot
>
> This patch is to the wlcore/acx.c file that fixes up warning
> reported by coccicheck:
>
> WARNING: end returns can be simplified if negative or 0 value
>
> Prefer direct return value instead of writing 2-3 more sentence.
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/net/wireless/ti/wlcore/acx.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/ti/wlcore/acx.c b/drivers/net/wireless/ti/wlcore/acx.c
> index f28fa3b..6b566d9 100644
> --- a/drivers/net/wireless/ti/wlcore/acx.c
> +++ b/drivers/net/wireless/ti/wlcore/acx.c
> @@ -158,16 +158,11 @@ out:
> int wl1271_acx_mem_map(struct wl1271 *wl, struct acx_header *mem_map,
> size_t len)
> {
> - int ret;
>
> wl1271_debug(DEBUG_ACX, "acx mem map");
>
> - ret = wl1271_cmd_interrogate(wl, ACX_MEM_MAP, mem_map,
> + return wl1271_cmd_interrogate(wl, ACX_MEM_MAP, mem_map,
> sizeof(struct acx_header), len);
> - if (ret < 0)
> - return ret;
> -
> - return 0;
> }
>
this changes the return value in case of positive values.
have you verified it can't happen / won't affect the code flow?
i'm not sure you really want to blindly patch it...
Eliad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web