Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1252482 > unrolled thread
| Started by | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| First post | 2015-10-21 08:00 +0200 |
| Last post | 2015-10-26 09:20 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
linux-next: build failure after merge of the akpm-current tree Stephen Rothwell <sfr@canb.auug.org.au> - 2015-10-21 08:00 +0200
Re: linux-next: build failure after merge of the akpm-current tree Michael Ellerman <mpe@ellerman.id.au> - 2015-10-21 12:10 +0200
Re: linux-next: build failure after merge of the akpm-current tree "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2015-10-21 16:20 +0200
Re: linux-next: build failure after merge of the akpm-current tree Laurent Dufour <ldufour@linux.vnet.ibm.com> - 2015-10-26 09:20 +0100
| From | Stephen Rothwell <sfr@canb.auug.org.au> |
|---|---|
| Date | 2015-10-21 08:00 +0200 |
| Subject | linux-next: build failure after merge of the akpm-current tree |
| Message-ID | <qlUBk-2gl-9@gated-at.bofh.it> |
Hi Andrew,
After merging the akpm-current tree, today's linux-next build (powerpc
allnoconfig) failed like this:
In file included from arch/powerpc/include/asm/thread_info.h:34:0,
from include/linux/thread_info.h:54,
from include/asm-generic/preempt.h:4,
from arch/powerpc/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:59,
from include/linux/spinlock.h:50,
from include/linux/seqlock.h:35,
from include/linux/time.h:5,
from include/uapi/linux/timex.h:56,
from include/linux/timex.h:56,
from include/linux/sched.h:19,
from arch/powerpc/kernel/asm-offsets.c:17:
arch/powerpc/include/asm/pgtable.h: In function 'pte_pgprot':
arch/powerpc/include/asm/pte-common.h:104:18: error: '_PAGE_SOFT_DIRTY' undeclared (first use in this function)
_PAGE_EXEC | _PAGE_SOFT_DIRTY)
^
arch/powerpc/include/asm/page.h:359:22: note: in definition of macro '__pgprot'
#define __pgprot(x) (x)
^
arch/powerpc/include/asm/pgtable.h:39:79: note: in expansion of macro 'PAGE_PROT_BITS'
static inline pgprot_t pte_pgprot(pte_t pte) { return __pgprot(pte_val(pte) & PAGE_PROT_BITS); }
^
arch/powerpc/include/asm/pte-common.h:104:18: note: each undeclared identifier is reported only once for each function it appears in
_PAGE_EXEC | _PAGE_SOFT_DIRTY)
^
arch/powerpc/include/asm/page.h:359:22: note: in definition of macro '__pgprot'
#define __pgprot(x) (x)
^
arch/powerpc/include/asm/pgtable.h:39:79: note: in expansion of macro 'PAGE_PROT_BITS'
static inline pgprot_t pte_pgprot(pte_t pte) { return __pgprot(pte_val(pte) & PAGE_PROT_BITS); }
^
In file included from include/linux/mm.h:55:0,
from include/linux/mman.h:4,
from arch/powerpc/kernel/asm-offsets.c:22:
arch/powerpc/include/asm/pgtable.h: In function 'pte_mkdirty':
arch/powerpc/include/asm/pgtable.h:130:32: error: '_PAGE_SOFT_DIRTY' undeclared (first use in this function)
pte_val(pte) |= _PAGE_DIRTY | _PAGE_SOFT_DIRTY; return pte; }
^
In file included from arch/powerpc/include/asm/pgtable-ppc32.h:123:0,
from arch/powerpc/include/asm/pgtable.h:19,
from include/linux/mm.h:55,
from include/linux/mman.h:4,
from arch/powerpc/kernel/asm-offsets.c:22:
arch/powerpc/include/asm/pgtable.h: In function 'pte_modify':
arch/powerpc/include/asm/pte-common.h:97:38: error: '_PAGE_SOFT_DIRTY' undeclared (first use in this function)
_PAGE_ACCESSED | _PAGE_SPECIAL | _PAGE_SOFT_DIRTY)
^
arch/powerpc/include/asm/pgtable.h:139:33: note: in expansion of macro '_PAGE_CHG_MASK'
pte_val(pte) = (pte_val(pte) & _PAGE_CHG_MASK) | pgprot_val(newprot);
^
./Kbuild:80: recipe for target 'arch/powerpc/kernel/asm-offsets.s' failed
Caused by commit
8bd232790748 ("powerpc/mm: add page soft dirty tracking")
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Date | 2015-10-21 12:10 +0200 |
| Message-ID | <qlYvi-8ai-51@gated-at.bofh.it> |
| In reply to | #1252482 |
On Wed, 2015-10-21 at 16:59 +1100, Stephen Rothwell wrote: > Hi Andrew, > > After merging the akpm-current tree, today's linux-next build (powerpc > allnoconfig) failed like this: > arch/powerpc/include/asm/pgtable.h: In function 'pte_pgprot': > arch/powerpc/include/asm/pte-common.h:104:18: error: '_PAGE_SOFT_DIRTY' undeclared (first use in this function) > _PAGE_EXEC | _PAGE_SOFT_DIRTY) That's probably my fault, Andrew asked if we wanted to take it via powerpc and I thought "yes" but never actually replied. Andrew can you drop this one and we'll take it via powerpc? It might take a while to actually hit the powerpc tree because Aneesh is doing a lot of work in this area at the moment. Without knowing the code, the change logs make me think we probably also need to take the other two from Laurent for it to make sense. Laurent? cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> |
|---|---|
| Date | 2015-10-21 16:20 +0200 |
| Message-ID | <qm2pc-5pS-5@gated-at.bofh.it> |
| In reply to | #1252664 |
Michael Ellerman <mpe@ellerman.id.au> writes: > On Wed, 2015-10-21 at 16:59 +1100, Stephen Rothwell wrote: >> Hi Andrew, >> >> After merging the akpm-current tree, today's linux-next build (powerpc >> allnoconfig) failed like this: > >> arch/powerpc/include/asm/pgtable.h: In function 'pte_pgprot': >> arch/powerpc/include/asm/pte-common.h:104:18: error: '_PAGE_SOFT_DIRTY' undeclared (first use in this function) >> _PAGE_EXEC | _PAGE_SOFT_DIRTY) > > That's probably my fault, Andrew asked if we wanted to take it via powerpc and > I thought "yes" but never actually replied. > > Andrew can you drop this one and we'll take it via powerpc? > > It might take a while to actually hit the powerpc tree because Aneesh is doing > a lot of work in this area at the moment. > > Without knowing the code, the change logs make me think we probably also need > to take the other two from Laurent for it to make sense. Laurent? > The other two patches are fixes for core soft dirty tracking code and they are valid even without powerpc bits. So they can go via -mm tree -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Laurent Dufour <ldufour@linux.vnet.ibm.com> |
|---|---|
| Date | 2015-10-26 09:20 +0100 |
| Message-ID | <qnLay-5QZ-27@gated-at.bofh.it> |
| In reply to | #1252664 |
On 21/10/2015 12:08, Michael Ellerman wrote: > On Wed, 2015-10-21 at 16:59 +1100, Stephen Rothwell wrote: >> Hi Andrew, >> >> After merging the akpm-current tree, today's linux-next build (powerpc >> allnoconfig) failed like this: > >> arch/powerpc/include/asm/pgtable.h: In function 'pte_pgprot': >> arch/powerpc/include/asm/pte-common.h:104:18: error: '_PAGE_SOFT_DIRTY' undeclared (first use in this function) >> _PAGE_EXEC | _PAGE_SOFT_DIRTY) > > That's probably my fault, Andrew asked if we wanted to take it via powerpc and > I thought "yes" but never actually replied. > > Andrew can you drop this one and we'll take it via powerpc? > > It might take a while to actually hit the powerpc tree because Aneesh is doing > a lot of work in this area at the moment. > > Without knowing the code, the change logs make me think we probably also need > to take the other two from Laurent for it to make sense. Laurent? Hi Michael, Sorry for the late answer, I was off a couple of days last week. The other two patches are not specific to powerpc and, as mentioned by Aneesh, they can go to the -mm tree. Cheers, Laurent. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web