Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1252717 > unrolled thread

[PATCH] leds: leds-wrap.c: Use devm_led_classdev_register

Back to article view | Back to linux.kernel

Contents

  [PATCH] leds: leds-wrap.c: Use devm_led_classdev_register Fida Mohammad <fmthoker@gmail.com> - 2015-10-21 13:00 +0200
    Re: [PATCH] leds: leds-wrap.c: Use devm_led_classdev_register Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-10-22 09:20 +0200

#1252717 — [PATCH] leds: leds-wrap.c: Use devm_led_classdev_register

Use of resource managed function devm_led_classdev_register to
make initialization path simpler. Also removed redundant remove
function.

Signed-off-by: Fida Mohammad <fmthoker@gmail.com>
---
 drivers/leds/leds-wrap.c | 26 ++++----------------------
 1 file changed, 4 insertions(+), 22 deletions(-)

diff --git a/drivers/leds/leds-wrap.c b/drivers/leds/leds-wrap.c
index 1ba3def..c5ff4b4 100644
--- a/drivers/leds/leds-wrap.c
+++ b/drivers/leds/leds-wrap.c
@@ -76,39 +76,21 @@ static int wrap_led_probe(struct platform_device *pdev)
 {
 	int ret;
 
-	ret = led_classdev_register(&pdev->dev, &wrap_power_led);
+	ret = devm_led_classdev_register(&pdev->dev, &wrap_power_led);
 	if (ret < 0)
 		return ret;
 
-	ret = led_classdev_register(&pdev->dev, &wrap_error_led);
+	ret = devm_led_classdev_register(&pdev->dev, &wrap_error_led);
 	if (ret < 0)
-		goto err1;
-
-	ret = led_classdev_register(&pdev->dev, &wrap_extra_led);
-	if (ret < 0)
-		goto err2;
-
-	return ret;
+		return ret;
 
-err2:
-	led_classdev_unregister(&wrap_error_led);
-err1:
-	led_classdev_unregister(&wrap_power_led);
+	return  devm_led_classdev_register(&pdev->dev, &wrap_extra_led);
 
-	return ret;
 }
 
-static int wrap_led_remove(struct platform_device *pdev)
-{
-	led_classdev_unregister(&wrap_power_led);
-	led_classdev_unregister(&wrap_error_led);
-	led_classdev_unregister(&wrap_extra_led);
-	return 0;
-}
 
 static struct platform_driver wrap_led_driver = {
 	.probe		= wrap_led_probe,
-	.remove		= wrap_led_remove,
 	.driver		= {
 		.name		= DRVNAME,
 	},
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1253534

Hi Fida,

On 10/21/2015 12:58 PM, Fida Mohammad wrote:
> Use of resource managed function devm_led_classdev_register to
> make initialization path simpler. Also removed redundant remove
> function.
>
> Signed-off-by: Fida Mohammad <fmthoker@gmail.com>
> ---
>   drivers/leds/leds-wrap.c | 26 ++++----------------------
>   1 file changed, 4 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/leds/leds-wrap.c b/drivers/leds/leds-wrap.c
> index 1ba3def..c5ff4b4 100644
> --- a/drivers/leds/leds-wrap.c
> +++ b/drivers/leds/leds-wrap.c
> @@ -76,39 +76,21 @@ static int wrap_led_probe(struct platform_device *pdev)
>   {
>   	int ret;
>
> -	ret = led_classdev_register(&pdev->dev, &wrap_power_led);
> +	ret = devm_led_classdev_register(&pdev->dev, &wrap_power_led);
>   	if (ret < 0)
>   		return ret;
>
> -	ret = led_classdev_register(&pdev->dev, &wrap_error_led);
> +	ret = devm_led_classdev_register(&pdev->dev, &wrap_error_led);
>   	if (ret < 0)
> -		goto err1;
> -
> -	ret = led_classdev_register(&pdev->dev, &wrap_extra_led);
> -	if (ret < 0)
> -		goto err2;
> -
> -	return ret;
> +		return ret;
>
> -err2:
> -	led_classdev_unregister(&wrap_error_led);
> -err1:
> -	led_classdev_unregister(&wrap_power_led);
> +	return  devm_led_classdev_register(&pdev->dev, &wrap_extra_led);
>

Removed two extra empty lines end applied, thanks.

> -	return ret;
>   }
>
> -static int wrap_led_remove(struct platform_device *pdev)
> -{
> -	led_classdev_unregister(&wrap_power_led);
> -	led_classdev_unregister(&wrap_error_led);
> -	led_classdev_unregister(&wrap_extra_led);
> -	return 0;
> -}
>
>   static struct platform_driver wrap_led_driver = {
>   	.probe		= wrap_led_probe,
> -	.remove		= wrap_led_remove,
>   	.driver		= {
>   		.name		= DRVNAME,
>   	},
>


-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web