Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1252433 > unrolled thread

[PATCH v1 1/2] dt-bindings: Sync the dts to this document

Started byCaesar Wang <wxt@rock-chips.com>
First post2015-10-21 04:50 +0200
Last post2015-10-22 03:30 +0200
Articles 7 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v1 1/2] dt-bindings: Sync the dts to this document Caesar Wang <wxt@rock-chips.com> - 2015-10-21 04:50 +0200
    Re: [PATCH v1 1/2] dt-bindings: Sync the dts to this document Doug Anderson <dianders@chromium.org> - 2015-10-21 06:30 +0200
    Re: [PATCH v1 1/2] dt-bindings: Sync the dts to this document Rob Herring <robh+dt@kernel.org> - 2015-10-21 17:20 +0200
      Re: [PATCH v1 1/2] dt-bindings: Sync the dts to this document Caesar Wang <caesar.upstream@gmail.com> - 2015-10-21 17:50 +0200
        Re: [PATCH v1 1/2] dt-bindings: Sync the dts to this document Rob Herring <robh+dt@kernel.org> - 2015-10-21 18:50 +0200
          Re: [PATCH v1 1/2] dt-bindings: Sync the dts to this document Rob Herring <robh+dt@kernel.org> - 2015-10-22 03:20 +0200
            Re: [PATCH v1 1/2] dt-bindings: Sync the dts to this document Caesar Wang <caesar.upstream@gmail.com> - 2015-10-22 03:30 +0200

#1252433 — [PATCH v1 1/2] dt-bindings: Sync the dts to this document

FromCaesar Wang <wxt@rock-chips.com>
Date2015-10-21 04:50 +0200
Subject[PATCH v1 1/2] dt-bindings: Sync the dts to this document
Message-ID<qlRDr-6mE-5@gated-at.bofh.it>
Add the OTP gpio state, we need switch the pin to gpio state
before the TSADC controller is reset.

Signed-off-by: Caesar Wang <wxt@rock-chips.com>
---

Changes in v1:
  - As the Doug comments, add the 'init' property to sync document.

 Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
index ef802de..28e84f7 100644
--- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
@@ -27,8 +27,9 @@ tsadc: tsadc@ff280000 {
 	clock-names = "tsadc", "apb_pclk";
 	resets = <&cru SRST_TSADC>;
 	reset-names = "tsadc-apb";
-	pinctrl-names = "default";
-	pinctrl-0 = <&otp_out>;
+	pinctrl-names = "init", "default";
+	pinctrl-0 = <&otp_gpio>;
+	pinctrl-1 = <&otp_out>;
 	#thermal-sensor-cells = <1>;
 	rockchip,hw-tshut-temp = <95000>;
 	rockchip,hw-tshut-mode = <0>;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1252458

FromDoug Anderson <dianders@chromium.org>
Date2015-10-21 06:30 +0200
Message-ID<qlTce-ll-3@gated-at.bofh.it>
In reply to#1252433
Hi,

On Tue, Oct 20, 2015 at 7:42 PM, Caesar Wang <wxt@rock-chips.com> wrote:
> Add the OTP gpio state, we need switch the pin to gpio state
> before the TSADC controller is reset.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> ---
>
> Changes in v1:
>   - As the Doug comments, add the 'init' property to sync document.
>
>  Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Seems reasonable to me.  I do wonder if we need to make it more
obvious that things might glitch if the "init" pinctrl isn't there?
...probably not too critical unless others think it needs to be more
obvious...

Reviewed-by: Douglas Anderson <dianders@chromium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1252949

FromRob Herring <robh+dt@kernel.org>
Date2015-10-21 17:20 +0200
Message-ID<qm3lh-6Rp-53@gated-at.bofh.it>
In reply to#1252433
On Tue, Oct 20, 2015 at 9:42 PM, Caesar Wang <wxt@rock-chips.com> wrote:
> Add the OTP gpio state, we need switch the pin to gpio state
> before the TSADC controller is reset.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> ---
>
> Changes in v1:
>   - As the Doug comments, add the 'init' property to sync document.
>
>  Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> index ef802de..28e84f7 100644
> --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> @@ -27,8 +27,9 @@ tsadc: tsadc@ff280000 {
>         clock-names = "tsadc", "apb_pclk";
>         resets = <&cru SRST_TSADC>;
>         reset-names = "tsadc-apb";
> -       pinctrl-names = "default";
> -       pinctrl-0 = <&otp_out>;
> +       pinctrl-names = "init", "default";
> +       pinctrl-0 = <&otp_gpio>;
> +       pinctrl-1 = <&otp_out>;

Are these optional or required? They only appear in the example.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1252976

FromCaesar Wang <caesar.upstream@gmail.com>
Date2015-10-21 17:50 +0200
Message-ID<qm3Oi-7q3-15@gated-at.bofh.it>
In reply to#1252949
Hi Rob,

在 2015年10月21日 23:18, Rob Herring 写道:
> On Tue, Oct 20, 2015 at 9:42 PM, Caesar Wang <wxt@rock-chips.com> wrote:
>> Add the OTP gpio state, we need switch the pin to gpio state
>> before the TSADC controller is reset.
>>
>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>> ---
>>
>> Changes in v1:
>>    - As the Doug comments, add the 'init' property to sync document.
>>
>>   Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>> index ef802de..28e84f7 100644
>> --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>> @@ -27,8 +27,9 @@ tsadc: tsadc@ff280000 {
>>          clock-names = "tsadc", "apb_pclk";
>>          resets = <&cru SRST_TSADC>;
>>          reset-names = "tsadc-apb";
>> -       pinctrl-names = "default";
>> -       pinctrl-0 = <&otp_out>;
>> +       pinctrl-names = "init", "default";
>> +       pinctrl-0 = <&otp_gpio>;
>> +       pinctrl-1 = <&otp_out>;
> Are these optional or required? They only appear in the example.

Yep,
These are required for TSADC.

I‘m assumed that's right,
I think we don't need to introduce the pinctrl in this document.

> Rob
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253050

FromRob Herring <robh+dt@kernel.org>
Date2015-10-21 18:50 +0200
Message-ID<qm4Km-nt-15@gated-at.bofh.it>
In reply to#1252976
On Wed, Oct 21, 2015 at 10:45 AM, Caesar Wang <caesar.upstream@gmail.com> wrote:
> Hi Rob,
>
> 在 2015年10月21日 23:18, Rob Herring 写道:
>>
>> On Tue, Oct 20, 2015 at 9:42 PM, Caesar Wang <wxt@rock-chips.com> wrote:
>>>
>>> Add the OTP gpio state, we need switch the pin to gpio state
>>> before the TSADC controller is reset.
>>>
>>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>>> ---
>>>
>>> Changes in v1:
>>>    - As the Doug comments, add the 'init' property to sync document.
>>>
>>>   Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 5
>>> +++--
>>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>>> b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>>> index ef802de..28e84f7 100644
>>> --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>>> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
>>> @@ -27,8 +27,9 @@ tsadc: tsadc@ff280000 {
>>>          clock-names = "tsadc", "apb_pclk";
>>>          resets = <&cru SRST_TSADC>;
>>>          reset-names = "tsadc-apb";
>>> -       pinctrl-names = "default";
>>> -       pinctrl-0 = <&otp_out>;
>>> +       pinctrl-names = "init", "default";
>>> +       pinctrl-0 = <&otp_gpio>;
>>> +       pinctrl-1 = <&otp_out>;
>>
>> Are these optional or required? They only appear in the example.
>
>
> Yep,
> These are required for TSADC.

Then list them that way.

>
> I‘m assumed that's right,
> I think we don't need to introduce the pinctrl in this document.

You need to state that you use them and what valid names are. That is
a contract with the driver.

The example is extra information and should not be required to write a
dts entry.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253386

FromRob Herring <robh+dt@kernel.org>
Date2015-10-22 03:20 +0200
Message-ID<qmcHU-3Ao-19@gated-at.bofh.it>
In reply to#1253050
On Wed, Oct 21, 2015 at 11:48 AM, Rob Herring <robh+dt@kernel.org> wrote:
> On Wed, Oct 21, 2015 at 10:45 AM, Caesar Wang <caesar.upstream@gmail.com> wrote:
>> Hi Rob,
>>
>> 在 2015年10月21日 23:18, Rob Herring 写道:
>>>
>>> On Tue, Oct 20, 2015 at 9:42 PM, Caesar Wang <wxt@rock-chips.com> wrote:
>>>>
>>>> Add the OTP gpio state, we need switch the pin to gpio state
>>>> before the TSADC controller is reset.

Also, please fix the subject to be specific what binding you are changing.

dt-bindings: rockchip-thermal: <what the change is>

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1253398

FromCaesar Wang <caesar.upstream@gmail.com>
Date2015-10-22 03:30 +0200
Message-ID<qmcRB-3LF-33@gated-at.bofh.it>
In reply to#1253386

在 2015年10月22日 09:18, Rob Herring 写道:
> On Wed, Oct 21, 2015 at 11:48 AM, Rob Herring <robh+dt@kernel.org> wrote:
>> On Wed, Oct 21, 2015 at 10:45 AM, Caesar Wang <caesar.upstream@gmail.com> wrote:
>>> Hi Rob,
>>>
>>> 在 2015年10月21日 23:18, Rob Herring 写道:
>>>> On Tue, Oct 20, 2015 at 9:42 PM, Caesar Wang <wxt@rock-chips.com> wrote:
>>>>> Add the OTP gpio state, we need switch the pin to gpio state
>>>>> before the TSADC controller is reset.
> Also, please fix the subject to be specific what binding you are changing.
>
> dt-bindings: rockchip-thermal: <what the change is>

Sorry, Mr. Rob
I just sent the patch.:-(


> Rob
>
>
>
>
> -- 
> Thanks,
> Caesar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web