Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1251461 > unrolled thread
| Started by | Chen Feng <puck.chen@hisilicon.com> |
|---|---|
| First post | 2015-10-20 10:50 +0200 |
| Last post | 2015-10-20 12:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH V2 3/3] Add dts node for smmu on hi6220 SoC Chen Feng <puck.chen@hisilicon.com> - 2015-10-20 10:50 +0200
Re: [PATCH V2 3/3] Add dts node for smmu on hi6220 SoC Arnd Bergmann <arnd@arndb.de> - 2015-10-20 11:10 +0200
Re: [PATCH V2 3/3] Add dts node for smmu on hi6220 SoC chenfeng <puck.chen@hisilicon.com> - 2015-10-20 12:50 +0200
| From | Chen Feng <puck.chen@hisilicon.com> |
|---|---|
| Date | 2015-10-20 10:50 +0200 |
| Subject | [PATCH V2 3/3] Add dts node for smmu on hi6220 SoC |
| Message-ID | <qlAMj-6Wk-55@gated-at.bofh.it> |
arm64: dts: Add dts node for hi6220 smmu driver
Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
Signed-off-by: Yu Dongbin <yudongbin@hisilicon.com>
---
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index 3f03380..3ef33b4 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -5,6 +5,7 @@
*/
#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/clock/hi6220-clock.h>
/ {
compatible = "hisilicon,hi6220";
@@ -167,5 +168,19 @@
clocks = <&ao_ctrl 36>, <&ao_ctrl 36>;
clock-names = "uartclk", "apb_pclk";
};
+
+ smmu@f4210000 {
+ compatible = "hisilicon,hi6220-smmu";
+ reg = <0x0 0xf4210000 0x0 0x1000>;
+ interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&sys_ctrl HI6220_MMU_CLK>,
+ <&media_ctrl HI6220_MED_MMU>,
+ <&sys_ctrl HI6220_MEDIA_PLL_SRC>;
+ clock-names = "smmu_clk",
+ "media_sc_clk",
+ "smmu_peri_clk";
+ #iommu-cells = <1>;
+ };
+
};
};
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2015-10-20 11:10 +0200 |
| Message-ID | <qlB5E-7z4-17@gated-at.bofh.it> |
| In reply to | #1251461 |
On Tuesday 20 October 2015 16:45:24 Chen Feng wrote:
> +
> + smmu@f4210000 {
I think the canonical name for an IOMMU device is 'iommu', not 'smmu'.
> + compatible = "hisilicon,hi6220-smmu";
> + reg = <0x0 0xf4210000 0x0 0x1000>;
> + interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&sys_ctrl HI6220_MMU_CLK>,
> + <&media_ctrl HI6220_MED_MMU>,
> + <&sys_ctrl HI6220_MEDIA_PLL_SRC>;
> + clock-names = "smmu_clk",
> + "media_sc_clk",
> + "smmu_peri_clk";
Better avoid underscores in strings, and drop the "_clk" postfix in
the clock names.
I did not receive patch 1/3 this time, but I see in version 1, that
you forgot to document the strings:
> +- clock-names: The name to enable clock with clock framework.
This needs to list the names of the clock inputs to the smmu.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | chenfeng <puck.chen@hisilicon.com> |
|---|---|
| Date | 2015-10-20 12:50 +0200 |
| Message-ID | <qlCEq-1fd-15@gated-at.bofh.it> |
| In reply to | #1251471 |
Thanks for review.
On 2015/10/20 17:00, Arnd Bergmann wrote:
> On Tuesday 20 October 2015 16:45:24 Chen Feng wrote:
>> +
>> + smmu@f4210000 {
>
> I think the canonical name for an IOMMU device is 'iommu', not 'smmu'.
Accept.
>
>> + compatible = "hisilicon,hi6220-smmu";
>> + reg = <0x0 0xf4210000 0x0 0x1000>;
>> + interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&sys_ctrl HI6220_MMU_CLK>,
>> + <&media_ctrl HI6220_MED_MMU>,
>> + <&sys_ctrl HI6220_MEDIA_PLL_SRC>;
>> + clock-names = "smmu_clk",
>> + "media_sc_clk",
>> + "smmu_peri_clk";
>
>
> Better avoid underscores in strings, and drop the "_clk" postfix in
> the clock names.
>
> I did not receive patch 1/3 this time, but I see in version 1, that
> you forgot to document the strings:
>
Accept, I will change this.
>> +- clock-names: The name to enable clock with clock framework.
>
> This needs to list the names of the clock inputs to the smmu.
>
> Arnd
> _______________________________________________
> linuxarm mailing list
> linuxarm@huawei.com
> http://rnd-openeuler.huawei.com/mailman/listinfo/linuxarm
>
> .
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web