Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1249129 > unrolled thread

[PATCH] memcg: include linux/mm.h

Back to article view | Back to linux.kernel

Contents

  [PATCH] memcg: include linux/mm.h Arnd Bergmann <arnd@arndb.de> - 2015-10-16 22:10 +0200
    Re: [PATCH] memcg: include linux/mm.h "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-10-16 22:50 +0200

#1249129 — [PATCH] memcg: include linux/mm.h

A recent change to the memcg code added a call to virt_to_head_page,
which is declared in linux/mm.h, but this is not necessarily included
here and will cause compile errors:

include/linux/memcontrol.h:841:9: error: implicit declaration of function 'virt_to_head_page' [-Werror=implicit-function-declaration]

This adds an explicit include statement that gets rid of the error.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 1ead4c071978 ("memcg: simplify and inline __mem_cgroup_from_kmem")

diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
index 47677acb4516..6d18936df7e8 100644
--- a/include/linux/memcontrol.h
+++ b/include/linux/memcontrol.h
@@ -27,6 +27,7 @@
 #include <linux/vmpressure.h>
 #include <linux/eventfd.h>
 #include <linux/mmzone.h>
+#include <linux/mm.h>
 #include <linux/writeback.h>
 
 struct mem_cgroup;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1249146

On Fri, Oct 16, 2015 at 10:03:31PM +0200, Arnd Bergmann wrote:
> A recent change to the memcg code added a call to virt_to_head_page,
> which is declared in linux/mm.h, but this is not necessarily included
> here and will cause compile errors:
> 
> include/linux/memcontrol.h:841:9: error: implicit declaration of function 'virt_to_head_page' [-Werror=implicit-function-declaration]
> 
> This adds an explicit include statement that gets rid of the error.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 1ead4c071978 ("memcg: simplify and inline __mem_cgroup_from_kmem")

http://lkml.kernel.org/g/20151016131726.GA602@node.shutemov.name

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web