Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1249267 > unrolled thread

[patch] iommu/vt-d: fix a loop in prq_event_thread()

Back to article view | Back to linux.kernel

Contents

  [patch] iommu/vt-d: fix a loop in prq_event_thread() Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-17 07:20 +0200
    Re: [patch] iommu/vt-d: fix a loop in prq_event_thread() "Woodhouse, David" <david.woodhouse@intel.com> - 2015-10-18 16:30 +0200

#1249267 — [patch] iommu/vt-d: fix a loop in prq_event_thread()

There is an extra semi-colon on this if statement so we always break on
the first iteration.

Fixes: 0204a4960982 ('iommu/vt-d: Add callback to device driver on page faults')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c
index 99a7803..dd070e6 100644
--- a/drivers/iommu/intel-svm.c
+++ b/drivers/iommu/intel-svm.c
@@ -536,7 +536,7 @@ static irqreturn_t prq_event_thread(int irq, void *d)
 		/* Accounting for major/minor faults? */
 		rcu_read_lock();
 		list_for_each_entry_rcu(sdev, &svm->devs, list) {
-			if (sdev->sid == PCI_DEVID(req->bus, req->devfn));
+			if (sdev->sid == PCI_DEVID(req->bus, req->devfn))
 				break;
 		}
 		/* Other devices can go away, but the drivers are not permitted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1250137

[Multipart message — attachments visible in raw view] — view raw

On Sat, 2015-10-17 at 08:18 +0300, Dan Carpenter wrote:
> There is an extra semi-colon on this if statement so we always break 
> on the first iteration.

Heh, it worked in my testing with only one registered device :)

Oops; thanks :)

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web