Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1249894 > unrolled thread

Re: [v7] serial: 8250_dw: Add support for big-endian MMIO accesses

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [v7] serial: 8250_dw: Add support for big-endian MMIO accesses Greg KH <gregkh@linuxfoundation.org> - 2015-10-18 06:10 +0200
    RE: [v7] serial: 8250_dw: Add support for big-endian MMIO accesses Noam Camus <noamc@ezchip.com> - 2015-10-18 07:40 +0200
      Re: [v7] serial: 8250_dw: Add support for big-endian MMIO accesses Greg KH <gregkh@linuxfoundation.org> - 2015-10-18 08:00 +0200

#1249894 — Re: [v7] serial: 8250_dw: Add support for big-endian MMIO accesses

On Tue, Oct 06, 2015 at 11:53:30AM +0300, Noam Camus wrote:
> From: Noam Camus <noamc@ezchip.com>
> 
> Add support for UPIO_MEM32BE in addition to UPIO_MEM32.
> dw8250_serial_out32() extra functionality that is not part of
> the 8250 core driver was moved to new function called
> dw8250_check_LCR().
> 
> For big endian we use 2 new accessors similar to little endian,
> called dw8250_serial_out32be() and dw8250_serial_in32be().
> Both little and big endian accessors use dw8250_check_LCR()
> for their dw8250_serial_out32{,be}().
> 
> In addition I added another 2 accessors inside private_data field of
> uart_port. This second level accessors are set during probe in
> private_data field of uart_port. Now any direct call to readl/writel
> is replaced with those accessors which are endianness aware.
> 
> Last issue:
> readl() for UCV and CPR will not work for port type UPIO_MEM32BE.
> Instead we use the serial_in32() accessor which is initialized
> properly according to endianness.
> 
> Signed-off-by: Noam Camus <noamc@ezchip.com>
> ---
>  drivers/tty/serial/8250/8250_dw.c |   72 ++++++++++++++++++++++++++++++++----
>  1 files changed, 64 insertions(+), 8 deletions(-)

This patch still doesn't apply at all to my tty-next branch, what are
you making it against?

Please fix it up and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1250083

> From: Greg KH [mailto:gregkh@linuxfoundation.org] 
> Sent: Sunday, October 18, 2015 7:06 AM

> This patch still doesn't apply at all to my tty-next branch, what are you making it against?

> Please fix it up and resend.

The patch is against v4.3-rc4
I will update to rc5

thanks,

Noam Camus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1250085

On Sun, Oct 18, 2015 at 05:30:23AM +0000, Noam Camus wrote:
> > From: Greg KH [mailto:gregkh@linuxfoundation.org] 
> > Sent: Sunday, October 18, 2015 7:06 AM
> 
> > This patch still doesn't apply at all to my tty-next branch, what are you making it against?
> 
> > Please fix it up and resend.
> 
> The patch is against v4.3-rc4
> I will update to rc5

Please make it against my tty-testing branch of tty.git on
git.kernel.org, that is the issue here, you are working against a
"clean" tree, not one with all of the other tty/serial changes in it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web