Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1244493 > unrolled thread
| Started by | Wenyou Yang <wenyou.yang@atmel.com> |
|---|---|
| First post | 2015-10-12 10:50 +0200 |
| Last post | 2015-10-18 02:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] rtc: at91rm9200: clear RTC alarm status flag prior to suspending Wenyou Yang <wenyou.yang@atmel.com> - 2015-10-12 10:50 +0200
Re: [PATCH v2] rtc: at91rm9200: clear RTC alarm status flag prior to suspending Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2015-10-18 02:20 +0200
| From | Wenyou Yang <wenyou.yang@atmel.com> |
|---|---|
| Date | 2015-10-12 10:50 +0200 |
| Subject | [PATCH v2] rtc: at91rm9200: clear RTC alarm status flag prior to suspending |
| Message-ID | <qiGXU-28r-19@gated-at.bofh.it> |
As said in the SAMA5D2 datasheet, "Prior to instructing the device
to enter ULP mode 1, ... and the internal sources of wake-up must
be cleared."
This patch is to clear the RTC alarm status flag prior to suspending
to avoid the erroneous wake-up activity, as it is often used as
the wake-up source for the ULP mode 1.
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---
Changes in v2:
- Add more detail commit log.
drivers/rtc/rtc-at91rm9200.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index cb62e21..b60fd47 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
/* this IRQ is shared with DBGU and other hardware which isn't
* necessarily doing PM like we are...
*/
+ at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
+
at91_rtc_imr = at91_rtc_read_imr()
& (AT91_RTC_ALARM|AT91_RTC_SECEV);
if (at91_rtc_imr) {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Date | 2015-10-18 02:20 +0200 |
| Subject | Re: [PATCH v2] rtc: at91rm9200: clear RTC alarm status flag prior to suspending |
| Message-ID | <qkJRE-5a1-3@gated-at.bofh.it> |
| In reply to | #1244493 |
On 12/10/2015 at 16:39:23 +0800, Wenyou Yang wrote : > As said in the SAMA5D2 datasheet, "Prior to instructing the device > to enter ULP mode 1, ... and the internal sources of wake-up must > be cleared." > > This patch is to clear the RTC alarm status flag prior to suspending > to avoid the erroneous wake-up activity, as it is often used as > the wake-up source for the ULP mode 1. > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> > --- > > Changes in v2: > - Add more detail commit log. > > drivers/rtc/rtc-at91rm9200.c | 2 ++ > 1 file changed, 2 insertions(+) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web