Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1246768 > unrolled thread
| Started by | Ingo Molnar <mingo@kernel.org> |
|---|---|
| First post | 2015-10-14 16:00 +0200 |
| Last post | 2015-10-16 04:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option Ingo Molnar <mingo@kernel.org> - 2015-10-14 16:00 +0200
RE: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option 河合英宏 / KAWAI，HIDEHIRO <hidehiro.kawai.ez@hitachi.com> - 2015-10-16 04:00 +0200
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2015-10-14 16:00 +0200 |
| Subject | Re: [V4 PATCH 4/4] x86/apic: Introduce noextnmi boot option |
| Message-ID | <qjuKZ-k6-5@gated-at.bofh.it> |
* Thomas Gleixner <tglx@linutronix.de> wrote:
> Borislav,
>
> On Mon, 5 Oct 2015, Borislav Petkov wrote:
> > On Mon, Oct 05, 2015 at 02:03:58AM +0000, 河合英宏 / KAWAI，HIDEHIRO wrote:
> > > That's different from my point of view. I'm not going to pass
> > > some data from the first kernel to the second kernel. I'm just going to
> > > provide a configurable option for the second kernel to users.
> >
> > Dude, WTF?! You're adding a kernel command line which is supposed to
> > be used *only* by the kdump kernel. But nooo, it is there in the open
> > and visible to people. And anyone can type it in during boot. AND THAT
> > SHOULDN'T BE POSSIBLE IN THE FIRST PLACE!
> >
> > This information is strictly for the kdump kernel - it shouldn't be a
> > generic command line option. How hard it is to understand that simple
> > fact?!
>
> Calm down!
>
> Disabling that NMI in the first kernel is not going to make the world
> explode. We have enough command line options a user can type in, which
> are way worse than that one. If some "expert" types nonsense on the
> first kernel command line, then it's none of our problems, really.
>
> If Kawai would have marked that option as a debug feature, this
> discussion would have probably never happened.
>
> Aside of that, the best way to hand in options for the kdump kernel is
> the command line. We have an existing interface for that.
>
> Let's move on. Nothing to see here.
So Boris kind of has a point: there are numerous problems with boot options as
kexec parameter interface:
- boot option strings are not a well defined programmatic interface:
- failures are not obvious (they are often ignored)
- inserting/setting parameters is awkward as well.
- boot options are not an ABI, so when options have dual use with kexec it's easy
to break things inadvertently: without that failure being apparent other than
reintroducing obscure kexec failure modes again.
- in the booted up kexec kernel it's not really obvious which options got set by
kexec and which got set by the user - as there's no separation of namespaces.
- likewise, if the user specifies an option in conflict with a kexec requirement
it's not really obvious what's happening: the user setting should probably
dominate - I'm not sure that's the case with the current kexec code.
Boot options are basically a user interface.
On the other hand the hack of (ab-)using boot parameters as kexec parameter
passing is an existing, many years old practice and we cannot just stop it without
offering an alternative (and better!) interface first.
We could improve things by either adding a separate kexec-only parameter passing
facility (like programmatic boot parameters are) - or by creating some sort of
boot parameter alias that clearly identifies kexec parameters.
So for example when introducing 'noextnmi' we'd also add a facility to add a
'kexec_noextnmi' alias - which clearly identifies this boot parameter as a kexec
related one.
Every 'kexec' inserted parameter would be prefixed by kexec_ - and then the
separation of namespaces (and the prioritization of user vs. kexec requirements)
becomes well defined as well..
We should also probably print a warning if a kexec_* parameter is passed in that
has no matching handler in the kexec()-ed kernel.
I do concur that this patch is probably OK given existing practices.
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | 河合英宏 / KAWAI，HIDEHIRO <hidehiro.kawai.ez@hitachi.com> |
|---|---|
| Date | 2015-10-16 04:00 +0200 |
| Message-ID | <qk2tj-8h1-5@gated-at.bofh.it> |
| In reply to | #1246768 |
PiAqIFRob21hcyBHbGVpeG5lciA8dGdseEBsaW51dHJvbml4LmRlPiB3cm90ZToNCj4gDQo+ID4g Qm9yaXNsYXYsDQo+ID4NCj4gPiBPbiBNb24sIDUgT2N0IDIwMTUsIEJvcmlzbGF2IFBldGtvdiB3 cm90ZToNCj4gPiA+IE9uIE1vbiwgT2N0IDA1LCAyMDE1IGF0IDAyOjAzOjU4QU0gKzAwMDAsIOay s+WQiOiLseWujyAvIEtBV0FJ77yMSElERUhJUk8gd3JvdGU6DQo+ID4gPiA+IFRoYXQncyBkaWZm ZXJlbnQgZnJvbSBteSBwb2ludCBvZiB2aWV3LiAgSSdtIG5vdCBnb2luZyB0byBwYXNzDQo+ID4g PiA+IHNvbWUgZGF0YSBmcm9tIHRoZSBmaXJzdCBrZXJuZWwgdG8gdGhlIHNlY29uZCBrZXJuZWwu IEknbSBqdXN0IGdvaW5nIHRvDQo+ID4gPiA+IHByb3ZpZGUgYSBjb25maWd1cmFibGUgb3B0aW9u IGZvciB0aGUgc2Vjb25kIGtlcm5lbCB0byB1c2Vycy4NCj4gPiA+DQo+ID4gPiBEdWRlLCBXVEY/ ISBZb3UncmUgYWRkaW5nIGEga2VybmVsIGNvbW1hbmQgbGluZSB3aGljaCBpcyBzdXBwb3NlZCB0 bw0KPiA+ID4gYmUgdXNlZCAqb25seSogYnkgdGhlIGtkdW1wIGtlcm5lbC4gQnV0IG5vb28sIGl0 IGlzIHRoZXJlIGluIHRoZSBvcGVuDQo+ID4gPiBhbmQgdmlzaWJsZSB0byBwZW9wbGUuIEFuZCBh bnlvbmUgY2FuIHR5cGUgaXQgaW4gZHVyaW5nIGJvb3QuIEFORCBUSEFUDQo+ID4gPiBTSE9VTERO J1QgQkUgUE9TU0lCTEUgSU4gVEhFIEZJUlNUIFBMQUNFIQ0KPiA+ID4NCj4gPiA+IFRoaXMgaW5m b3JtYXRpb24gaXMgc3RyaWN0bHkgZm9yIHRoZSBrZHVtcCBrZXJuZWwgLSBpdCBzaG91bGRuJ3Qg YmUgYQ0KPiA+ID4gZ2VuZXJpYyBjb21tYW5kIGxpbmUgb3B0aW9uLiBIb3cgaGFyZCBpdCBpcyB0 byB1bmRlcnN0YW5kIHRoYXQgc2ltcGxlDQo+ID4gPiBmYWN0PyENCj4gPg0KPiA+IENhbG0gZG93 biENCj4gPg0KPiA+IERpc2FibGluZyB0aGF0IE5NSSBpbiB0aGUgZmlyc3Qga2VybmVsIGlzIG5v dCBnb2luZyB0byBtYWtlIHRoZSB3b3JsZA0KPiA+IGV4cGxvZGUuIFdlIGhhdmUgZW5vdWdoIGNv bW1hbmQgbGluZSBvcHRpb25zIGEgdXNlciBjYW4gdHlwZSBpbiwgd2hpY2gNCj4gPiBhcmUgd2F5 IHdvcnNlIHRoYW4gdGhhdCBvbmUuIElmIHNvbWUgImV4cGVydCIgdHlwZXMgbm9uc2Vuc2Ugb24g dGhlDQo+ID4gZmlyc3Qga2VybmVsIGNvbW1hbmQgbGluZSwgdGhlbiBpdCdzIG5vbmUgb2Ygb3Vy IHByb2JsZW1zLCByZWFsbHkuDQo+ID4NCj4gPiBJZiBLYXdhaSB3b3VsZCBoYXZlIG1hcmtlZCB0 aGF0IG9wdGlvbiBhcyBhIGRlYnVnIGZlYXR1cmUsIHRoaXMNCj4gPiBkaXNjdXNzaW9uIHdvdWxk IGhhdmUgcHJvYmFibHkgbmV2ZXIgaGFwcGVuZWQuDQo+ID4NCj4gPiBBc2lkZSBvZiB0aGF0LCB0 aGUgYmVzdCB3YXkgdG8gaGFuZCBpbiBvcHRpb25zIGZvciB0aGUga2R1bXAga2VybmVsIGlzDQo+ ID4gdGhlIGNvbW1hbmQgbGluZS4gV2UgaGF2ZSBhbiBleGlzdGluZyBpbnRlcmZhY2UgZm9yIHRo YXQuDQo+ID4NCj4gPiBMZXQncyBtb3ZlIG9uLiBOb3RoaW5nIHRvIHNlZSBoZXJlLg0KPiANCj4g U28gQm9yaXMga2luZCBvZiBoYXMgYSBwb2ludDogdGhlcmUgYXJlIG51bWVyb3VzIHByb2JsZW1z IHdpdGggYm9vdCBvcHRpb25zIGFzDQo+IGtleGVjIHBhcmFtZXRlciBpbnRlcmZhY2U6DQo+IA0K PiAgLSBib290IG9wdGlvbiBzdHJpbmdzIGFyZSBub3QgYSB3ZWxsIGRlZmluZWQgcHJvZ3JhbW1h dGljIGludGVyZmFjZToNCj4gICAgIC0gZmFpbHVyZXMgYXJlIG5vdCBvYnZpb3VzICh0aGV5IGFy ZSBvZnRlbiBpZ25vcmVkKQ0KPiAgICAgLSBpbnNlcnRpbmcvc2V0dGluZyBwYXJhbWV0ZXJzIGlz IGF3a3dhcmQgYXMgd2VsbC4NCj4gDQo+ICAtIGJvb3Qgb3B0aW9ucyBhcmUgbm90IGFuIEFCSSwg c28gd2hlbiBvcHRpb25zIGhhdmUgZHVhbCB1c2Ugd2l0aCBrZXhlYyBpdCdzIGVhc3kNCj4gICAg dG8gYnJlYWsgdGhpbmdzIGluYWR2ZXJ0ZW50bHk6IHdpdGhvdXQgdGhhdCBmYWlsdXJlIGJlaW5n IGFwcGFyZW50IG90aGVyIHRoYW4NCj4gICAgcmVpbnRyb2R1Y2luZyBvYnNjdXJlIGtleGVjIGZh aWx1cmUgbW9kZXMgYWdhaW4uDQo+IA0KPiAgLSBpbiB0aGUgYm9vdGVkIHVwIGtleGVjIGtlcm5l bCBpdCdzIG5vdCByZWFsbHkgb2J2aW91cyB3aGljaCBvcHRpb25zIGdvdCBzZXQgYnkNCj4gICAg a2V4ZWMgYW5kIHdoaWNoIGdvdCBzZXQgYnkgdGhlIHVzZXIgLSBhcyB0aGVyZSdzIG5vIHNlcGFy YXRpb24gb2YgbmFtZXNwYWNlcy4NCj4gDQo+ICAtIGxpa2V3aXNlLCBpZiB0aGUgdXNlciBzcGVj aWZpZXMgYW4gb3B0aW9uIGluIGNvbmZsaWN0IHdpdGggYSBrZXhlYyByZXF1aXJlbWVudA0KPiAg ICBpdCdzIG5vdCByZWFsbHkgb2J2aW91cyB3aGF0J3MgaGFwcGVuaW5nOiB0aGUgdXNlciBzZXR0 aW5nIHNob3VsZCBwcm9iYWJseQ0KPiAgICBkb21pbmF0ZSAtIEknbSBub3Qgc3VyZSB0aGF0J3Mg dGhlIGNhc2Ugd2l0aCB0aGUgY3VycmVudCBrZXhlYyBjb2RlLg0KDQpUaGFua3MgZm9yIHRoZSBk ZXRhaWxlZCBleHBsYW5hdGlvbi4gIEkgY2FuIHVuZGVyc3RhbmQgdGhlIGRpc2FkdmFudGFnZXMN Cm9mIHVzaW5nIGJvb3Qgb3B0aW9uLiAgU28gdGhlc2UgYXJlIGVzc2VudGlhbCBwcm9ibGVtcyB3 aXRoIGJvb3Qgb3B0aW9ucw0KcmF0aGVyIHRoYW4gbmV3IGJvb3Qgb3B0aW9uIGFkZGVkIGZvciBr ZXhlYydlZCBrZXJuZWwuDQogDQo+IEJvb3Qgb3B0aW9ucyBhcmUgYmFzaWNhbGx5IGEgdXNlciBp bnRlcmZhY2UuDQo+IA0KPiBPbiB0aGUgb3RoZXIgaGFuZCB0aGUgaGFjayBvZiAoYWItKXVzaW5n IGJvb3QgcGFyYW1ldGVycyBhcyBrZXhlYyBwYXJhbWV0ZXINCj4gcGFzc2luZyBpcyBhbiBleGlz dGluZywgbWFueSB5ZWFycyBvbGQgcHJhY3RpY2UgYW5kIHdlIGNhbm5vdCBqdXN0IHN0b3AgaXQg d2l0aG91dA0KPiBvZmZlcmluZyBhbiBhbHRlcm5hdGl2ZSAoYW5kIGJldHRlciEpIGludGVyZmFj ZSBmaXJzdC4NCj4gDQo+IFdlIGNvdWxkIGltcHJvdmUgdGhpbmdzIGJ5IGVpdGhlciBhZGRpbmcg YSBzZXBhcmF0ZSBrZXhlYy1vbmx5IHBhcmFtZXRlciBwYXNzaW5nDQo+IGZhY2lsaXR5IChsaWtl IHByb2dyYW1tYXRpYyBib290IHBhcmFtZXRlcnMgYXJlKSAtIG9yIGJ5IGNyZWF0aW5nIHNvbWUg c29ydCBvZg0KPiBib290IHBhcmFtZXRlciBhbGlhcyB0aGF0IGNsZWFybHkgaWRlbnRpZmllcyBr ZXhlYyBwYXJhbWV0ZXJzLg0KPiANCj4gU28gZm9yIGV4YW1wbGUgd2hlbiBpbnRyb2R1Y2luZyAn bm9leHRubWknIHdlJ2QgYWxzbyBhZGQgYSBmYWNpbGl0eSB0byBhZGQgYQ0KPiAna2V4ZWNfbm9l eHRubWknIGFsaWFzIC0gd2hpY2ggY2xlYXJseSBpZGVudGlmaWVzIHRoaXMgYm9vdCBwYXJhbWV0 ZXIgYXMgYSBrZXhlYw0KPiByZWxhdGVkIG9uZS4NCj4gDQo+IEV2ZXJ5ICdrZXhlYycgaW5zZXJ0 ZWQgcGFyYW1ldGVyIHdvdWxkIGJlIHByZWZpeGVkIGJ5IGtleGVjXyAtIGFuZCB0aGVuIHRoZQ0K PiBzZXBhcmF0aW9uIG9mIG5hbWVzcGFjZXMgKGFuZCB0aGUgcHJpb3JpdGl6YXRpb24gb2YgdXNl ciB2cy4ga2V4ZWMgcmVxdWlyZW1lbnRzKQ0KPiBiZWNvbWVzIHdlbGwgZGVmaW5lZCBhcyB3ZWxs Li4NCj4gDQo+IFdlIHNob3VsZCBhbHNvIHByb2JhYmx5IHByaW50IGEgd2FybmluZyBpZiBhIGtl eGVjXyogcGFyYW1ldGVyIGlzIHBhc3NlZCBpbiB0aGF0DQo+IGhhcyBubyBtYXRjaGluZyBoYW5k bGVyIGluIHRoZSBrZXhlYygpLWVkIGtlcm5lbC4NCg0KSXQgd291bGQgYmUgcmVhc29uYWJsZS4g IE9yIHdlIG1pZ2h0IGltcHJvdmUga2V4ZWMgY29tbWFuZCBzbyB0aGF0DQppdCByZW1vdmVzIGNv bmZsaWN0IGJvb3Qgb3B0aW9ucyB3aXRoIHdhcm5pbmdzLg0KDQpBcyBJIHN0YXRlZCBpbiBhbm90 aGVyIG1haWwsIEknbSBnb2luZyB0byBjaGFuZ2UgIm5vZXh0bm1pIiB0bw0KImFwaWNfZXh0bm1p PXtic3B8YWxsfG5vbmV9Iiwgd2hpY2ggY2FuIGJlIHVzZWQgYm90aCB0aGUgZmlyc3QgYW5kDQpz ZWNvbmQga2VybmVscy4gIFNvLCBJJ2xsIGFkZCB0aGlzIG9wdGlvbiB3aXRob3V0ICJrZXhlY18i IHByZWZpeA0KYXQgdGhpcyBwb2ludC4NCg0KPiBJIGRvIGNvbmN1ciB0aGF0IHRoaXMgcGF0Y2gg aXMgcHJvYmFibHkgT0sgZ2l2ZW4gZXhpc3RpbmcgcHJhY3RpY2VzLg0KDQpUaGFua3MhDQoNCi0t DQpIaWRlaGlybyBLYXdhaQ0KSGl0YWNoaSwgTHRkLiBSZXNlYXJjaCAmIERldmVsb3BtZW50IEdy b3VwDQoNCg0K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web