Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1246386 > unrolled thread
| Started by | Heloise NH <os@iscas.ac.cn> |
|---|---|
| First post | 2015-10-14 09:50 +0200 |
| Last post | 2015-10-14 16:30 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] fix return value error Heloise NH <os@iscas.ac.cn> - 2015-10-14 09:50 +0200
RE: [PATCH] fix return value error "Marciniszyn, Mike" <mike.marciniszyn@intel.com> - 2015-10-14 16:20 +0200
RE: [PATCH] fix return value error "Marciniszyn, Mike" <mike.marciniszyn@intel.com> - 2015-10-14 16:30 +0200
Re: [PATCH] fix return value error Leon Romanovsky <leon@leon.nu> - 2015-10-14 16:30 +0200
| From | Heloise NH <os@iscas.ac.cn> |
|---|---|
| Date | 2015-10-14 09:50 +0200 |
| Subject | [PATCH] fix return value error |
| Message-ID | <qjoYX-ib-47@gated-at.bofh.it> |
Signed-off-by: Heloise NH <os@iscas.ac.cn>
---
drivers/infiniband/hw/ipath/ipath_fs.c | 2 +-
drivers/infiniband/hw/qib/qib_fs.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/ipath/ipath_fs.c b/drivers/infiniband/hw/ipath/ipath_fs.c
index 25422a3..da753bc 100644
--- a/drivers/infiniband/hw/ipath/ipath_fs.c
+++ b/drivers/infiniband/hw/ipath/ipath_fs.c
@@ -53,7 +53,7 @@ static int ipathfs_mknod(struct inode *dir, struct dentry *dentry,
struct inode *inode = new_inode(dir->i_sb);
if (!inode) {
- error = -EPERM;
+ error = -ENOMEM;
goto bail;
}
diff --git a/drivers/infiniband/hw/qib/qib_fs.c b/drivers/infiniband/hw/qib/qib_fs.c
index 13ef22b..a4c5a6a 100644
--- a/drivers/infiniband/hw/qib/qib_fs.c
+++ b/drivers/infiniband/hw/qib/qib_fs.c
@@ -55,7 +55,7 @@ static int qibfs_mknod(struct inode *dir, struct dentry *dentry,
struct inode *inode = new_inode(dir->i_sb);
if (!inode) {
- error = -EPERM;
+ error = -ENOMEM;
goto bail;
}
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Marciniszyn, Mike" <mike.marciniszyn@intel.com> |
|---|---|
| Date | 2015-10-14 16:20 +0200 |
| Message-ID | <qjv4o-Wf-43@gated-at.bofh.it> |
| In reply to | #1246386 |
> Subject: [PATCH] fix return value error > I checked returns in configfs (-ENOMEM), proc (-ENOENT), proc-sys (-ENOMEM), ramfs (-ENOSPC), vfs (-ENOMEM). Not entirely consistent but this matches the majority. I agree -EPERM is pretty misleading. Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Marciniszyn, Mike" <mike.marciniszyn@intel.com> |
|---|---|
| Date | 2015-10-14 16:30 +0200 |
| Message-ID | <qjve2-17o-5@gated-at.bofh.it> |
| In reply to | #1246386 |
> > Subject: [PATCH] fix return value error > > > > I checked returns in configfs (-ENOMEM), proc (-ENOENT), proc-sys (- > ENOMEM), ramfs (-ENOSPC), vfs (-ENOMEM). > > Not entirely consistent but this matches the majority. > > I agree -EPERM is pretty misleading. > > Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com> Thanks Or on catching the bad directory in the patch. Doug, can you fix this up or do you want it resubmitted? Mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Leon Romanovsky <leon@leon.nu> |
|---|---|
| Date | 2015-10-14 16:30 +0200 |
| Message-ID | <qjve2-17o-19@gated-at.bofh.it> |
| In reply to | #1246816 |
On Wed, Oct 14, 2015 at 5:17 PM, Marciniszyn, Mike <mike.marciniszyn@intel.com> wrote: >> > Subject: [PATCH] fix return value error >> > >> >> I checked returns in configfs (-ENOMEM), proc (-ENOENT), proc-sys (- >> ENOMEM), ramfs (-ENOSPC), vfs (-ENOMEM). >> >> Not entirely consistent but this matches the majority. >> >> I agree -EPERM is pretty misleading. >> >> Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com> > > Thanks Or on catching the bad directory in the patch. Thanks Or > > Doug, can you fix this up or do you want it resubmitted? > > Mike > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web