Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1245443 > unrolled thread
| Started by | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| First post | 2015-10-13 10:20 +0200 |
| Last post | 2015-10-14 16:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] crypto: ccm - remove goto Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-10-13 10:20 +0200
Re: [PATCH] crypto: ccm - remove goto Herbert Xu <herbert@gondor.apana.org.au> - 2015-10-14 16:20 +0200
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Date | 2015-10-13 10:20 +0200 |
| Subject | [PATCH] crypto: ccm - remove goto |
| Message-ID | <qj2Yq-Lw-15@gated-at.bofh.it> |
Instead of using goto and jumping to a label and then returning from
there, lets return directly. The label out: is not used from anywhere
else in the code.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
crypto/ccm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/crypto/ccm.c b/crypto/ccm.c
index cc31ea4..daa7e6d 100644
--- a/crypto/ccm.c
+++ b/crypto/ccm.c
@@ -881,14 +881,13 @@ static int crypto_rfc4309_create(struct crypto_template *tmpl,
if (err)
goto out_drop_alg;
-out:
return err;
out_drop_alg:
crypto_drop_aead(spawn);
out_free_inst:
kfree(inst);
- goto out;
+ return err;
}
static struct crypto_template crypto_rfc4309_tmpl = {
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2015-10-14 16:20 +0200 |
| Message-ID | <qjv4n-Wf-41@gated-at.bofh.it> |
| In reply to | #1245443 |
On Tue, Oct 13, 2015 at 01:48:25PM +0530, Sudip Mukherjee wrote: > Instead of using goto and jumping to a label and then returning from > there, lets return directly. The label out: is not used from anywhere > else in the code. > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> I don't think patch improves the code so I'm not taking it. Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web