Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1245379 > unrolled thread
| Started by | Hui Zhu <zhuhui@xiaomi.com> |
|---|---|
| First post | 2015-10-13 08:40 +0200 |
| Last post | 2015-10-14 02:40 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] zsmalloc: remove unless line in obj_free Hui Zhu <zhuhui@xiaomi.com> - 2015-10-13 08:40 +0200
Re: [PATCH] zsmalloc: remove unless line in obj_free Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-10-13 10:10 +0200
Re: [PATCH] zsmalloc: remove unless line in obj_free Hui Zhu <teawater@gmail.com> - 2015-10-13 11:10 +0200
[PATCH v2] zsmalloc: remove useless line in obj_free Hui Zhu <zhuhui@xiaomi.com> - 2015-10-13 11:10 +0200
Re: [PATCH v2] zsmalloc: remove useless line in obj_free Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-10-14 02:40 +0200
| From | Hui Zhu <zhuhui@xiaomi.com> |
|---|---|
| Date | 2015-10-13 08:40 +0200 |
| Subject | [PATCH] zsmalloc: remove unless line in obj_free |
| Message-ID | <qj1pE-6O2-23@gated-at.bofh.it> |
Signed-off-by: Hui Zhu <zhuhui@xiaomi.com> --- mm/zsmalloc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index f135b1b..c7338f0 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -1428,8 +1428,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class, struct page *first_page, *f_page; unsigned long f_objidx, f_offset; void *vaddr; - int class_idx; - enum fullness_group fullness; BUG_ON(!obj); @@ -1437,7 +1435,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class, obj_to_location(obj, &f_page, &f_objidx); first_page = get_first_page(f_page); - get_zspage_mapping(first_page, &class_idx, &fullness); f_offset = obj_idx_to_offset(f_page, f_objidx, class->size); vaddr = kmap_atomic(f_page); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| Date | 2015-10-13 10:10 +0200 |
| Message-ID | <qj2OK-A2-13@gated-at.bofh.it> |
| In reply to | #1245379 |
On (10/13/15 14:31), Hui Zhu wrote: > Signed-off-by: Hui Zhu <zhuhui@xiaomi.com> s/unless/useless/ other than that Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> -ss > --- > mm/zsmalloc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index f135b1b..c7338f0 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -1428,8 +1428,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class, > struct page *first_page, *f_page; > unsigned long f_objidx, f_offset; > void *vaddr; > - int class_idx; > - enum fullness_group fullness; > > BUG_ON(!obj); > > @@ -1437,7 +1435,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class, > obj_to_location(obj, &f_page, &f_objidx); > first_page = get_first_page(f_page); > > - get_zspage_mapping(first_page, &class_idx, &fullness); > f_offset = obj_idx_to_offset(f_page, f_objidx, class->size); > > vaddr = kmap_atomic(f_page); > -- > 1.9.1 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Hui Zhu <teawater@gmail.com> |
|---|---|
| Date | 2015-10-13 11:10 +0200 |
| Message-ID | <qj3KN-1Wm-5@gated-at.bofh.it> |
| In reply to | #1245425 |
Thanks. I will post a new version later. Best, Hui On Tue, Oct 13, 2015 at 4:00 PM, Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote: > On (10/13/15 14:31), Hui Zhu wrote: >> Signed-off-by: Hui Zhu <zhuhui@xiaomi.com> > > s/unless/useless/ > > other than that > > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > > -ss > >> --- >> mm/zsmalloc.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c >> index f135b1b..c7338f0 100644 >> --- a/mm/zsmalloc.c >> +++ b/mm/zsmalloc.c >> @@ -1428,8 +1428,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class, >> struct page *first_page, *f_page; >> unsigned long f_objidx, f_offset; >> void *vaddr; >> - int class_idx; >> - enum fullness_group fullness; >> >> BUG_ON(!obj); >> >> @@ -1437,7 +1435,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class, >> obj_to_location(obj, &f_page, &f_objidx); >> first_page = get_first_page(f_page); >> >> - get_zspage_mapping(first_page, &class_idx, &fullness); >> f_offset = obj_idx_to_offset(f_page, f_objidx, class->size); >> >> vaddr = kmap_atomic(f_page); >> -- >> 1.9.1 >> >> -- >> To unsubscribe, send a message with 'unsubscribe linux-mm' in >> the body to majordomo@kvack.org. For more info on Linux MM, >> see: http://www.linux-mm.org/ . >> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Hui Zhu <zhuhui@xiaomi.com> |
|---|---|
| Date | 2015-10-13 11:10 +0200 |
| Subject | [PATCH v2] zsmalloc: remove useless line in obj_free |
| Message-ID | <qj3KO-1Wm-23@gated-at.bofh.it> |
| In reply to | #1245425 |
Signed-off-by: Hui Zhu <zhuhui@xiaomi.com> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> --- mm/zsmalloc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index f135b1b..c7338f0 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -1428,8 +1428,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class, struct page *first_page, *f_page; unsigned long f_objidx, f_offset; void *vaddr; - int class_idx; - enum fullness_group fullness; BUG_ON(!obj); @@ -1437,7 +1435,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class, obj_to_location(obj, &f_page, &f_objidx); first_page = get_first_page(f_page); - get_zspage_mapping(first_page, &class_idx, &fullness); f_offset = obj_idx_to_offset(f_page, f_objidx, class->size); vaddr = kmap_atomic(f_page); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> |
|---|---|
| Date | 2015-10-14 02:40 +0200 |
| Subject | Re: [PATCH v2] zsmalloc: remove useless line in obj_free |
| Message-ID | <qjigO-6iu-9@gated-at.bofh.it> |
| In reply to | #1245484 |
On (10/13/15 17:07), Hui Zhu wrote: > > Signed-off-by: Hui Zhu <zhuhui@xiaomi.com> > Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Please Cc Andrew Morton to mm/ patches. -ss > --- > mm/zsmalloc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index f135b1b..c7338f0 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -1428,8 +1428,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class, > struct page *first_page, *f_page; > unsigned long f_objidx, f_offset; > void *vaddr; > - int class_idx; > - enum fullness_group fullness; > > BUG_ON(!obj); > > @@ -1437,7 +1435,6 @@ static void obj_free(struct zs_pool *pool, struct size_class *class, > obj_to_location(obj, &f_page, &f_objidx); > first_page = get_first_page(f_page); > > - get_zspage_mapping(first_page, &class_idx, &fullness); > f_offset = obj_idx_to_offset(f_page, f_objidx, class->size); > > vaddr = kmap_atomic(f_page); > -- > 1.9.1 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web