Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1246053 > unrolled thread
| Started by | Steffen Trumtrar <s.trumtrar@pengutronix.de> |
|---|---|
| First post | 2015-10-13 21:00 +0200 |
| Last post | 2015-10-13 22:50 +0200 |
| Articles | 3 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] ARM: socfpga: dts: add fpga manager Steffen Trumtrar <s.trumtrar@pengutronix.de> - 2015-10-13 21:00 +0200
Re: [PATCH] ARM: socfpga: dts: add fpga manager Steffen Trumtrar <s.trumtrar@pengutronix.de> - 2015-10-13 22:30 +0200
Re: [PATCH] ARM: socfpga: dts: add fpga manager Steffen Trumtrar <s.trumtrar@pengutronix.de> - 2015-10-13 22:50 +0200
| From | Steffen Trumtrar <s.trumtrar@pengutronix.de> |
|---|---|
| Date | 2015-10-13 21:00 +0200 |
| Subject | Re: [PATCH] ARM: socfpga: dts: add fpga manager |
| Message-ID | <qjcXL-6NR-5@gated-at.bofh.it> |
Hi Alan!
On Tue, Oct 13, 2015 at 01:28:20PM -0500, atull@opensource.altera.com wrote:
> From: Alan Tull <atull@opensource.altera.com>
>
> Add FPGA manager to device tree for SoCFPGA.
>
> Signed-off-by: Alan Tull <atull@opensource.altera.com>
> ---
> arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 314e589..e37ba11 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -834,5 +834,12 @@
> compatible = "altr,sys-mgr", "syscon";
> reg = <0xffd08000 0x4000>;
> };
> +
> + hps_0_fpgamgr: fpgamgr@0xff706000 {
> + compatible = "altr,socfpga-fpga-mgr";
> + reg = <0xFF706000 0x1000
> + 0xFFB90000 0x1000>;
> + interrupts = <0 175 4>;
> + };
> };
> };
Please keep the format in line with the rest of the file:
Hexvalues are lowercase and no 0x after the "fpgamgr@".
I'd say "And please put the node in its proper position
according to its address", but I see just now, that the
dtsi is all messed up right now anyway :-(
Regards,
Steffen
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Steffen Trumtrar <s.trumtrar@pengutronix.de> |
|---|---|
| Date | 2015-10-13 22:30 +0200 |
| Message-ID | <qjemR-AL-3@gated-at.bofh.it> |
| In reply to | #1246053 |
On Tue, Oct 13, 2015 at 02:18:22PM -0500, Dinh Nguyen wrote:
> On Tue, 13 Oct 2015, Steffen Trumtrar wrote:
>
> > Hi Alan!
> >
> > On Tue, Oct 13, 2015 at 01:28:20PM -0500, atull@opensource.altera.com wrote:
> > > From: Alan Tull <atull@opensource.altera.com>
> > >
> > > Add FPGA manager to device tree for SoCFPGA.
> > >
> > > Signed-off-by: Alan Tull <atull@opensource.altera.com>
> > > ---
> > > arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > > index 314e589..e37ba11 100644
> > > --- a/arch/arm/boot/dts/socfpga.dtsi
> > > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > > @@ -834,5 +834,12 @@
> > > compatible = "altr,sys-mgr", "syscon";
> > > reg = <0xffd08000 0x4000>;
> > > };
> > > +
> > > + hps_0_fpgamgr: fpgamgr@0xff706000 {
> > > + compatible = "altr,socfpga-fpga-mgr";
> > > + reg = <0xFF706000 0x1000
> > > + 0xFFB90000 0x1000>;
> > > + interrupts = <0 175 4>;
> > > + };
> > > };
> > > };
> >
> > Please keep the format in line with the rest of the file:
> > Hexvalues are lowercase and no 0x after the "fpgamgr@".
> > I'd say "And please put the node in its proper position
> > according to its address", but I see just now, that the
> > dtsi is all messed up right now anyway :-(
> >
>
> How so? Patches are welcomed!
Done :-)
>
> Please fix the "fpgamgr@" and lower case the hex values. But I would prefer the
> nodes to be in alphabetical order.
>
Ah, that explains it, I guess. I always sorted my patches by address :-)
The thing is, now all nodes are sorted alphabetically by phandle,
the clkmgr however seems to be ordered by address.
I prefer address btw because it is a fixed hardware constant. For the
dts files sorting via phandle is again fixed via the dtsi.
Regards,
Steffen
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Steffen Trumtrar <s.trumtrar@pengutronix.de> |
|---|---|
| Date | 2015-10-13 22:50 +0200 |
| Message-ID | <qjeGf-Xw-33@gated-at.bofh.it> |
| In reply to | #1246053 |
Hi!
On Tue, Oct 13, 2015 at 09:46:15PM +0200, atull wrote:
> On Tue, 13 Oct 2015, Dinh Nguyen wrote:
>
> > On Tue, 13 Oct 2015, Steffen Trumtrar wrote:
> >
> > > Hi Alan!
> > >
> > > On Tue, Oct 13, 2015 at 01:28:20PM -0500, atull@opensource.altera.com wrote:
> > > > From: Alan Tull <atull@opensource.altera.com>
> > > >
> > > > Add FPGA manager to device tree for SoCFPGA.
> > > >
> > > > Signed-off-by: Alan Tull <atull@opensource.altera.com>
> > > > ---
> > > > arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
> > > > 1 file changed, 7 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> > > > index 314e589..e37ba11 100644
> > > > --- a/arch/arm/boot/dts/socfpga.dtsi
> > > > +++ b/arch/arm/boot/dts/socfpga.dtsi
> > > > @@ -834,5 +834,12 @@
> > > > compatible = "altr,sys-mgr", "syscon";
> > > > reg = <0xffd08000 0x4000>;
> > > > };
> > > > +
> > > > + hps_0_fpgamgr: fpgamgr@0xff706000 {
> > > > + compatible = "altr,socfpga-fpga-mgr";
> > > > + reg = <0xFF706000 0x1000
> > > > + 0xFFB90000 0x1000>;
> > > > + interrupts = <0 175 4>;
> > > > + };
> > > > };
> > > > };
> > >
> > > Please keep the format in line with the rest of the file:
> > > Hexvalues are lowercase and no 0x after the "fpgamgr@".
> > > I'd say "And please put the node in its proper position
> > > according to its address", but I see just now, that the
> > > dtsi is all messed up right now anyway :-(
> > >
>
> "all messed up" seems kind of unclear and overstated here. From the
> context, I assume you mean that you are pointing out that the nodes
> are in more or less alphatetical order and not in order of address. Is
> that what you mean or is the dtsi really all messed up?
>
"more or less" was the thing that bugged me.
And for the record: I didn't try to blame anyone for this. I put
many of the nodes there myself ;-)
Regards,
Steffen
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web