Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1246132 > unrolled thread
| Started by | Dave Chinner <david@fromorbit.com> |
|---|---|
| First post | 2015-10-13 22:50 +0200 |
| Last post | 2015-10-13 23:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: randconfig build error with next-20151013, in fs/xfs/libxfs/xfs_alloc.c Dave Chinner <david@fromorbit.com> - 2015-10-13 22:50 +0200
Re: randconfig build error with next-20151013, in fs/xfs/libxfs/xfs_alloc.c Jim Davis <jim.epost@gmail.com> - 2015-10-13 23:10 +0200
Re: randconfig build error with next-20151013, in fs/xfs/libxfs/xfs_alloc.c Dave Chinner <david@fromorbit.com> - 2015-10-13 23:30 +0200
| From | Dave Chinner <david@fromorbit.com> |
|---|---|
| Date | 2015-10-13 22:50 +0200 |
| Subject | Re: randconfig build error with next-20151013, in fs/xfs/libxfs/xfs_alloc.c |
| Message-ID | <qjeGe-Xw-25@gated-at.bofh.it> |
On Tue, Oct 13, 2015 at 09:41:25AM -0700, Jim Davis wrote:
> Building with the attached random configuration file,
>
> fs/built-in.o: In function `xfs_free_ag_extent':
> /home/jim/linux-next/fs/xfs/libxfs/xfs_alloc.c:1813: undefined
> reference to `xfsstats'
Please test the patch below.
-Dave.
--
Dave Chinner
david@fromorbit.com
xfs: stats are no longer dependent on CONFIG_PROC_FS
From: Dave Chinner <dchinner@redhat.com>
So we need to fix the makefile to understand this, otherwise build
errors with CONFIG_PROC_FS=n occur.
Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
fs/xfs/Makefile | 2 +-
fs/xfs/xfs_stats.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
index 2fbf910..6506e87 100644
--- a/fs/xfs/Makefile
+++ b/fs/xfs/Makefile
@@ -84,6 +84,7 @@ xfs-y += xfs_aops.o \
xfs_message.o \
xfs_mount.o \
xfs_mru_cache.o \
+ xfs_stats.o \
xfs_super.o \
xfs_symlink.o \
xfs_sysfs.o \
@@ -118,7 +119,6 @@ xfs-$(CONFIG_XFS_QUOTA) += xfs_dquot.o \
xfs-$(CONFIG_XFS_RT) += xfs_rtalloc.o
xfs-$(CONFIG_XFS_POSIX_ACL) += xfs_acl.o
-xfs-$(CONFIG_PROC_FS) += xfs_stats.o
xfs-$(CONFIG_SYSCTL) += xfs_sysctl.o
xfs-$(CONFIG_COMPAT) += xfs_ioctl32.o
xfs-$(CONFIG_NFSD_PNFS) += xfs_pnfs.o
diff --git a/fs/xfs/xfs_stats.c b/fs/xfs/xfs_stats.c
index bd50619..8686df6 100644
--- a/fs/xfs/xfs_stats.c
+++ b/fs/xfs/xfs_stats.c
@@ -161,6 +161,7 @@ static const struct file_operations xqmstat_proc_fops = {
};
#endif /* CONFIG_XFS_QUOTA */
+#ifdef CONFIG_PROC_FS
int
xfs_init_procfs(void)
{
@@ -191,3 +192,4 @@ xfs_cleanup_procfs(void)
{
remove_proc_subtree("fs/xfs", NULL);
}
+#endif /* CONFIG_PROC_FS */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jim Davis <jim.epost@gmail.com> |
|---|---|
| Date | 2015-10-13 23:10 +0200 |
| Subject | Re: randconfig build error with next-20151013, in fs/xfs/libxfs/xfs_alloc.c |
| Message-ID | <qjeZB-1zx-27@gated-at.bofh.it> |
| In reply to | #1246132 |
On Tue, Oct 13, 2015 at 1:41 PM, Dave Chinner <david@fromorbit.com> wrote:
> On Tue, Oct 13, 2015 at 09:41:25AM -0700, Jim Davis wrote:
>> Building with the attached random configuration file,
>>
>> fs/built-in.o: In function `xfs_free_ag_extent':
>> /home/jim/linux-next/fs/xfs/libxfs/xfs_alloc.c:1813: undefined
>> reference to `xfsstats'
>
> Please test the patch below.
>
> -Dave.
> --
> Dave Chinner
> david@fromorbit.com
>
>
> xfs: stats are no longer dependent on CONFIG_PROC_FS
>
> From: Dave Chinner <dchinner@redhat.com>
>
> So we need to fix the makefile to understand this, otherwise build
> errors with CONFIG_PROC_FS=n occur.
>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> fs/xfs/Makefile | 2 +-
> fs/xfs/xfs_stats.c | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
> index 2fbf910..6506e87 100644
> --- a/fs/xfs/Makefile
> +++ b/fs/xfs/Makefile
> @@ -84,6 +84,7 @@ xfs-y += xfs_aops.o \
> xfs_message.o \
> xfs_mount.o \
> xfs_mru_cache.o \
> + xfs_stats.o \
> xfs_super.o \
> xfs_symlink.o \
> xfs_sysfs.o \
> @@ -118,7 +119,6 @@ xfs-$(CONFIG_XFS_QUOTA) += xfs_dquot.o \
> xfs-$(CONFIG_XFS_RT) += xfs_rtalloc.o
>
> xfs-$(CONFIG_XFS_POSIX_ACL) += xfs_acl.o
> -xfs-$(CONFIG_PROC_FS) += xfs_stats.o
> xfs-$(CONFIG_SYSCTL) += xfs_sysctl.o
> xfs-$(CONFIG_COMPAT) += xfs_ioctl32.o
> xfs-$(CONFIG_NFSD_PNFS) += xfs_pnfs.o
> diff --git a/fs/xfs/xfs_stats.c b/fs/xfs/xfs_stats.c
> index bd50619..8686df6 100644
> --- a/fs/xfs/xfs_stats.c
> +++ b/fs/xfs/xfs_stats.c
> @@ -161,6 +161,7 @@ static const struct file_operations xqmstat_proc_fops = {
> };
> #endif /* CONFIG_XFS_QUOTA */
>
> +#ifdef CONFIG_PROC_FS
> int
> xfs_init_procfs(void)
> {
> @@ -191,3 +192,4 @@ xfs_cleanup_procfs(void)
> {
> remove_proc_subtree("fs/xfs", NULL);
> }
> +#endif /* CONFIG_PROC_FS */
Looks good! Thanks.
Tested-by: Jim Davis <jim.epost@gmail.com>
--
Jim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Dave Chinner <david@fromorbit.com> |
|---|---|
| Date | 2015-10-13 23:30 +0200 |
| Message-ID | <qjfiY-1XD-47@gated-at.bofh.it> |
| In reply to | #1246152 |
On Tue, Oct 13, 2015 at 02:08:28PM -0700, Jim Davis wrote: > On Tue, Oct 13, 2015 at 1:41 PM, Dave Chinner <david@fromorbit.com> wrote: > > On Tue, Oct 13, 2015 at 09:41:25AM -0700, Jim Davis wrote: > >> Building with the attached random configuration file, > >> > >> fs/built-in.o: In function `xfs_free_ag_extent': > >> /home/jim/linux-next/fs/xfs/libxfs/xfs_alloc.c:1813: undefined > >> reference to `xfsstats' > > > > Please test the patch below. > > Looks good! Thanks. > > Tested-by: Jim Davis <jim.epost@gmail.com> Thanks for testing it quickly, Jim. Cheers, Dave. -- Dave Chinner david@fromorbit.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web