Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1245075 > unrolled thread

[PATCH v2 0/4] soc: ti: knav_qmss: enable accumulator queue support

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 0/4] soc: ti: knav_qmss: enable accumulator queue support Murali Karicheri <m-karicheri2@ti.com> - 2015-10-12 21:50 +0200
    [PATCH 1/4] Documentation: dt: soc: move driver description to a separate document Murali Karicheri <m-karicheri2@ti.com> - 2015-10-12 21:50 +0200
      Re: [PATCH 1/4] Documentation: dt: soc: move driver description to a  separate document Rob Herring <robh+dt@kernel.org> - 2015-10-13 16:50 +0200
        Re: [PATCH 1/4] Documentation: dt: soc: move driver description to  a separate document Murali Karicheri <m-karicheri2@ti.com> - 2015-10-13 17:50 +0200
        Re: [PATCH 1/4] Documentation: dt: soc: move driver description to  a separate document Murali Karicheri <m-karicheri2@ti.com> - 2015-10-13 19:40 +0200
          Re: [PATCH 1/4] Documentation: dt: soc: move driver description to a  separate document Rob Herring <robh+dt@kernel.org> - 2015-10-13 20:10 +0200
            Re: [PATCH 1/4] Documentation: dt: soc: move driver description to  a separate document Murali Karicheri <m-karicheri2@ti.com> - 2015-10-13 20:30 +0200
    Re: [PATCH v2 0/4] soc: ti: knav_qmss: enable accumulator queue support Murali Karicheri <m-karicheri2@ti.com> - 2015-10-12 22:00 +0200
    Re: [PATCH v2 0/4] soc: ti: knav_qmss: enable accumulator queue support Murali Karicheri <m-karicheri2@ti.com> - 2015-10-13 16:00 +0200
      Re: [PATCH v2 0/4] soc: ti: knav_qmss: enable accumulator queue  support santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-10-13 18:10 +0200
        Re: [PATCH v2 0/4] soc: ti: knav_qmss: enable accumulator queue support Murali Karicheri <m-karicheri2@ti.com> - 2015-10-13 18:20 +0200
          Re: [PATCH v2 0/4] soc: ti: knav_qmss: enable accumulator queue  support santosh shilimkar <santosh.shilimkar@oracle.com> - 2015-10-13 18:30 +0200
            Re: [PATCH v2 0/4] soc: ti: knav_qmss: enable accumulator queue support Murali Karicheri <m-karicheri2@ti.com> - 2015-10-13 18:50 +0200

#1245075 — [PATCH v2 0/4] soc: ti: knav_qmss: enable accumulator queue support

This patch series enable accumulator queue support for K2 SoCs. Accumulator
queues are a type of qmss queue that is monitored by the PDSP firmware and
accumulated. Host is interrupted by PDSP firmware when packets become
available in a ring buffer shared between the host and PDSP.

There was an issue raised when merging the original patch set at
 (1) https://lkml.org/lkml/2015/9/4/681
	[PATCH v1 1/2] soc: ti: display firmware file name as part of boot log
 (2) https://lkml.org/lkml/2015/9/4/680
	[PATCH v1 2/2] ARM: dts: keystone: enable accumulator channels

This series fixes the issues raised against above patch set. Key issues
addressed.

	- Remove the firmware filename from DT and add it to the driver.
	  Use a name ks2_qmss_pdsp_acc48.bin. The idea is this can be a
	  soft link pointing to the real firmware file in file system.

	- Move the description of the driver design from DT document to one
	  under Documentation/arm/keystone/knav-qmss.txt. Update the this
	  document with location of acc firmware available under
	  linux-firmware.git.

Additionally added accumulator queue support optional so that lack of
firmware in the file system will not cause other queue types not available
due to driver probe failure.

Murali Karicheri (4):
  Documentation: dt: soc: move driver description to a separate document
  soc: ti: add firmware file name as part of the driver
  ARM: dts: keystone: enable accumulator channels
  soc: ti: qmss: make acc queue support optional in the driver

 Documentation/arm/keystone/knav-qmss.txt           | 56 ++++++++++++++++++
 .../bindings/soc/ti/keystone-navigator-qmss.txt    | 21 ++-----
 arch/arm/boot/dts/k2e-netcp.dtsi                   | 23 ++++++++
 arch/arm/boot/dts/k2hk-netcp.dtsi                  | 24 ++++++++
 arch/arm/boot/dts/k2l-netcp.dtsi                   | 23 ++++++++
 drivers/soc/ti/knav_qmss.h                         |  3 +-
 drivers/soc/ti/knav_qmss_acc.c                     | 10 +++-
 drivers/soc/ti/knav_qmss_queue.c                   | 67 ++++++++++++++--------
 8 files changed, 183 insertions(+), 44 deletions(-)
 create mode 100644 Documentation/arm/keystone/knav-qmss.txt

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1245078 — [PATCH 1/4] Documentation: dt: soc: move driver description to a separate document

Currently the DT bindings have details about the driver as well. This
patch moves this to a separate document for knav qmss driver so that
driver detail update can be done as needed without polluting the DT
bindings description.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
---
 Documentation/arm/keystone/knav-qmss.txt           | 24 ++++++++++++++++++++++
 .../bindings/soc/ti/keystone-navigator-qmss.txt    | 20 ++++--------------
 2 files changed, 28 insertions(+), 16 deletions(-)
 create mode 100644 Documentation/arm/keystone/knav-qmss.txt

diff --git a/Documentation/arm/keystone/knav-qmss.txt b/Documentation/arm/keystone/knav-qmss.txt
new file mode 100644
index 0000000..79946d1
--- /dev/null
+++ b/Documentation/arm/keystone/knav-qmss.txt
@@ -0,0 +1,24 @@
+* Texas Instruments Keystone Navigator Queue Management SubSystem driver
+
+Driver source code path
+  drivers/soc/ti/knav_qmss.c
+  drivers/soc/ti/knav_qmss_acc.c
+
+The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
+the main hardware sub system which forms the backbone of the Keystone
+multi-core Navigator. QMSS consist of queue managers, packed-data structure
+processors(PDSP), linking RAM, descriptor pools and infrastructure
+Packet DMA.
+The Queue Manager is a hardware module that is responsible for accelerating
+management of the packet queues. Packets are queued/de-queued by writing or
+reading descriptor address to a particular memory mapped location. The PDSPs
+perform QMSS related functions like accumulation, QoS, or event management.
+Linking RAM registers are used to link the descriptors which are stored in
+descriptor RAM. Descriptor RAM is configurable as internal or external memory.
+The QMSS driver manages the PDSP setups, linking RAM regions,
+queue pool management (allocation, push, pop and notify) and descriptor
+pool management.
+
+knav qmss driver provides a set of APIs to drivers to open/close qmss queues,
+allocate descriptor pools, map the descriptors, push/pop to queues etc. For
+details of the available APIs, please refers to include/linux/soc/ti/knav_qmss.h
diff --git a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
index d8e8cdb..2cecea1 100644
--- a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
+++ b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
@@ -1,20 +1,8 @@
-* Texas Instruments Keystone Navigator Queue Management SubSystem driver
-
-The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
-the main hardware sub system which forms the backbone of the Keystone
-multi-core Navigator. QMSS consist of queue managers, packed-data structure
-processors(PDSP), linking RAM, descriptor pools and infrastructure
-Packet DMA.
-The Queue Manager is a hardware module that is responsible for accelerating
-management of the packet queues. Packets are queued/de-queued by writing or
-reading descriptor address to a particular memory mapped location. The PDSPs
-perform QMSS related functions like accumulation, QoS, or event management.
-Linking RAM registers are used to link the descriptors which are stored in
-descriptor RAM. Descriptor RAM is configurable as internal or external memory.
-The QMSS driver manages the PDSP setups, linking RAM regions,
-queue pool management (allocation, push, pop and notify) and descriptor
-pool management.
+* Texas Instruments Keystone Navigator (knav) Queue Management SubSystem driver
+  DT bindings
 
+For details of the driver, please refer to
+Documentation/arm/keystone/knav-qmss.txt
 
 Required properties:
 - compatible	: Must be "ti,keystone-navigator-qmss";
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245808 — Re: [PATCH 1/4] Documentation: dt: soc: move driver description to a separate document

On Mon, Oct 12, 2015 at 2:46 PM, Murali Karicheri <m-karicheri2@ti.com> wrote:
> Currently the DT bindings have details about the driver as well. This
> patch moves this to a separate document for knav qmss driver so that
> driver detail update can be done as needed without polluting the DT
> bindings description.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> ---
>  Documentation/arm/keystone/knav-qmss.txt           | 24 ++++++++++++++++++++++
>  .../bindings/soc/ti/keystone-navigator-qmss.txt    | 20 ++++--------------
>  2 files changed, 28 insertions(+), 16 deletions(-)
>  create mode 100644 Documentation/arm/keystone/knav-qmss.txt
>
> diff --git a/Documentation/arm/keystone/knav-qmss.txt b/Documentation/arm/keystone/knav-qmss.txt
> new file mode 100644
> index 0000000..79946d1
> --- /dev/null
> +++ b/Documentation/arm/keystone/knav-qmss.txt
> @@ -0,0 +1,24 @@
> +* Texas Instruments Keystone Navigator Queue Management SubSystem driver
> +
> +Driver source code path
> +  drivers/soc/ti/knav_qmss.c
> +  drivers/soc/ti/knav_qmss_acc.c
> +
> +The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
> +the main hardware sub system which forms the backbone of the Keystone
> +multi-core Navigator. QMSS consist of queue managers, packed-data structure
> +processors(PDSP), linking RAM, descriptor pools and infrastructure
> +Packet DMA.
> +The Queue Manager is a hardware module that is responsible for accelerating
> +management of the packet queues. Packets are queued/de-queued by writing or
> +reading descriptor address to a particular memory mapped location. The PDSPs
> +perform QMSS related functions like accumulation, QoS, or event management.
> +Linking RAM registers are used to link the descriptors which are stored in
> +descriptor RAM. Descriptor RAM is configurable as internal or external memory.
> +The QMSS driver manages the PDSP setups, linking RAM regions,
> +queue pool management (allocation, push, pop and notify) and descriptor
> +pool management.
> +
> +knav qmss driver provides a set of APIs to drivers to open/close qmss queues,
> +allocate descriptor pools, map the descriptors, push/pop to queues etc. For
> +details of the available APIs, please refers to include/linux/soc/ti/knav_qmss.h
> diff --git a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
> index d8e8cdb..2cecea1 100644
> --- a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
> +++ b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
> @@ -1,20 +1,8 @@
> -* Texas Instruments Keystone Navigator Queue Management SubSystem driver
> -
> -The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
> -the main hardware sub system which forms the backbone of the Keystone
> -multi-core Navigator. QMSS consist of queue managers, packed-data structure
> -processors(PDSP), linking RAM, descriptor pools and infrastructure
> -Packet DMA.
> -The Queue Manager is a hardware module that is responsible for accelerating
> -management of the packet queues. Packets are queued/de-queued by writing or
> -reading descriptor address to a particular memory mapped location. The PDSPs
> -perform QMSS related functions like accumulation, QoS, or event management.
> -Linking RAM registers are used to link the descriptors which are stored in
> -descriptor RAM. Descriptor RAM is configurable as internal or external memory.
> -The QMSS driver manages the PDSP setups, linking RAM regions,
> -queue pool management (allocation, push, pop and notify) and descriptor
> -pool management.

Only the last sentence seems to be about the driver and is rather
obvious (a driver manages the h/w). I would leave all this as-is
currently.

Rob

> +* Texas Instruments Keystone Navigator (knav) Queue Management SubSystem driver
> +  DT bindings
>
> +For details of the driver, please refer to
> +Documentation/arm/keystone/knav-qmss.txt
>
>  Required properties:
>  - compatible   : Must be "ti,keystone-navigator-qmss";
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245868 — Re: [PATCH 1/4] Documentation: dt: soc: move driver description to a separate document

On 10/13/2015 10:42 AM, Rob Herring wrote:
> On Mon, Oct 12, 2015 at 2:46 PM, Murali Karicheri <m-karicheri2@ti.com> wrote:
>> Currently the DT bindings have details about the driver as well. This
>> patch moves this to a separate document for knav qmss driver so that
>> driver detail update can be done as needed without polluting the DT
>> bindings description.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> ---
>>   Documentation/arm/keystone/knav-qmss.txt           | 24 ++++++++++++++++++++++
>>   .../bindings/soc/ti/keystone-navigator-qmss.txt    | 20 ++++--------------
>>   2 files changed, 28 insertions(+), 16 deletions(-)
>>   create mode 100644 Documentation/arm/keystone/knav-qmss.txt
>>
>> diff --git a/Documentation/arm/keystone/knav-qmss.txt b/Documentation/arm/keystone/knav-qmss.txt
>> new file mode 100644
>> index 0000000..79946d1
>> --- /dev/null
>> +++ b/Documentation/arm/keystone/knav-qmss.txt
>> @@ -0,0 +1,24 @@
>> +* Texas Instruments Keystone Navigator Queue Management SubSystem driver
>> +
>> +Driver source code path
>> +  drivers/soc/ti/knav_qmss.c
>> +  drivers/soc/ti/knav_qmss_acc.c
>> +
>> +The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
>> +the main hardware sub system which forms the backbone of the Keystone
>> +multi-core Navigator. QMSS consist of queue managers, packed-data structure
>> +processors(PDSP), linking RAM, descriptor pools and infrastructure
>> +Packet DMA.
>> +The Queue Manager is a hardware module that is responsible for accelerating
>> +management of the packet queues. Packets are queued/de-queued by writing or
>> +reading descriptor address to a particular memory mapped location. The PDSPs
>> +perform QMSS related functions like accumulation, QoS, or event management.
>> +Linking RAM registers are used to link the descriptors which are stored in
>> +descriptor RAM. Descriptor RAM is configurable as internal or external memory.
>> +The QMSS driver manages the PDSP setups, linking RAM regions,
>> +queue pool management (allocation, push, pop and notify) and descriptor
>> +pool management.
>> +
>> +knav qmss driver provides a set of APIs to drivers to open/close qmss queues,
>> +allocate descriptor pools, map the descriptors, push/pop to queues etc. For
>> +details of the available APIs, please refers to include/linux/soc/ti/knav_qmss.h
>> diff --git a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>> index d8e8cdb..2cecea1 100644
>> --- a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>> +++ b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>> @@ -1,20 +1,8 @@
>> -* Texas Instruments Keystone Navigator Queue Management SubSystem driver
>> -
>> -The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
>> -the main hardware sub system which forms the backbone of the Keystone
>> -multi-core Navigator. QMSS consist of queue managers, packed-data structure
>> -processors(PDSP), linking RAM, descriptor pools and infrastructure
>> -Packet DMA.
>> -The Queue Manager is a hardware module that is responsible for accelerating
>> -management of the packet queues. Packets are queued/de-queued by writing or
>> -reading descriptor address to a particular memory mapped location. The PDSPs
>> -perform QMSS related functions like accumulation, QoS, or event management.
>> -Linking RAM registers are used to link the descriptors which are stored in
>> -descriptor RAM. Descriptor RAM is configurable as internal or external memory.
>> -The QMSS driver manages the PDSP setups, linking RAM regions,
>> -queue pool management (allocation, push, pop and notify) and descriptor
>> -pool management.
>
> Only the last sentence seems to be about the driver and is rather
> obvious (a driver manages the h/w). I would leave all this as-is
> currently.
>
> Rob
>
Rob,

I promise I will fix this in my next opportunity. Also there is similar 
clean up needed for knav dma DT documentation and Netcp documentations. 
It is in my TODO list.

Thanks.

Murali
>> +* Texas Instruments Keystone Navigator (knav) Queue Management SubSystem driver
>> +  DT bindings
>>
>> +For details of the driver, please refer to
>> +Documentation/arm/keystone/knav-qmss.txt
>>
>>   Required properties:
>>   - compatible   : Must be "ti,keystone-navigator-qmss";
>> --
>> 1.9.1
>>
>
>


-- 
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245970 — Re: [PATCH 1/4] Documentation: dt: soc: move driver description to a separate document

On 10/13/2015 10:42 AM, Rob Herring wrote:
> On Mon, Oct 12, 2015 at 2:46 PM, Murali Karicheri <m-karicheri2@ti.com> wrote:
>> Currently the DT bindings have details about the driver as well. This
>> patch moves this to a separate document for knav qmss driver so that
>> driver detail update can be done as needed without polluting the DT
>> bindings description.
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> ---
>>   Documentation/arm/keystone/knav-qmss.txt           | 24 ++++++++++++++++++++++
>>   .../bindings/soc/ti/keystone-navigator-qmss.txt    | 20 ++++--------------
>>   2 files changed, 28 insertions(+), 16 deletions(-)
>>   create mode 100644 Documentation/arm/keystone/knav-qmss.txt
>>
>> diff --git a/Documentation/arm/keystone/knav-qmss.txt b/Documentation/arm/keystone/knav-qmss.txt
>> new file mode 100644
>> index 0000000..79946d1
>> --- /dev/null
>> +++ b/Documentation/arm/keystone/knav-qmss.txt
>> @@ -0,0 +1,24 @@
>> +* Texas Instruments Keystone Navigator Queue Management SubSystem driver
>> +
>> +Driver source code path
>> +  drivers/soc/ti/knav_qmss.c
>> +  drivers/soc/ti/knav_qmss_acc.c
>> +
>> +The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
>> +the main hardware sub system which forms the backbone of the Keystone
>> +multi-core Navigator. QMSS consist of queue managers, packed-data structure
>> +processors(PDSP), linking RAM, descriptor pools and infrastructure
>> +Packet DMA.
>> +The Queue Manager is a hardware module that is responsible for accelerating
>> +management of the packet queues. Packets are queued/de-queued by writing or
>> +reading descriptor address to a particular memory mapped location. The PDSPs
>> +perform QMSS related functions like accumulation, QoS, or event management.
>> +Linking RAM registers are used to link the descriptors which are stored in
>> +descriptor RAM. Descriptor RAM is configurable as internal or external memory.
>> +The QMSS driver manages the PDSP setups, linking RAM regions,
>> +queue pool management (allocation, push, pop and notify) and descriptor
>> +pool management.
>> +
>> +knav qmss driver provides a set of APIs to drivers to open/close qmss queues,
>> +allocate descriptor pools, map the descriptors, push/pop to queues etc. For
>> +details of the available APIs, please refers to include/linux/soc/ti/knav_qmss.h
>> diff --git a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>> index d8e8cdb..2cecea1 100644
>> --- a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>> +++ b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>> @@ -1,20 +1,8 @@
>> -* Texas Instruments Keystone Navigator Queue Management SubSystem driver
>> -
>> -The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
>> -the main hardware sub system which forms the backbone of the Keystone
>> -multi-core Navigator. QMSS consist of queue managers, packed-data structure
>> -processors(PDSP), linking RAM, descriptor pools and infrastructure
>> -Packet DMA.
>> -The Queue Manager is a hardware module that is responsible for accelerating
>> -management of the packet queues. Packets are queued/de-queued by writing or
>> -reading descriptor address to a particular memory mapped location. The PDSPs
>> -perform QMSS related functions like accumulation, QoS, or event management.
>> -Linking RAM registers are used to link the descriptors which are stored in
>> -descriptor RAM. Descriptor RAM is configurable as internal or external memory.
>> -The QMSS driver manages the PDSP setups, linking RAM regions,
>> -queue pool management (allocation, push, pop and notify) and descriptor
>> -pool management.
>
> Only the last sentence seems to be about the driver and is rather
> obvious (a driver manages the h/w). I would leave all this as-is
> currently.
>
> Rob
>
Rob,

I am taking the liberty to add your Ack based on the above. I can remove 
it if you disagree.

Murali

>> +* Texas Instruments Keystone Navigator (knav) Queue Management SubSystem driver
>> +  DT bindings
>>
>> +For details of the driver, please refer to
>> +Documentation/arm/keystone/knav-qmss.txt
>>
>>   Required properties:
>>   - compatible   : Must be "ti,keystone-navigator-qmss";
>> --
>> 1.9.1
>>
>
>


-- 
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1246005 — Re: [PATCH 1/4] Documentation: dt: soc: move driver description to a separate document

On Tue, Oct 13, 2015 at 12:28 PM, Murali Karicheri <m-karicheri2@ti.com> wrote:
> On 10/13/2015 10:42 AM, Rob Herring wrote:
>>
>> On Mon, Oct 12, 2015 at 2:46 PM, Murali Karicheri <m-karicheri2@ti.com>
>> wrote:
>>>
>>> Currently the DT bindings have details about the driver as well. This
>>> patch moves this to a separate document for knav qmss driver so that
>>> driver detail update can be done as needed without polluting the DT
>>> bindings description.
>>>
>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>> ---
>>>   Documentation/arm/keystone/knav-qmss.txt           | 24
>>> ++++++++++++++++++++++
>>>   .../bindings/soc/ti/keystone-navigator-qmss.txt    | 20
>>> ++++--------------
>>>   2 files changed, 28 insertions(+), 16 deletions(-)
>>>   create mode 100644 Documentation/arm/keystone/knav-qmss.txt
>>>
>>> diff --git a/Documentation/arm/keystone/knav-qmss.txt
>>> b/Documentation/arm/keystone/knav-qmss.txt
>>> new file mode 100644
>>> index 0000000..79946d1
>>> --- /dev/null
>>> +++ b/Documentation/arm/keystone/knav-qmss.txt
>>> @@ -0,0 +1,24 @@
>>> +* Texas Instruments Keystone Navigator Queue Management SubSystem driver
>>> +
>>> +Driver source code path
>>> +  drivers/soc/ti/knav_qmss.c
>>> +  drivers/soc/ti/knav_qmss_acc.c
>>> +
>>> +The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
>>> +the main hardware sub system which forms the backbone of the Keystone
>>> +multi-core Navigator. QMSS consist of queue managers, packed-data
>>> structure
>>> +processors(PDSP), linking RAM, descriptor pools and infrastructure
>>> +Packet DMA.
>>> +The Queue Manager is a hardware module that is responsible for
>>> accelerating
>>> +management of the packet queues. Packets are queued/de-queued by writing
>>> or
>>> +reading descriptor address to a particular memory mapped location. The
>>> PDSPs
>>> +perform QMSS related functions like accumulation, QoS, or event
>>> management.
>>> +Linking RAM registers are used to link the descriptors which are stored
>>> in
>>> +descriptor RAM. Descriptor RAM is configurable as internal or external
>>> memory.
>>> +The QMSS driver manages the PDSP setups, linking RAM regions,
>>> +queue pool management (allocation, push, pop and notify) and descriptor
>>> +pool management.
>>> +
>>> +knav qmss driver provides a set of APIs to drivers to open/close qmss
>>> queues,
>>> +allocate descriptor pools, map the descriptors, push/pop to queues etc.
>>> For
>>> +details of the available APIs, please refers to
>>> include/linux/soc/ti/knav_qmss.h
>>> diff --git
>>> a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>>> b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>>> index d8e8cdb..2cecea1 100644
>>> ---
>>> a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>>> +++
>>> b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>>> @@ -1,20 +1,8 @@
>>> -* Texas Instruments Keystone Navigator Queue Management SubSystem driver
>>> -
>>> -The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
>>> -the main hardware sub system which forms the backbone of the Keystone
>>> -multi-core Navigator. QMSS consist of queue managers, packed-data
>>> structure
>>> -processors(PDSP), linking RAM, descriptor pools and infrastructure
>>> -Packet DMA.
>>> -The Queue Manager is a hardware module that is responsible for
>>> accelerating
>>> -management of the packet queues. Packets are queued/de-queued by writing
>>> or
>>> -reading descriptor address to a particular memory mapped location. The
>>> PDSPs
>>> -perform QMSS related functions like accumulation, QoS, or event
>>> management.
>>> -Linking RAM registers are used to link the descriptors which are stored
>>> in
>>> -descriptor RAM. Descriptor RAM is configurable as internal or external
>>> memory.
>>> -The QMSS driver manages the PDSP setups, linking RAM regions,
>>> -queue pool management (allocation, push, pop and notify) and descriptor
>>> -pool management.
>>
>>
>> Only the last sentence seems to be about the driver and is rather
>> obvious (a driver manages the h/w). I would leave all this as-is
>> currently.
>>
>> Rob
>>
> Rob,
>
> I am taking the liberty to add your Ack based on the above. I can remove it
> if you disagree.

No, I don't. I don't agree with moving this out of the binding. This
mostly sounds like a description of the h/w to me, so I'd like to keep
it. Most bindings are rather vague in this regard and I'd rather see
more description than less.

I also agree with Arnd's comment about not pointing to kernel docs.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1246026 — Re: [PATCH 1/4] Documentation: dt: soc: move driver description to a separate document

On 10/13/2015 02:01 PM, Rob Herring wrote:
> On Tue, Oct 13, 2015 at 12:28 PM, Murali Karicheri <m-karicheri2@ti.com> wrote:
>> On 10/13/2015 10:42 AM, Rob Herring wrote:
>>>
>>> On Mon, Oct 12, 2015 at 2:46 PM, Murali Karicheri <m-karicheri2@ti.com>
>>> wrote:
>>>>
>>>> Currently the DT bindings have details about the driver as well. This
>>>> patch moves this to a separate document for knav qmss driver so that
>>>> driver detail update can be done as needed without polluting the DT
>>>> bindings description.
>>>>
>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>> ---
>>>>    Documentation/arm/keystone/knav-qmss.txt           | 24
>>>> ++++++++++++++++++++++
>>>>    .../bindings/soc/ti/keystone-navigator-qmss.txt    | 20
>>>> ++++--------------
>>>>    2 files changed, 28 insertions(+), 16 deletions(-)
>>>>    create mode 100644 Documentation/arm/keystone/knav-qmss.txt
>>>>
>>>> diff --git a/Documentation/arm/keystone/knav-qmss.txt
>>>> b/Documentation/arm/keystone/knav-qmss.txt
>>>> new file mode 100644
>>>> index 0000000..79946d1
>>>> --- /dev/null
>>>> +++ b/Documentation/arm/keystone/knav-qmss.txt
>>>> @@ -0,0 +1,24 @@
>>>> +* Texas Instruments Keystone Navigator Queue Management SubSystem driver
>>>> +
>>>> +Driver source code path
>>>> +  drivers/soc/ti/knav_qmss.c
>>>> +  drivers/soc/ti/knav_qmss_acc.c
>>>> +
>>>> +The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
>>>> +the main hardware sub system which forms the backbone of the Keystone
>>>> +multi-core Navigator. QMSS consist of queue managers, packed-data
>>>> structure
>>>> +processors(PDSP), linking RAM, descriptor pools and infrastructure
>>>> +Packet DMA.
>>>> +The Queue Manager is a hardware module that is responsible for
>>>> accelerating
>>>> +management of the packet queues. Packets are queued/de-queued by writing
>>>> or
>>>> +reading descriptor address to a particular memory mapped location. The
>>>> PDSPs
>>>> +perform QMSS related functions like accumulation, QoS, or event
>>>> management.
>>>> +Linking RAM registers are used to link the descriptors which are stored
>>>> in
>>>> +descriptor RAM. Descriptor RAM is configurable as internal or external
>>>> memory.
>>>> +The QMSS driver manages the PDSP setups, linking RAM regions,
>>>> +queue pool management (allocation, push, pop and notify) and descriptor
>>>> +pool management.
>>>> +
>>>> +knav qmss driver provides a set of APIs to drivers to open/close qmss
>>>> queues,
>>>> +allocate descriptor pools, map the descriptors, push/pop to queues etc.
>>>> For
>>>> +details of the available APIs, please refers to
>>>> include/linux/soc/ti/knav_qmss.h
>>>> diff --git
>>>> a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>>>> b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>>>> index d8e8cdb..2cecea1 100644
>>>> ---
>>>> a/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>>>> +++
>>>> b/Documentation/devicetree/bindings/soc/ti/keystone-navigator-qmss.txt
>>>> @@ -1,20 +1,8 @@
>>>> -* Texas Instruments Keystone Navigator Queue Management SubSystem driver
>>>> -
>>>> -The QMSS (Queue Manager Sub System) found on Keystone SOCs is one of
>>>> -the main hardware sub system which forms the backbone of the Keystone
>>>> -multi-core Navigator. QMSS consist of queue managers, packed-data
>>>> structure
>>>> -processors(PDSP), linking RAM, descriptor pools and infrastructure
>>>> -Packet DMA.
>>>> -The Queue Manager is a hardware module that is responsible for
>>>> accelerating
>>>> -management of the packet queues. Packets are queued/de-queued by writing
>>>> or
>>>> -reading descriptor address to a particular memory mapped location. The
>>>> PDSPs
>>>> -perform QMSS related functions like accumulation, QoS, or event
>>>> management.
>>>> -Linking RAM registers are used to link the descriptors which are stored
>>>> in
>>>> -descriptor RAM. Descriptor RAM is configurable as internal or external
>>>> memory.
>>>> -The QMSS driver manages the PDSP setups, linking RAM regions,
>>>> -queue pool management (allocation, push, pop and notify) and descriptor
>>>> -pool management.
>>>
>>>
>>> Only the last sentence seems to be about the driver and is rather
>>> obvious (a driver manages the h/w). I would leave all this as-is
>>> currently.
>>>
>>> Rob
>>>
>> Rob,
>>
>> I am taking the liberty to add your Ack based on the above. I can remove it
>> if you disagree.
>
> No, I don't. I don't agree with moving this out of the binding. This
> mostly sounds like a description of the h/w to me, so I'd like to keep
> it. Most bindings are rather vague in this regard and I'd rather see
> more description than less.
>
Rob,

Sorry, I got you wrong. I will undo the DT documentation change and add 
the update for firmware to driver document.

> I also agree with Arnd's comment about not pointing to kernel docs.

Which comment are you talking about? I can't see his comment though 
against 1/4. I see he has acked 2/4. Can you clarify?

Do you have objections against the reference to driver documentation 
from DT Doc? Not sure why there should be any issue with the reference. 
But if you insists, I will remove below reference from the patch.

+For details of the driver, please refer to
+Documentation/arm/keystone/knav-qmss.txt

So here is the summary of what I will do.
1) Don't remove the driver description from DT document
2) remove the reference to driver document as per 1) this becomes redundant.
3) I will keep the driver description patch 2/4 to include the details 
about the driver only. No change to DT,

Hope this is what you would like me to do.

Thanks.

Murali
>
> Rob
>
>


-- 
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245084

On 10/12/2015 03:46 PM, Murali Karicheri wrote:
> This patch series enable accumulator queue support for K2 SoCs. Accumulator
> queues are a type of qmss queue that is monitored by the PDSP firmware and
> accumulated. Host is interrupted by PDSP firmware when packets become
> available in a ring buffer shared between the host and PDSP.
>
> There was an issue raised when merging the original patch set at
>   (1) https://lkml.org/lkml/2015/9/4/681
> 	[PATCH v1 1/2] soc: ti: display firmware file name as part of boot log
>   (2) https://lkml.org/lkml/2015/9/4/680
> 	[PATCH v1 2/2] ARM: dts: keystone: enable accumulator channels
>
> This series fixes the issues raised against above patch set. Key issues
> addressed.
>
> 	- Remove the firmware filename from DT and add it to the driver.
> 	  Use a name ks2_qmss_pdsp_acc48.bin. The idea is this can be a
> 	  soft link pointing to the real firmware file in file system.
>
> 	- Move the description of the driver design from DT document to one
> 	  under Documentation/arm/keystone/knav-qmss.txt. Update the this
> 	  document with location of acc firmware available under
> 	  linux-firmware.git.
>
> Additionally added accumulator queue support optional so that lack of
> firmware in the file system will not cause other queue types not available
> due to driver probe failure.
>
> Murali Karicheri (4):
>    Documentation: dt: soc: move driver description to a separate document
>    soc: ti: add firmware file name as part of the driver
>    ARM: dts: keystone: enable accumulator channels
>    soc: ti: qmss: make acc queue support optional in the driver
>
>   Documentation/arm/keystone/knav-qmss.txt           | 56 ++++++++++++++++++
>   .../bindings/soc/ti/keystone-navigator-qmss.txt    | 21 ++-----
>   arch/arm/boot/dts/k2e-netcp.dtsi                   | 23 ++++++++
>   arch/arm/boot/dts/k2hk-netcp.dtsi                  | 24 ++++++++
>   arch/arm/boot/dts/k2l-netcp.dtsi                   | 23 ++++++++
>   drivers/soc/ti/knav_qmss.h                         |  3 +-
>   drivers/soc/ti/knav_qmss_acc.c                     | 10 +++-
>   drivers/soc/ti/knav_qmss_queue.c                   | 67 ++++++++++++++--------
>   8 files changed, 183 insertions(+), 44 deletions(-)
>   create mode 100644 Documentation/arm/keystone/knav-qmss.txt
>
Will re-send 1/4 and 4/4 since I have messed up the patch prefix.

-- 
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245742

On 10/12/2015 03:46 PM, Murali Karicheri wrote:
> This patch series enable accumulator queue support for K2 SoCs. Accumulator
> queues are a type of qmss queue that is monitored by the PDSP firmware and
> accumulated. Host is interrupted by PDSP firmware when packets become
> available in a ring buffer shared between the host and PDSP.
>
> There was an issue raised when merging the original patch set at
>   (1) https://lkml.org/lkml/2015/9/4/681
> 	[PATCH v1 1/2] soc: ti: display firmware file name as part of boot log
>   (2) https://lkml.org/lkml/2015/9/4/680
> 	[PATCH v1 2/2] ARM: dts: keystone: enable accumulator channels
>
> This series fixes the issues raised against above patch set. Key issues
> addressed.
>
> 	- Remove the firmware filename from DT and add it to the driver.
> 	  Use a name ks2_qmss_pdsp_acc48.bin. The idea is this can be a
> 	  soft link pointing to the real firmware file in file system.
>
> 	- Move the description of the driver design from DT document to one
> 	  under Documentation/arm/keystone/knav-qmss.txt. Update the this
> 	  document with location of acc firmware available under
> 	  linux-firmware.git.
>
> Additionally added accumulator queue support optional so that lack of
> firmware in the file system will not cause other queue types not available
> due to driver probe failure.
>
> Murali Karicheri (4):
>    Documentation: dt: soc: move driver description to a separate document
>    soc: ti: add firmware file name as part of the driver
>    ARM: dts: keystone: enable accumulator channels
>    soc: ti: qmss: make acc queue support optional in the driver
>
>   Documentation/arm/keystone/knav-qmss.txt           | 56 ++++++++++++++++++
>   .../bindings/soc/ti/keystone-navigator-qmss.txt    | 21 ++-----
>   arch/arm/boot/dts/k2e-netcp.dtsi                   | 23 ++++++++
>   arch/arm/boot/dts/k2hk-netcp.dtsi                  | 24 ++++++++
>   arch/arm/boot/dts/k2l-netcp.dtsi                   | 23 ++++++++
>   drivers/soc/ti/knav_qmss.h                         |  3 +-
>   drivers/soc/ti/knav_qmss_acc.c                     | 10 +++-
>   drivers/soc/ti/knav_qmss_queue.c                   | 67 ++++++++++++++--------
>   8 files changed, 183 insertions(+), 44 deletions(-)
>   create mode 100644 Documentation/arm/keystone/knav-qmss.txt
>
Santosh, Arnd,

Could you please review and let me know if there is any comment. If 
looks good, could you please merge to v4.4 next branch?

Murali
-- 
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245877 — Re: [PATCH v2 0/4] soc: ti: knav_qmss: enable accumulator queue support

On 10/13/2015 6:56 AM, Murali Karicheri wrote:
> On 10/12/2015 03:46 PM, Murali Karicheri wrote:
>> This patch series enable accumulator queue support for K2 SoCs.

> Santosh, Arnd,
>
> Could you please review and let me know if there is any comment. If
> looks good, could you please merge to v4.4 next branch?
>
Please report the series updating the comments from Arnd. Also split
the series into drivers and dts updates.

Regards,
Santosh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245883

Santosh,

On 10/13/2015 12:01 PM, santosh shilimkar wrote:
> On 10/13/2015 6:56 AM, Murali Karicheri wrote:
>> On 10/12/2015 03:46 PM, Murali Karicheri wrote:
>>> This patch series enable accumulator queue support for K2 SoCs.
>
>> Santosh, Arnd,
>>
>> Could you please review and let me know if there is any comment. If
>> looks good, could you please merge to v4.4 next branch?
>>
> Please report the series updating the comments from Arnd. Also split
> the series into drivers and dts updates.

The cover letter already summarize this as a comment against v1 even 
though it didn't mention Arnd's name. Is it usual to describe the 
reviewers name in the change log? I thought we just describe the comment 
addressed, not who has commented. Not??

About splitting the series, it was done so since both is being pulled by 
you. If needed, I can do the split. Let me know.

Murali

>
> Regards,
> Santosh
>
>


-- 
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245890 — Re: [PATCH v2 0/4] soc: ti: knav_qmss: enable accumulator queue support

On 10/13/2015 9:14 AM, Murali Karicheri wrote:
> Santosh,
>
> On 10/13/2015 12:01 PM, santosh shilimkar wrote:
>> On 10/13/2015 6:56 AM, Murali Karicheri wrote:
>>> On 10/12/2015 03:46 PM, Murali Karicheri wrote:
>>>> This patch series enable accumulator queue support for K2 SoCs.
>>
>>> Santosh, Arnd,
>>>
>>> Could you please review and let me know if there is any comment. If
>>> looks good, could you please merge to v4.4 next branch?
>>>
>> Please report the series updating the comments from Arnd. Also split
>> the series into drivers and dts updates.
s/report/repost

>
> The cover letter already summarize this as a comment against v1 even
> though it didn't mention Arnd's name. Is it usual to describe the
> reviewers name in the change log? I thought we just describe the comment
> addressed, not who has commented. Not??
>
I didn't mean report. sorry. Just repost the series including ack tag.

> About splitting the series, it was done so since both is being pulled by
> you. If needed, I can do the split. Let me know.
>
DTS and driver changes goes to different topics so split it, please.

Regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1245900

On 10/13/2015 12:21 PM, santosh shilimkar wrote:
> On 10/13/2015 9:14 AM, Murali Karicheri wrote:
>> Santosh,
>>
>> On 10/13/2015 12:01 PM, santosh shilimkar wrote:
>>> On 10/13/2015 6:56 AM, Murali Karicheri wrote:
>>>> On 10/12/2015 03:46 PM, Murali Karicheri wrote:
>>>>> This patch series enable accumulator queue support for K2 SoCs.
>>>
>>>> Santosh, Arnd,
>>>>
>>>> Could you please review and let me know if there is any comment. If
>>>> looks good, could you please merge to v4.4 next branch?
>>>>
>>> Please report the series updating the comments from Arnd. Also split
>>> the series into drivers and dts updates.
> s/report/repost
>
>>
>> The cover letter already summarize this as a comment against v1 even
>> though it didn't mention Arnd's name. Is it usual to describe the
>> reviewers name in the change log? I thought we just describe the comment
>> addressed, not who has commented. Not??
>>
> I didn't mean report. sorry. Just repost the series including ack tag.
>
>> About splitting the series, it was done so since both is being pulled by
>> you. If needed, I can do the split. Let me know.
>>
> DTS and driver changes goes to different topics so split it, please.
Ok. No issues. I will be posting this right away.

Murali
>
> Regards,
> Santosh
>


-- 
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web