Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1248122 > unrolled thread
| Started by | Jon Mason <jonmason@broadcom.com> |
|---|---|
| First post | 2015-10-15 22:00 +0200 |
| Last post | 2015-10-15 23:20 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v3 0/10] clk: iproc: add support for BCM NS, NSP, and NS2 Jon Mason <jonmason@broadcom.com> - 2015-10-15 22:00 +0200
[PATCH v3 01/10] ARM: cygnus: fix link failures when CONFIG_COMMON_CLK_IPROC is disabled Jon Mason <jonmason@broadcom.com> - 2015-10-15 22:00 +0200
Re: [PATCH v3 01/10] ARM: cygnus: fix link failures when CONFIG_COMMON_CLK_IPROC is disabled Scott Branden <sbranden@broadcom.com> - 2015-10-15 22:30 +0200
Re: [PATCH v3 01/10] ARM: cygnus: fix link failures when CONFIG_COMMON_CLK_IPROC is disabled Jon Mason <jonmason@broadcom.com> - 2015-10-15 23:10 +0200
Re: [PATCH v3 01/10] ARM: cygnus: fix link failures when CONFIG_COMMON_CLK_IPROC is disabled Hauke Mehrtens <hauke@hauke-m.de> - 2015-10-15 23:20 +0200
| From | Jon Mason <jonmason@broadcom.com> |
|---|---|
| Date | 2015-10-15 22:00 +0200 |
| Subject | [PATCH v3 0/10] clk: iproc: add support for BCM NS, NSP, and NS2 |
| Message-ID | <qjWHg-7WB-9@gated-at.bofh.it> |
v3 - Added a patch to fix cygnus clk link failures, and added back the DT documentation patches that were removed from v2. v2 - Added a patch to change the Cygnus clk macros to uppercase, removed the device tree changes from the series (will send out those as an RFC), and other minor changes that Stephen Boyd requested. This patch series adds support for the Broadcom Northstar, Northstar Plus, and Northstar 2 clocks. Some slight modifications were necessary to clk-iproc-pll to get Northstar and Northstar Plus working, due to differences in register layout. This is the reason why the first patch is necessary. Some more modifications were necessary to clk-iproc-pll to get Northstar 2 working, due to differences in register layout (and resulting fallout in Cygnus and NSP). This is the reason why the sixth and seventh patches are necessary. The fifth patch is clean-up to prevent accidentally forgetting to adjust for the base write errata (which happened a few times, but was caught in internal review). Thanks, Jon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jon Mason <jonmason@broadcom.com> |
|---|---|
| Date | 2015-10-15 22:00 +0200 |
| Subject | [PATCH v3 01/10] ARM: cygnus: fix link failures when CONFIG_COMMON_CLK_IPROC is disabled |
| Message-ID | <qjWQX-880-33@gated-at.bofh.it> |
| In reply to | #1248122 |
From: Arnd Bergmann <arnd@arndb.de> When CONFIG_CYGNUS is set but CONFIG_COMMON_CLK_IPROC is disabled, the following link failures are caused: drivers/built-in.o: In function `cygnus_armpll_init': :(.init.text+0x1d290): undefined reference to `iproc_armpll_setup' drivers/built-in.o: In function `cygnus_genpll_clk_init': :(.init.text+0x1d2c4): undefined reference to `iproc_pll_clk_setup' drivers/built-in.o: In function `cygnus_lcpll0_clk_init': :(.init.text+0x1d304): undefined reference to `iproc_pll_clk_setup' drivers/built-in.o: In function `cygnus_mipipll_clk_init': :(.init.text+0x1d344): undefined reference to `iproc_pll_clk_setup' drivers/built-in.o: In function `cygnus_asiu_init': :(.init.text+0x1d370): undefined reference to `iproc_asiu_setup' It is fixed it by always selecting COMMON_CLK_IPROC from ARCH_BCM_IPROC, and making COMMON_CLK_IPROC a silent option (thus preventing it from being erroneously disabled by a user). Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Jon Mason <jonmason@broadcom.com> --- arch/arm/mach-bcm/Kconfig | 2 +- drivers/clk/bcm/Kconfig | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig index 1319c3c..84bd265 100644 --- a/arch/arm/mach-bcm/Kconfig +++ b/arch/arm/mach-bcm/Kconfig @@ -14,7 +14,7 @@ config ARCH_BCM_IPROC select HAVE_ARM_SCU if SMP select HAVE_ARM_TWD if SMP select ARM_GLOBAL_TIMER - + select COMMON_CLK_IPROC select CLKSRC_MMIO select ARCH_REQUIRE_GPIOLIB select ARM_AMBA diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig index 88febf5..46ee475 100644 --- a/drivers/clk/bcm/Kconfig +++ b/drivers/clk/bcm/Kconfig @@ -9,10 +9,8 @@ config CLK_BCM_KONA in the BCM281xx and BCM21664 families. config COMMON_CLK_IPROC - bool "Broadcom iProc clock support" - depends on ARCH_BCM_IPROC + bool depends on COMMON_CLK - default ARCH_BCM_IPROC help Enable common clock framework support for Broadcom SoCs based on the iProc architecture -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Scott Branden <sbranden@broadcom.com> |
|---|---|
| Date | 2015-10-15 22:30 +0200 |
| Subject | Re: [PATCH v3 01/10] ARM: cygnus: fix link failures when CONFIG_COMMON_CLK_IPROC is disabled |
| Message-ID | <qjXjX-DP-1@gated-at.bofh.it> |
| In reply to | #1248124 |
Jon, One question below for others to comment on. On 15-10-15 12:48 PM, Jon Mason wrote: > From: Arnd Bergmann <arnd@arndb.de> > > When CONFIG_CYGNUS is set but CONFIG_COMMON_CLK_IPROC is disabled, the > following link failures are caused: > > drivers/built-in.o: In function `cygnus_armpll_init': > :(.init.text+0x1d290): undefined reference to `iproc_armpll_setup' > drivers/built-in.o: In function `cygnus_genpll_clk_init': > :(.init.text+0x1d2c4): undefined reference to `iproc_pll_clk_setup' > drivers/built-in.o: In function `cygnus_lcpll0_clk_init': > :(.init.text+0x1d304): undefined reference to `iproc_pll_clk_setup' > drivers/built-in.o: In function `cygnus_mipipll_clk_init': > :(.init.text+0x1d344): undefined reference to `iproc_pll_clk_setup' > drivers/built-in.o: In function `cygnus_asiu_init': > :(.init.text+0x1d370): undefined reference to `iproc_asiu_setup' > > It is fixed it by always selecting COMMON_CLK_IPROC from > ARCH_BCM_IPROC, and making COMMON_CLK_IPROC a silent option (thus > preventing it from being erroneously disabled by a user). > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Jon Mason <jonmason@broadcom.com> > --- > arch/arm/mach-bcm/Kconfig | 2 +- > drivers/clk/bcm/Kconfig | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig > index 1319c3c..84bd265 100644 > --- a/arch/arm/mach-bcm/Kconfig > +++ b/arch/arm/mach-bcm/Kconfig > @@ -14,7 +14,7 @@ config ARCH_BCM_IPROC > select HAVE_ARM_SCU if SMP > select HAVE_ARM_TWD if SMP > select ARM_GLOBAL_TIMER > - > + select COMMON_CLK_IPROC > select CLKSRC_MMIO > select ARCH_REQUIRE_GPIOLIB > select ARM_AMBA > diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig > index 88febf5..46ee475 100644 > --- a/drivers/clk/bcm/Kconfig > +++ b/drivers/clk/bcm/Kconfig > @@ -9,10 +9,8 @@ config CLK_BCM_KONA > in the BCM281xx and BCM21664 families. > > config COMMON_CLK_IPROC > - bool "Broadcom iProc clock support" > - depends on ARCH_BCM_IPROC > + bool > depends on COMMON_CLK Should these depends on remain? I think COMMON_CLK_IPROC won't work without them. > - default ARCH_BCM_IPROC > help > Enable common clock framework support for Broadcom SoCs > based on the iProc architecture > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Jon Mason <jonmason@broadcom.com> |
|---|---|
| Date | 2015-10-15 23:10 +0200 |
| Subject | Re: [PATCH v3 01/10] ARM: cygnus: fix link failures when CONFIG_COMMON_CLK_IPROC is disabled |
| Message-ID | <qjXWG-1Ez-29@gated-at.bofh.it> |
| In reply to | #1248145 |
On Thu, Oct 15, 2015 at 01:28:50PM -0700, Scott Branden wrote: > Jon, > > One question below for others to comment on. > > On 15-10-15 12:48 PM, Jon Mason wrote: > >From: Arnd Bergmann <arnd@arndb.de> > > > >When CONFIG_CYGNUS is set but CONFIG_COMMON_CLK_IPROC is disabled, the > >following link failures are caused: > > > >drivers/built-in.o: In function `cygnus_armpll_init': > >:(.init.text+0x1d290): undefined reference to `iproc_armpll_setup' > >drivers/built-in.o: In function `cygnus_genpll_clk_init': > >:(.init.text+0x1d2c4): undefined reference to `iproc_pll_clk_setup' > >drivers/built-in.o: In function `cygnus_lcpll0_clk_init': > >:(.init.text+0x1d304): undefined reference to `iproc_pll_clk_setup' > >drivers/built-in.o: In function `cygnus_mipipll_clk_init': > >:(.init.text+0x1d344): undefined reference to `iproc_pll_clk_setup' > >drivers/built-in.o: In function `cygnus_asiu_init': > >:(.init.text+0x1d370): undefined reference to `iproc_asiu_setup' > > > >It is fixed it by always selecting COMMON_CLK_IPROC from > >ARCH_BCM_IPROC, and making COMMON_CLK_IPROC a silent option (thus > >preventing it from being erroneously disabled by a user). > > > >Signed-off-by: Arnd Bergmann <arnd@arndb.de> > >Signed-off-by: Jon Mason <jonmason@broadcom.com> > >--- > > arch/arm/mach-bcm/Kconfig | 2 +- > > drivers/clk/bcm/Kconfig | 4 +--- > > 2 files changed, 2 insertions(+), 4 deletions(-) > > > >diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig > >index 1319c3c..84bd265 100644 > >--- a/arch/arm/mach-bcm/Kconfig > >+++ b/arch/arm/mach-bcm/Kconfig > >@@ -14,7 +14,7 @@ config ARCH_BCM_IPROC > > select HAVE_ARM_SCU if SMP > > select HAVE_ARM_TWD if SMP > > select ARM_GLOBAL_TIMER > >- > >+ select COMMON_CLK_IPROC > > select CLKSRC_MMIO > > select ARCH_REQUIRE_GPIOLIB > > select ARM_AMBA > >diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig > >index 88febf5..46ee475 100644 > >--- a/drivers/clk/bcm/Kconfig > >+++ b/drivers/clk/bcm/Kconfig > >@@ -9,10 +9,8 @@ config CLK_BCM_KONA > > in the BCM281xx and BCM21664 families. > > > > config COMMON_CLK_IPROC > >- bool "Broadcom iProc clock support" > >- depends on ARCH_BCM_IPROC > >+ bool > > depends on COMMON_CLK > Should these depends on remain? I think COMMON_CLK_IPROC won't work > without them. The ones that were removed were not necessary (as ARCH_BCM_IPROC now selects it). I left the "depends on COMMON_CLK" in the off chance that the dependency chain gets broken some how (as ARCH_BCM_IPROC is not selecting COMMON_CLK directly, but it is being selected by ARCH_MULTIPLATFORM). Thanks, Jon > >- default ARCH_BCM_IPROC > > help > > Enable common clock framework support for Broadcom SoCs > > based on the iProc architecture > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Hauke Mehrtens <hauke@hauke-m.de> |
|---|---|
| Date | 2015-10-15 23:20 +0200 |
| Subject | Re: [PATCH v3 01/10] ARM: cygnus: fix link failures when CONFIG_COMMON_CLK_IPROC is disabled |
| Message-ID | <qjY6m-1PP-9@gated-at.bofh.it> |
| In reply to | #1248124 |
On 10/15/2015 09:48 PM, Jon Mason wrote: > From: Arnd Bergmann <arnd@arndb.de> > > When CONFIG_CYGNUS is set but CONFIG_COMMON_CLK_IPROC is disabled, the > following link failures are caused: > > drivers/built-in.o: In function `cygnus_armpll_init': > :(.init.text+0x1d290): undefined reference to `iproc_armpll_setup' > drivers/built-in.o: In function `cygnus_genpll_clk_init': > :(.init.text+0x1d2c4): undefined reference to `iproc_pll_clk_setup' > drivers/built-in.o: In function `cygnus_lcpll0_clk_init': > :(.init.text+0x1d304): undefined reference to `iproc_pll_clk_setup' > drivers/built-in.o: In function `cygnus_mipipll_clk_init': > :(.init.text+0x1d344): undefined reference to `iproc_pll_clk_setup' > drivers/built-in.o: In function `cygnus_asiu_init': > :(.init.text+0x1d370): undefined reference to `iproc_asiu_setup' > > It is fixed it by always selecting COMMON_CLK_IPROC from > ARCH_BCM_IPROC, and making COMMON_CLK_IPROC a silent option (thus > preventing it from being erroneously disabled by a user). > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Jon Mason <jonmason@broadcom.com> > --- > arch/arm/mach-bcm/Kconfig | 2 +- > drivers/clk/bcm/Kconfig | 4 +--- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig > index 1319c3c..84bd265 100644 > --- a/arch/arm/mach-bcm/Kconfig > +++ b/arch/arm/mach-bcm/Kconfig > @@ -14,7 +14,7 @@ config ARCH_BCM_IPROC > select HAVE_ARM_SCU if SMP > select HAVE_ARM_TWD if SMP > select ARM_GLOBAL_TIMER > - > + select COMMON_CLK_IPROC > select CLKSRC_MMIO > select ARCH_REQUIRE_GPIOLIB > select ARM_AMBA > diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig > index 88febf5..46ee475 100644 > --- a/drivers/clk/bcm/Kconfig > +++ b/drivers/clk/bcm/Kconfig > @@ -9,10 +9,8 @@ config CLK_BCM_KONA > in the BCM281xx and BCM21664 families. > > config COMMON_CLK_IPROC > - bool "Broadcom iProc clock support" > - depends on ARCH_BCM_IPROC > + bool > depends on COMMON_CLK > - default ARCH_BCM_IPROC > help > Enable common clock framework support for Broadcom SoCs > based on the iProc architecture A help text is not needed for a silent option. Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web