Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1247099 > unrolled thread

[PATCH] s390: crypto: replace raw value by their coresponding define

Started byLABBE Corentin <clabbe.montjoie@gmail.com>
First post2015-10-14 21:20 +0200
Last post2015-10-15 20:40 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] s390: crypto: replace raw value by their coresponding define LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-10-14 21:20 +0200
    Re: [PATCH] s390: crypto: replace raw value by their coresponding  define Herbert Xu <herbert@gondor.apana.org.au> - 2015-10-15 15:20 +0200
    [PATCH] lib/mpi: clean unused SHA1_DIGEST_LENGTH LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-10-15 20:40 +0200

#1247099 — [PATCH] s390: crypto: replace raw value by their coresponding define

FromLABBE Corentin <clabbe.montjoie@gmail.com>
Date2015-10-14 21:20 +0200
Subject[PATCH] s390: crypto: replace raw value by their coresponding define
Message-ID<qjzKG-7SB-13@gated-at.bofh.it>
SHA_MAX_STATE_SIZE is just the number of u32 word for SHA512.
So replace the raw value "16" by their meaning (SHA512_DIGEST_SIZE / 4)

Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
 arch/s390/crypto/sha.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/crypto/sha.h b/arch/s390/crypto/sha.h
index f4e9dc7..10f2007 100644
--- a/arch/s390/crypto/sha.h
+++ b/arch/s390/crypto/sha.h
@@ -19,7 +19,7 @@
 #include <crypto/sha.h>
 
 /* must be big enough for the largest SHA variant */
-#define SHA_MAX_STATE_SIZE	16
+#define SHA_MAX_STATE_SIZE	(SHA512_DIGEST_SIZE / 4)
 #define SHA_MAX_BLOCK_SIZE      SHA512_BLOCK_SIZE
 
 struct s390_sha_ctx {
-- 
2.4.9

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1247787 — Re: [PATCH] s390: crypto: replace raw value by their coresponding define

FromHerbert Xu <herbert@gondor.apana.org.au>
Date2015-10-15 15:20 +0200
SubjectRe: [PATCH] s390: crypto: replace raw value by their coresponding define
Message-ID<qjQBR-7uU-13@gated-at.bofh.it>
In reply to#1247099
On Wed, Oct 14, 2015 at 09:11:00PM +0200, LABBE Corentin wrote:
> SHA_MAX_STATE_SIZE is just the number of u32 word for SHA512.
> So replace the raw value "16" by their meaning (SHA512_DIGEST_SIZE / 4)
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>

Applied.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1248072 — [PATCH] lib/mpi: clean unused SHA1_DIGEST_LENGTH

FromLABBE Corentin <clabbe.montjoie@gmail.com>
Date2015-10-15 20:40 +0200
Subject[PATCH] lib/mpi: clean unused SHA1_DIGEST_LENGTH
Message-ID<qjVBw-6l0-21@gated-at.bofh.it>
In reply to#1247099
The define SHA1_DIGEST_LENGTH is not used anywhere, so remove it.

Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
 include/linux/mpi.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/include/linux/mpi.h b/include/linux/mpi.h
index 641b7d6..a792b38 100644
--- a/include/linux/mpi.h
+++ b/include/linux/mpi.h
@@ -32,12 +32,6 @@
 
 #include <linux/types.h>
 
-/* DSI defines */
-
-#define SHA1_DIGEST_LENGTH   20
-
-/*end of DSI defines */
-
 #define BYTES_PER_MPI_LIMB	(BITS_PER_LONG / 8)
 #define BITS_PER_MPI_LIMB	BITS_PER_LONG
 
-- 
2.4.9

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web