Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1243842 > unrolled thread
| Started by | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| First post | 2015-10-10 09:30 +0200 |
| Last post | 2015-10-15 13:50 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v3] i2c: s3c2410: enable RuntimePM before registering to the core Wolfram Sang <wsa@the-dreams.de> - 2015-10-10 09:30 +0200
Re: [PATCH v3] i2c: s3c2410: enable RuntimePM before registering to the core Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-10-10 09:50 +0200
Re: [PATCH v3] i2c: s3c2410: enable RuntimePM before registering to the core Kukjin Kim <kgene@kernel.org> - 2015-10-12 21:20 +0200
Re: [PATCH v3] i2c: s3c2410: enable RuntimePM before registering to the core Wolfram Sang <wsa@the-dreams.de> - 2015-10-15 13:50 +0200
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2015-10-10 09:30 +0200 |
| Subject | [PATCH v3] i2c: s3c2410: enable RuntimePM before registering to the core |
| Message-ID | <qhWLo-2on-1@gated-at.bofh.it> |
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
The core may register clients attached to this master which may use
funtionality from the master. So, RuntimePM must be enabled before, otherwise
this will fail. While here, move drvdata, too.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Changes since v2: don't call runtime pm on adaper if it wasn't registered
Thanks to Krzysztof for testing!
drivers/i2c/busses/i2c-s3c2410.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 50bfd8cef5f224..5df819610d5280 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1243,17 +1243,19 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
i2c->adap.nr = i2c->pdata->bus_num;
i2c->adap.dev.of_node = pdev->dev.of_node;
+ platform_set_drvdata(pdev, i2c);
+
+ pm_runtime_enable(&pdev->dev);
+
ret = i2c_add_numbered_adapter(&i2c->adap);
if (ret < 0) {
dev_err(&pdev->dev, "failed to add bus to i2c core\n");
+ pm_runtime_disable(&pdev->dev);
s3c24xx_i2c_deregister_cpufreq(i2c);
clk_unprepare(i2c->clk);
return ret;
}
- platform_set_drvdata(pdev, i2c);
-
- pm_runtime_enable(&pdev->dev);
pm_runtime_enable(&i2c->adap.dev);
dev_info(&pdev->dev, "%s: S3C I2C adapter\n", dev_name(&i2c->adap.dev));
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2015-10-10 09:50 +0200 |
| Subject | Re: [PATCH v3] i2c: s3c2410: enable RuntimePM before registering to the core |
| Message-ID | <qhX4J-2KV-1@gated-at.bofh.it> |
| In reply to | #1243842 |
W dniu 10.10.2015 o 16:24, Wolfram Sang pisze: > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > > The core may register clients attached to this master which may use > funtionality from the master. So, RuntimePM must be enabled before, otherwise > this will fail. While here, move drvdata, too. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > > Changes since v2: don't call runtime pm on adaper if it wasn't registered > > Thanks to Krzysztof for testing! > > drivers/i2c/busses/i2c-s3c2410.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Works good. Error path seems to be working fine as well. Tested on Odroid-XU3 Lite, on top of next-20151009. Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Kukjin Kim <kgene@kernel.org> |
|---|---|
| Date | 2015-10-12 21:20 +0200 |
| Subject | Re: [PATCH v3] i2c: s3c2410: enable RuntimePM before registering to the core |
| Message-ID | <qiQNB-8hD-37@gated-at.bofh.it> |
| In reply to | #1243842 |
On 10/10/15 16:24, Wolfram Sang wrote: > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > > The core may register clients attached to this master which may use > funtionality from the master. So, RuntimePM must be enabled before, otherwise > this will fail. While here, move drvdata, too. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Looks good to me, Acked-by: Kukjin Kim <kgene@kernel.org> Thanks, Kukjin > --- > > Changes since v2: don't call runtime pm on adaper if it wasn't registered > > Thanks to Krzysztof for testing! > > drivers/i2c/busses/i2c-s3c2410.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Date | 2015-10-15 13:50 +0200 |
| Subject | Re: [PATCH v3] i2c: s3c2410: enable RuntimePM before registering to the core |
| Message-ID | <qjPcJ-5ko-3@gated-at.bofh.it> |
| In reply to | #1243842 |
[Multipart message — attachments visible in raw view] — view raw
On Sat, Oct 10, 2015 at 08:24:23AM +0100, Wolfram Sang wrote: > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > > The core may register clients attached to this master which may use > funtionality from the master. So, RuntimePM must be enabled before, otherwise > this will fail. While here, move drvdata, too. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Applied to for-current, thanks!
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web