Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1247717 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2015-10-15 13:50 +0200 |
| Last post | 2015-10-15 14:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3 1/4] mtd: nand: allow compile test of MTD_NAND_PXA3xx Arnd Bergmann <arnd@arndb.de> - 2015-10-15 13:50 +0200
Re: [PATCH v3 1/4] mtd: nand: allow compile test of MTD_NAND_PXA3xx Antoine Tenart <antoine.tenart@free-electrons.com> - 2015-10-15 14:00 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2015-10-15 13:50 +0200 |
| Subject | Re: [PATCH v3 1/4] mtd: nand: allow compile test of MTD_NAND_PXA3xx |
| Message-ID | <qjPcJ-5ko-13@gated-at.bofh.it> |
On Thursday 15 October 2015 17:12:18 kbuild test robot wrote: > drivers/mtd/nand/pxa3xx_nand.c: In function 'drain_fifo': > >> drivers/mtd/nand/pxa3xx_nand.c:507:4: error: implicit declaration of function 'readsl' [-Werror=implicit-function-declaration] > readsl(info->mmio_base + NDDB, data, 8); > ^ It should be easy to fix this by changing the code to use ioread32_rep() instead of readsl(). They behave the same way on pointers returned from ioremap() etc, and the other one is available on all architectures. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Antoine Tenart <antoine.tenart@free-electrons.com> |
|---|---|
| Date | 2015-10-15 14:00 +0200 |
| Message-ID | <qjPmr-5vG-13@gated-at.bofh.it> |
| In reply to | #1247717 |
Hi Arnd, On Thu, Oct 15, 2015 at 01:44:19PM +0200, Arnd Bergmann wrote: > On Thursday 15 October 2015 17:12:18 kbuild test robot wrote: > > drivers/mtd/nand/pxa3xx_nand.c: In function 'drain_fifo': > > >> drivers/mtd/nand/pxa3xx_nand.c:507:4: error: implicit declaration of function 'readsl' [-Werror=implicit-function-declaration] > > readsl(info->mmio_base + NDDB, data, 8); > > ^ > > It should be easy to fix this by changing the code to use ioread32_rep() instead > of readsl(). They behave the same way on pointers returned from ioremap() etc, > and the other one is available on all architectures. Sure, I can add a patch fixing this prior to the one allowing to compile test the pxa3xx nand driver. Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web