Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1247275 > unrolled thread

Re: [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers Eric Anholt <eric@anholt.net> - 2015-10-15 02:50 +0200
    Re: [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform  drivers Luis de Bethencourt <luis@debethencourt.com> - 2015-10-15 14:40 +0200

#1247275 — Re: [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers

[Multipart message — attachments visible in raw view] — view raw

Luis de Bethencourt <luis@debethencourt.com> writes:

> These platform drivers have a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> ---
>  sound/soc/bcm/bcm2835-i2s.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c
> index 03fa1cb..8c435be 100644
> --- a/sound/soc/bcm/bcm2835-i2s.c
> +++ b/sound/soc/bcm/bcm2835-i2s.c
> @@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = {
>  	{},
>  };
>  
> +MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
> +
>  static struct platform_driver bcm2835_i2s_driver = {
>  	.probe		= bcm2835_i2s_probe,
>  	.driver		= {
> -- 

It looks like this should go through the asoc tree, but I don't see it
in there.

FWIW, it is also:

Acked-by: Eric Anholt <eric@anholt.net>

[toc] | [next] | [standalone]

#1247764 — Re: [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform drivers

On Wed, Oct 14, 2015 at 05:44:46PM -0700, Eric Anholt wrote:
> Luis de Bethencourt <luis@debethencourt.com> writes:
> 
> > These platform drivers have a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> >
> > Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> > ---
> >  sound/soc/bcm/bcm2835-i2s.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c
> > index 03fa1cb..8c435be 100644
> > --- a/sound/soc/bcm/bcm2835-i2s.c
> > +++ b/sound/soc/bcm/bcm2835-i2s.c
> > @@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = {
> >  	{},
> >  };
> >  
> > +MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
> > +
> >  static struct platform_driver bcm2835_i2s_driver = {
> >  	.probe		= bcm2835_i2s_probe,
> >  	.driver		= {
> > -- 
> 
> It looks like this should go through the asoc tree, but I don't see it
> in there.
> 
> FWIW, it is also:
> 
> Acked-by: Eric Anholt <eric@anholt.net>

Hi Eric,

Should I resend adding somebody from the asoc tree to the CC?

Thanks for the review,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web