Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1246625 > unrolled thread
| Started by | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| First post | 2015-10-14 14:40 +0200 |
| Last post | 2015-10-15 01:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c:70:2-8: preceding lock on line 67 Julia Lawall <julia.lawall@lip6.fr> - 2015-10-14 14:40 +0200
Re: drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c:70:2-8: preceding lock on line 67 Ben Skeggs <bskeggs@redhat.com> - 2015-10-15 01:40 +0200
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2015-10-14 14:40 +0200 |
| Subject | Re: drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c:70:2-8: preceding lock on line 67 |
| Message-ID | <qjtvA-70U-15@gated-at.bofh.it> |
Please check whether not releasing the lock is intentional.
julia
On Wed, 14 Oct 2015, kbuild test robot wrote:
> CC: kbuild-all@01.org
> CC: linux-kernel@vger.kernel.org
> TO: Ben Skeggs <bskeggs@redhat.com>
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 5b5f1455272e23f4e7889cec37228802d8d01adf
> commit: 344c2d429dd86b1b0113177e18f15adb74e9d936 drm/nouveau/fb: remove dependence on namedb/engctx lookup
> date: 7 weeks ago
> :::::: branch date: 16 hours ago
> :::::: commit date: 7 weeks ago
>
> >> drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c:70:2-8: preceding lock on line 67
>
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git remote update linus
> git checkout 344c2d429dd86b1b0113177e18f15adb74e9d936
> vim +70 drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c
>
> 344c2d42 Ben Skeggs 2015-08-20 61 }
> 344c2d42 Ben Skeggs 2015-08-20 62
> 344c2d42 Ben Skeggs 2015-08-20 63 struct nvkm_fifo_chan *
> 344c2d42 Ben Skeggs 2015-08-20 64 nvkm_fifo_chan_chid(struct nvkm_fifo *fifo, int chid, unsigned long *rflags)
> 344c2d42 Ben Skeggs 2015-08-20 65 {
> 344c2d42 Ben Skeggs 2015-08-20 66 unsigned long flags;
> 344c2d42 Ben Skeggs 2015-08-20 @67 spin_lock_irqsave(&fifo->lock, flags);
> 344c2d42 Ben Skeggs 2015-08-20 68 if (fifo->channel[chid]) {
> 344c2d42 Ben Skeggs 2015-08-20 69 *rflags = flags;
> 344c2d42 Ben Skeggs 2015-08-20 @70 return (void *)fifo->channel[chid];
> 344c2d42 Ben Skeggs 2015-08-20 71 }
> 344c2d42 Ben Skeggs 2015-08-20 72 spin_unlock_irqrestore(&fifo->lock, flags);
> 344c2d42 Ben Skeggs 2015-08-20 73 return NULL;
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Ben Skeggs <bskeggs@redhat.com> |
|---|---|
| Date | 2015-10-15 01:40 +0200 |
| Message-ID | <qjDOh-5ts-1@gated-at.bofh.it> |
| In reply to | #1246625 |
[Multipart message — attachments visible in raw view] — view raw
On 10/14/2015 10:30 PM, Julia Lawall wrote:
> Please check whether not releasing the lock is intentional.
It's intentional, there's a nvkm_fifo_chan_put() that releases it again,
which should be used everywhere a successful acquire has occurred.
Ben.
>
> julia
>
> On Wed, 14 Oct 2015, kbuild test robot wrote:
>
>> CC: kbuild-all@01.org
>> CC: linux-kernel@vger.kernel.org
>> TO: Ben Skeggs <bskeggs@redhat.com>
>>
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: 5b5f1455272e23f4e7889cec37228802d8d01adf
>> commit: 344c2d429dd86b1b0113177e18f15adb74e9d936 drm/nouveau/fb: remove dependence on namedb/engctx lookup
>> date: 7 weeks ago
>> :::::: branch date: 16 hours ago
>> :::::: commit date: 7 weeks ago
>>
>>>> drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c:70:2-8: preceding lock on line 67
>>
>> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>> git remote update linus
>> git checkout 344c2d429dd86b1b0113177e18f15adb74e9d936
>> vim +70 drivers/gpu/drm/nouveau/nvkm/engine/fifo/base.c
>>
>> 344c2d42 Ben Skeggs 2015-08-20 61 }
>> 344c2d42 Ben Skeggs 2015-08-20 62
>> 344c2d42 Ben Skeggs 2015-08-20 63 struct nvkm_fifo_chan *
>> 344c2d42 Ben Skeggs 2015-08-20 64 nvkm_fifo_chan_chid(struct nvkm_fifo *fifo, int chid, unsigned long *rflags)
>> 344c2d42 Ben Skeggs 2015-08-20 65 {
>> 344c2d42 Ben Skeggs 2015-08-20 66 unsigned long flags;
>> 344c2d42 Ben Skeggs 2015-08-20 @67 spin_lock_irqsave(&fifo->lock, flags);
>> 344c2d42 Ben Skeggs 2015-08-20 68 if (fifo->channel[chid]) {
>> 344c2d42 Ben Skeggs 2015-08-20 69 *rflags = flags;
>> 344c2d42 Ben Skeggs 2015-08-20 @70 return (void *)fifo->channel[chid];
>> 344c2d42 Ben Skeggs 2015-08-20 71 }
>> 344c2d42 Ben Skeggs 2015-08-20 72 spin_unlock_irqrestore(&fifo->lock, flags);
>> 344c2d42 Ben Skeggs 2015-08-20 73 return NULL;
>>
>> ---
>> 0-DAY kernel test infrastructure Open Source Technology Center
>> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web