Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1247121 > unrolled thread

[PATCH 5/7] ARM: mach-stm32: Select pinctrl

Started byMaxime Coquelin <mcoquelin.stm32@gmail.com>
First post2015-10-14 22:10 +0200
Last post2015-10-15 21:50 +0200
Articles 2 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 5/7] ARM: mach-stm32: Select pinctrl Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-10-14 22:10 +0200
    Re: [PATCH 5/7] ARM: mach-stm32: Select pinctrl Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2015-10-15 21:50 +0200

#1247121 — [PATCH 5/7] ARM: mach-stm32: Select pinctrl

FromMaxime Coquelin <mcoquelin.stm32@gmail.com>
Date2015-10-14 22:10 +0200
Subject[PATCH 5/7] ARM: mach-stm32: Select pinctrl
Message-ID<qjAx4-CQ-13@gated-at.bofh.it>
Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
---
 arch/arm/Kconfig                          | 1 +
 drivers/pinctrl/stm32/pinctrl-stm32f429.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index bf94e54..8b1afd4 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -985,6 +985,7 @@ config ARCH_STM32
 	select ARMV7M_SYSTICK
 	select CLKSRC_STM32
 	select RESET_CONTROLLER
+	select PINCTRL
 	help
 	  Support for STMicroelectronics STM32 processors.
 
diff --git a/drivers/pinctrl/stm32/pinctrl-stm32f429.c b/drivers/pinctrl/stm32/pinctrl-stm32f429.c
index 3535037..f34016b 100644
--- a/drivers/pinctrl/stm32/pinctrl-stm32f429.c
+++ b/drivers/pinctrl/stm32/pinctrl-stm32f429.c
@@ -1564,7 +1564,7 @@ static const struct stm32_desc_pin stm32f429_pins[] = {
 	),
 };
 
-struct stm32_pinctrl_match_data stm32f429_match_data = {
+static struct stm32_pinctrl_match_data stm32f429_match_data = {
 	.pins = stm32f429_pins,
 	.npins = ARRAY_SIZE(stm32f429_pins),
 };
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1248109

FromMaxime Coquelin <mcoquelin.stm32@gmail.com>
Date2015-10-15 21:50 +0200
Message-ID<qjWHf-7WB-5@gated-at.bofh.it>
In reply to#1247121
Hi,

Commenting myself before someone else does...

On 10/14/2015 10:07 PM, Maxime Coquelin wrote:
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> ---
>   arch/arm/Kconfig                          | 1 +
>   drivers/pinctrl/stm32/pinctrl-stm32f429.c | 2 +-
>   2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index bf94e54..8b1afd4 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -985,6 +985,7 @@ config ARCH_STM32
>   	select ARMV7M_SYSTICK
>   	select CLKSRC_STM32
>   	select RESET_CONTROLLER
> +	select PINCTRL
This is not in alphabetical order...

>   	help
>   	  Support for STMicroelectronics STM32 processors.
>
> diff --git a/drivers/pinctrl/stm32/pinctrl-stm32f429.c b/drivers/pinctrl/stm32/pinctrl-stm32f429.c
> index 3535037..f34016b 100644
> --- a/drivers/pinctrl/stm32/pinctrl-stm32f429.c
> +++ b/drivers/pinctrl/stm32/pinctrl-stm32f429.c
> @@ -1564,7 +1564,7 @@ static const struct stm32_desc_pin stm32f429_pins[] = {
>   	),
>   };
>
> -struct stm32_pinctrl_match_data stm32f429_match_data = {
> +static struct stm32_pinctrl_match_data stm32f429_match_data = {
>   	.pins = stm32f429_pins,
>   	.npins = ARRAY_SIZE(stm32f429_pins),
>   };
>

And I didn't fixed-up in the good patch... Should go in the driver one.

Will be fixed in the v2.

Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web